Commit eb948c02 authored by Ulf Hermann's avatar Ulf Hermann

Timeline: Remove selectionIdForLocation()

Nobody needs that.

Change-Id: I83feeb55af24393a3feebfbbd4d0f085b208bb20
Reviewed-by: default avatarChristian Kandeler <christian.kandeler@theqtcompany.com>
parent 4af5d70f
......@@ -375,14 +375,6 @@ bool TimelineModel::handlesTypeId(int typeIndex) const
return false;
}
int TimelineModel::selectionIdForLocation(const QString &filename, int line, int column) const
{
Q_UNUSED(filename);
Q_UNUSED(line);
Q_UNUSED(column);
return -1;
}
float TimelineModel::relativeHeight(int index) const
{
Q_UNUSED(index);
......
......@@ -99,8 +99,6 @@ public:
Q_INVOKABLE virtual QVariantMap location(int index) const;
Q_INVOKABLE virtual int typeId(int index) const;
Q_INVOKABLE virtual bool handlesTypeId(int typeId) const;
Q_INVOKABLE virtual int selectionIdForLocation(const QString &filename, int line,
int column) const;
Q_INVOKABLE virtual float relativeHeight(int index) const;
Q_INVOKABLE virtual int rowMinValue(int rowNumber) const;
Q_INVOKABLE virtual int rowMaxValue(int rowNumber) const;
......
......@@ -227,21 +227,6 @@ int QmlProfilerRangeModel::typeId(int index) const
return selectionId(index);
}
int QmlProfilerRangeModel::selectionIdForLocation(const QString &filename, int line, int column) const
{
// if this is called from v8 view, we don't have the column number, it will be -1
const QVector<QmlEventType> &types = modelManager()->qmlModel()->eventTypes();
for (int i = 1; i < expandedRowCount(); ++i) {
int typeId = m_expandedRowTypes[i];
const QmlEventType &eventData = types[typeId];
if (eventData.location.filename == filename &&
eventData.location.line == line &&
(column == -1 || eventData.location.column == column))
return typeId;
}
return -1;
}
QList<const Timeline::TimelineRenderPass *> QmlProfilerRangeModel::supportedRenderPasses() const
{
if (supportsBindingLoops()) {
......
......@@ -69,7 +69,6 @@ public:
QVariantMap location(int index) const override;
int typeId(int index) const override;
int selectionIdForLocation(const QString &filename, int line, int column) const override;
virtual QList<const Timeline::TimelineRenderPass *> supportedRenderPasses() const override;
......
......@@ -370,7 +370,6 @@ void tst_TimelineModel::defaultValues()
Timeline::TimelineModel dummy(12);
QCOMPARE(dummy.location(0), QVariantMap());
QCOMPARE(dummy.handlesTypeId(0), false);
QCOMPARE(dummy.selectionIdForLocation(QString(), 0, 0), -1);
QCOMPARE(dummy.relativeHeight(0), 1.0);
QCOMPARE(dummy.rowMinValue(0), 0);
QCOMPARE(dummy.rowMaxValue(0), 0);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment