Skip to content

GitLab

Commit ebc1d369 authored by hjk's avatar hjk
Browse files
Options

BareMetal: Add a few 'final' to re-implementations 

Change-Id: Id34c29d5aa95198c987a6ca02ccfd6645c112f84
Reviewed-by: Christian Stenger's avatarChristian Stenger <christian.stenger@qt.io>
parent 8c90998f
Hide whitespace changes
Inline Side-by-side
Showing with 45 additions and 45 deletions
src/plugins/baremetal/defaultgdbserverprovider.h
View file @ ebc1d369
......@@ -36,19 +36,19 @@ class DefaultGdbServerProviderFactory;
class DefaultGdbServerProvider : public GdbServerProvider
{
public:
QString typeDisplayName() const;
QString typeDisplayName() const final;
QVariantMap toMap() const;
bool fromMap(const QVariantMap &data);
QVariantMap toMap() const final;
bool fromMap(const QVariantMap &data) final;
bool operator==(const GdbServerProvider &) const;
bool operator==(const GdbServerProvider &) const final;
GdbServerProviderConfigWidget *configurationWidget();
GdbServerProvider *clone() const;
GdbServerProviderConfigWidget *configurationWidget() final;
GdbServerProvider *clone() const final;
QString channel() const;
QString channel() const final;
bool isValid() const;
bool isValid() const final;
QString host() const;
void setHost(const QString &host);
......@@ -75,10 +75,10 @@ class DefaultGdbServerProviderFactory : public GdbServerProviderFactory
public:
explicit DefaultGdbServerProviderFactory();
GdbServerProvider *create();
GdbServerProvider *create() final;
bool canRestore(const QVariantMap &data);
GdbServerProvider *restore(const QVariantMap &data);
bool canRestore(const QVariantMap &data) final;
GdbServerProvider *restore(const QVariantMap &data) final;
GdbServerProviderConfigWidget *configurationWidget(GdbServerProvider *);
};
......@@ -91,8 +91,8 @@ public:
explicit DefaultGdbServerProviderConfigWidget(DefaultGdbServerProvider *);
private:
void applyImpl();
void discardImpl();
void applyImpl() final;
void discardImpl() final;
void setFromProvider();
......
src/plugins/baremetal/openocdgdbserverprovider.h
View file @ ebc1d369
......@@ -38,22 +38,22 @@ class OpenOcdGdbServerProviderFactory;
class OpenOcdGdbServerProvider : public GdbServerProvider
{
public:
QString typeDisplayName() const;
QString typeDisplayName() const final;
QVariantMap toMap() const;
bool fromMap(const QVariantMap &data);
QVariantMap toMap() const final;
bool fromMap(const QVariantMap &data) final;
bool operator==(const GdbServerProvider &) const;
bool operator==(const GdbServerProvider &) const final;
GdbServerProviderConfigWidget *configurationWidget();
GdbServerProvider *clone() const;
GdbServerProviderConfigWidget *configurationWidget() final;
GdbServerProvider *clone() const final;
QString channel() const;
QString executable() const;
QStringList arguments() const;
QString channel() const final;
QString executable() const final;
QStringList arguments() const final;
bool canStartupMode(StartupMode mode) const;
bool isValid() const;
bool canStartupMode(StartupMode mode) const final;
bool isValid() const final;
private:
explicit OpenOcdGdbServerProvider();
......@@ -80,10 +80,10 @@ class OpenOcdGdbServerProviderFactory : public GdbServerProviderFactory
public:
explicit OpenOcdGdbServerProviderFactory();
GdbServerProvider *create();
GdbServerProvider *create() final;
bool canRestore(const QVariantMap &data);
GdbServerProvider *restore(const QVariantMap &data);
bool canRestore(const QVariantMap &data) final;
GdbServerProvider *restore(const QVariantMap &data) final;
GdbServerProviderConfigWidget *configurationWidget(GdbServerProvider *);
};
......@@ -99,8 +99,8 @@ private slots:
void startupModeChanged();
private:
void applyImpl();
void discardImpl();
void applyImpl() final;
void discardImpl() final;
void setFromProvider();
......
src/plugins/baremetal/stlinkutilgdbserverprovider.h
View file @ ebc1d369
......@@ -43,22 +43,22 @@ class StLinkUtilGdbServerProvider : public GdbServerProvider
{
public:
enum TransportLayer { ScsiOverUsb = 1, RawUsb = 2 };
QString typeDisplayName() const;
QString typeDisplayName() const final;
QVariantMap toMap() const;
bool fromMap(const QVariantMap &data);
QVariantMap toMap() const final;
bool fromMap(const QVariantMap &data) final;
bool operator==(const GdbServerProvider &) const;
bool operator==(const GdbServerProvider &) const final;
GdbServerProviderConfigWidget *configurationWidget();
GdbServerProvider *clone() const;
GdbServerProviderConfigWidget *configurationWidget() final;
GdbServerProvider *clone() const final;
QString channel() const;
QString executable() const;
QStringList arguments() const;
QString channel() const final;
QString executable() const final;
QStringList arguments() const final;
bool canStartupMode(StartupMode mode) const;
bool isValid() const;
bool canStartupMode(StartupMode mode) const final;
bool isValid() const final;
private:
explicit StLinkUtilGdbServerProvider();
......@@ -86,10 +86,10 @@ class StLinkUtilGdbServerProviderFactory : public GdbServerProviderFactory
public:
explicit StLinkUtilGdbServerProviderFactory();
GdbServerProvider *create();
GdbServerProvider *create() final;
bool canRestore(const QVariantMap &data);
GdbServerProvider *restore(const QVariantMap &data);
bool canRestore(const QVariantMap &data) final;
GdbServerProvider *restore(const QVariantMap &data) final;
GdbServerProviderConfigWidget *configurationWidget(GdbServerProvider *);
};
......@@ -105,8 +105,8 @@ private slots:
void startupModeChanged();
private:
void applyImpl();
void discardImpl();
void applyImpl() final;
void discardImpl() final;
StLinkUtilGdbServerProvider::TransportLayer transportLayerFromIndex(int idx) const;
StLinkUtilGdbServerProvider::TransportLayer transportLayer() const;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment