- 29 Sep, 2014 2 commits
-
-
hjk authored
... and some of the related implementation details Change-Id: I1f03aa5acf2d3fb2cfc2a6a7845f3d3578b0408d Reviewed-by:
David Schulz <david.schulz@digia.com>
-
Eike Ziller authored
Follow symbol in next split broke with fd9b2af9 because the flag was no longer handled through EditorManager::openEditorAt Also remove the flag NoNewSplits which is no longer used, and simplify how links are opened from the C++ editor. Change-Id: I845cc3a0a43d82b79d5c46a273232b69fd6e3ea9 Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
- 26 Sep, 2014 2 commits
-
-
hjk authored
Less noise on the user side. Change-Id: Ia5b495a1f9d3ec43623056d793f6771b3b84fd6b Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
hjk authored
*Document* and *Layout* classes, all basetext* files Change-Id: I1c6e376733a434fcb5c7f19c6210dfa031eeafde Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
- 25 Sep, 2014 1 commit
-
-
hjk authored
First step of some more 'Base' removal in TextEditor. s/Core::TextDocument/Core::BaseTextDocument/ s/TextEditor::BaseTextDocument/TextEditor::TextDocument/ Change-Id: I71ba325a2f0ad72ec9dae0d96846cbae72d326f7 Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 19 Sep, 2014 1 commit
-
-
hjk authored
Replace the CppModelManagerInterface/derived CppModelManager combo by a more common CppModelManager/CppModelManagerPrivate pimpl pattern. Change-Id: Ia4582845ed94d5ef60b8571bab9b2260c6290287 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 16 Sep, 2014 1 commit
-
-
Erik Verbruggen authored
This cleans up the handling of those settings, and makes sure that the C++ document is setting those settings before parsing. This also prevents lock contention in the parser, because before this patch the document would kick of the initial parse (after opening a document), after which the editor would come in and try to set the preprocessor settings, resulting in the UI thread locking until the initial parse was done. Change-Id: Ia2e18a9667e10279f045c1c5849046ec4cfe85ae Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 09 Sep, 2014 2 commits
-
-
hjk authored
Simplifies the code base by removing one level of unused and unneeded abstraction. - Merge {I,Default}AssistInterface to AssistInterface - Merge {IAssist,Basic}ProposalItem to AssistProposalItem - Merge {IGenericProposal,BasicProposalItemList}Model to GenericProposalModel Change-Id: I54ee7b095427383d67a00fc1d87c3808c21d812d Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
Nikolai Kosjar authored
CppLocalRenaming was connected to the initial QPlainTextEdit::document() and not the "updated" QTextDocument set by BaseTextEditorWidgetPrivate::setupDocumentSignals(). Broken by commit c655d7e5 CppEditor: Convert to new construction scheme Change-Id: I2e785a9d62a3bd39d9e613776cfc8e35dd9ff5d4 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 08 Sep, 2014 1 commit
-
-
hjk authored
Fixes a recent regression. Change-Id: Iaa4eb936274b33057fc6c8fdcfbe751b9ab28b75 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com> Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 04 Sep, 2014 3 commits
-
-
hjk authored
Change-Id: I3bfa201352127b34d46fe5bb4b18fab12aeafa3a Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
hjk authored
Change-Id: I8b5c160912ca7da4bbd4ebb01a8b7d5360fb3bbc Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
This was already done in all major editors and should not harm all others. Change-Id: I7e19d285c4b85419a9a1f9afa961addecf682eaf Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
- 03 Sep, 2014 3 commits
-
-
hjk authored
Change-Id: I9ea66b8a890c75cd993a0e160d79231e5662a1e3 Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
hjk authored
opt-out now, for all editors created by BaseTextEditorFactories. Change-Id: I01d0a9ff26320fcd0b84ff90ff22c747cf84b84c Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
All the others live there, too. Change-Id: I0a418bf235343d40a53fbee089234765386ee05d Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 02 Sep, 2014 3 commits
-
-
Eike Ziller authored
instead of manually adding a context everywhere. Change-Id: I4336015a6d19349171a255e949da89b0013d6700 Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Only used there, and avoids back-links to editors. Change-Id: I81206057ce89d42aef7febb840cf9e44b869df0e Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: Ice47cc3ad86bd8d1fe6eaa812bf6fbb096fdd56c Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
- 29 Aug, 2014 5 commits
-
-
Nikolai Kosjar authored
...so that SemanticInfoUpdater does not depend anymore on the EditorDocumentParser. Accessing the snapshot was a blocking operation that delayed the semantic info update longer than actually needed. Change-Id: I348d22ef83ab310d4319b2e8b9678fe90ee24d6a Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
This will update the use selections synchronously again in case the user triggered "Rename Symbol Under Cursor", just as before commit 89bd4ee3 C++: Base parsing on editor document instead of widget Change-Id: I8d4d3dcc7140a61f9ac611a505db09dc96a17740 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Erik Verbruggen authored
When the environment variable QTC_NO_FUNCTION_DECL_DEF_LINK_TRACKING is set, no method declaration/definition tracking is performed. This is to see if QTCREATORBUG-11262 is triggered due to the tracking. Task-number: QTCREATORBUG-11262 Change-Id: Id4cb1fabf9304f8bf42393cb65c402adf8818e2a Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
Erik Verbruggen authored
This will hopefully help a bit in resolving the crashes that happen in QCoreApplication::notifyInternal. Change-Id: Ib3aa8c1a1f50778bd89938d7c529d8399ccf91ea Task-number: QTCREATORBUG-11262 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
Nikolai Kosjar authored
Fixes local use highlighting and renaming in new split, among others. Done-with: hjk <hjk121@nokiamail.com> Change-Id: Ic604d37d2dc0082fa4a75c2af457f60d6d6cfa66 Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 28 Aug, 2014 1 commit
-
-
hjk authored
This removes the ones that were not to be used anymore. The fallback in the base class is left in for now. Change-Id: I5e7ab16497a83eff9b11deb9e1feb390757eac0e Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 27 Aug, 2014 2 commits
-
-
hjk authored
Change-Id: I947f76b4dbc3a197cd49993855c3b0f5e3dc7b49 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Better in line with the rest. Change-Id: I692c8b6b9bebf22f059709fb60e53ea04fcb7d53 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 25 Aug, 2014 1 commit
-
-
Nikolai Kosjar authored
This mainly takes CppEditorSupport apart. * Parsing is now invoked by CPPEditorDocument itself by listening to QTextDocument::contentsChanged(). * Upon construction and destruction CPPEditorDocument creates and deletes an EditorDocumentHandle for (un)registration in the model manager. This handle provides everything to generate the working copy and to access the editor document processor. * A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that controls parsing, semantic info recalculation and the semantic highlighting for the document. This is more or less what is left from CppEditorSupport and can be considered as the backend of a CPPEditorDocument. CPPEditorDocument itself is quite small. * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor derive from BaseEditorDocumentProcessor and implement the gaps. * Since the semantic info calculation was bound to the widget, it also calculated the local uses, which depend on the cursor position. This calculation got moved into the extracted class UseSeletionsUpdater in the cppeditor plugin, which is run once the cursor position changes or the semantic info document is updated. * Some more logic got extracted: - SemanticInfoUpdater (logic was in CppEditorSupport) - SemanticHighlighter (logic was in CppEditorSupport) * The *Parser and *Processor classes can be easily accessed by the static function get(). * CppHighlightingSupport is gone since it turned out to be useless. * The editor dependency in CompletionAssistProviders is gone since we actually only need the file path now. Change-Id: I49d3a7bd138c5ed9620123e34480772535156508 Reviewed-by:
Orgad Shaneh <orgads@gmail.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 22 Aug, 2014 2 commits
-
-
hjk authored
Change-Id: Id2531b7841a0a173f07f7310fb0dc434ac5ec5f8 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
hjk authored
This needs more reorganization. For now, use a method to add cpp editor support directly without relying on a fully set up editor/widget/document combo. Change-Id: Id8631c75ccd209f418faef31f8b8a4c71e53d87d Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 21 Aug, 2014 1 commit
-
-
hjk authored
Change-Id: Ifb51606f71100223631d086318c230a478d70712 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 20 Aug, 2014 6 commits
-
-
hjk authored
All editors did that manually, with varying approaches. Connect once when the document is made known to the EditorWidget instead. Change-Id: Ib0828b08158539859f6f89c8080435a027aa06ed Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
Nikolai Kosjar authored
Change-Id: I3c42d9df93756d9f85682465b9661d7e75ffa71e Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I1d572e8cc3e76ef6bbae720e3c3482292aab9609 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I554b5e9e3f1ef7c167fa45b5cd0c230fdf63073b Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I447acf28849bffb52c1e6b6eafdde221ec0b179e Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
They do not really depend on CppEditorWidget and will be re-used in a follow-up change. CppEditorWidget::identifierUnderCursor() CppEditorWidget::findCanonicalMacro() Change-Id: I553bb68694fb4b5f1baa331debf33ae234e3dedf Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 19 Aug, 2014 2 commits
-
-
hjk authored
In most cases, the *Editor constructor does not need to access the *EditorWidget. Change-Id: I1f5c076a0f723d5d82b398e8c250c7bd1d47eb17 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: I45d87d0be722ac36d64af222f03f8cb76242c9df Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 18 Aug, 2014 1 commit
-
-
hjk authored
A more direct approach than going through the widget's baseTextDocument, relying on widget life time. Change-Id: I62c10e53b1a9a1e6717c6eb3e3cc78dcbfd2868e Reviewed-by:
hjk <hjk121@nokiamail.com>
-