GitLab

Change-Id: I499d35c45344c21eb4b8aae9e3bab4eb59e13544

Change-Id: I2646a2c30573417ba9da4b57b100d33144cef349
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

We only checked for ApplicationWindow. Instead of ApplicationWindow
we have to check for Window. ApplicationWindow is derived from Window.

Change-Id: I5d287af4284e31dcd77e06b498c5ae61dc348ad6
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

Change-Id: I42be43ece7b8791e4299776f86fc3d9740ecffb8
Reviewed-by: hjk <hjk121@nokiamail.com>

This is to fragile and allows many opportunities for serious bugs.

Change-Id: I2e49c37db4c1dd2c55000013d8ec7e0978d1ef89
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

Template based SpinBoxes were to small in some cases.

Change-Id: I8bb3ca98cfe53172fc25171c81b3178657737d65
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

To HEAD of 1.2 branch.

Change-Id: Ifc794212edb88b968a7d7de7ba1cf1259613daa9
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This is a regression, the editor was not recognized as being
a disassembly view anymore.

Change-Id: I281ecf0a49bb4e365b252793f6a5aa89f7b432ff
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-12027
Change-Id: Ic5ad0e16a7d60dacc89fa4c226e30a40a45be9db
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

I also show 2 decimals for the template based real SpinBox.

Task-number: QTCREATORBUG-12041
Change-Id: Iac79dec47c9ec55913231e327ba2727e0af5c652
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Robert Loehning <robert.loehning@digia.com>

The WinRT xmkspecs detection was broken by this patch.

This reverts commit 8095a212.

Change-Id: I6bc1b2dc2e090c6e7bd0cfa1894b678083a1d107
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

Task-number: QTCREATORBUG-12025
Change-Id: I5348869e8627ca7de0cd5f3c67bbeb3353770f15
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

qt4 qmake does not like spaces between 'for' and the opening paren.

Task-number: QTCREATORBUG-12024
Change-Id: I8697272b4f752495f3bf6ff2c6d01c4ac2ea837f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

After doing this once, the active file tags were not reset, so
building everything was no longer possible.

Change-Id: I98df5f55e129cc4a72921aff51201e1860ba939a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

The context is stateful and there could be any kind of junk left in it.
In particular, the W3C spec says that it should be set up with a default
clipping path on creation, but it doesn't say what should happen if the
canvas is resized. Thus, we can never be sure that the clipping path is
sane.

Task-number: QTBUG-38297
Change-Id: If04597234e71574573888ce14deac5cf50df4a3f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Addresses the following findings of QTCREATORBUG-12030:
 * qtc.helgrind.plugintests.txt#2
 * qtc.helgrind.usingEditors1.txt#1

Helgrind report (truncated):

Possible data race during write of size 4 at 0x23679618 by thread #1
Locks held: none
   at 0x6819003: ???
   by 0x681D713: ???
   by 0x68200DE: ???
   by 0x684B8F8: QTextCursor::insertText(QString const&, QTextCharFormat const&)
   by 0x684BCB9: QTextCursor::insertText(QString const&)
   by 0x139DA06C: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1866)
   by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)

This conflicts with a previous read of size 4 by thread #18
Locks held: none
   at 0x680BC54: QTextDocument::revision() const
   by 0x159047F3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
   by 0x158E39BF: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
   by 0x158E3D5B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
   by 0x1589FF6F: CppTools::Internal::CppCompletionAssistInterface::getCppSpecifics() const (cppcompletionassist.cpp:1957)
   by 0x158A1158: CppTools::Internal::CppCompletionAssistInterface::snapshot() const (cppcompletionassist.h:200)
   by 0x1589707C: CppTools::Internal::CppCompletionAssistProcessor::startCompletionInternal(QString, unsigned int, unsigned int, QString const&, int) (cppcompletionassist.cpp:1212)
   by 0x15893CC7: CppTools::Internal::CppCompletionAssistProcessor::startCompletionHelper() (cppcompletionassist.cpp:970)

---

Possible data race during write of size 4 at 0x24C8AD18 by thread #1
Locks held: none
   at 0x684AF23: QTextCursor::beginEditBlock()
   by 0x139D7D05: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1578)
   by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)
   ...
   by 0x40F15A: main (main.cpp:533)

This conflicts with a previous read of size 4 by thread #11
Locks held: none
   at 0x680BC54: QTextDocument::revision() const
   by 0x159048D3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
   by 0x158E3A9F: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
   by 0x158E3E3B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
   by 0x1590741E: parse(QFutureInterface<void>&, QSharedPointer<CppTools::SnapshotUpdater>) (cpptoolseditorsupport.cpp:299)

Task-number: QTCREATORBUG-12030
Change-Id: Idf0aa47f1f6bfd6814a961fe39d3b19b98f934f5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

The optimization in question could lead to an empty source and thus to
no highlighting. Checking for 'force' and the revisions is at this point
not enough since later the semantic info calculcation can be aborted, so
that a subsequent recalculation would get an empty document.

contents() itself is already optimized (uses caching).

Task-number: QTCREATORBUG-11367
Change-Id: If31a8ab0c848e4babd38104961fb9812f077a2be
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

...when collecting data for the semantic highlighting recalculation.

Task-number: QTCREATORBUG-11037

Change-Id: Ibed73a2916df0a91aedef166de2c8c6bb5df309c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: Icf30cf6683f5cc04f3801465148d95bed2002a4a
Reviewed-by: David Schulz <david.schulz@digia.com>

it takes a variable, not a value.

the spec_pre.prf part is cherry-picked from qtbase/89a558d6b0fac.

Change-Id: Ie7e551cf0b889d7682f032124dd0466ada6972e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-12013

Change-Id: I6b8fa2409b2a6530267717879d82713313ae6672
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Vladimir Minenko <vminenko@blackberry.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Access by address. Big hammer, but LLDB doesn't cope
well with templates...

Change-Id: I430a83c282bc8a46efa011efb73f32cdbf46398c
Reviewed-by: hjk <hjk121@nokiamail.com>

Not a full fix yet. Disconnect does not reduce the count
since the Connection object remains in the structure,
only the receiver gets set to 0.

The connections are now listed as subitem of [signals]

Change-Id: I3dd795b3731b30e2af6f4d0e5da71dbde8996649
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Clang/LLDB toolchain issue: -1 gets recorded and read
as 'int' with value '0xffffffff'.

Change-Id: I070a83c282bc8a46efa011efb73f32cdbf46398c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I9b98ddc6f3efdf8d16a373fa6e3d92480c8629d6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11367
Change-Id: I8b02c30a43a57c547bc07d796f4b29725beca793
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

When asked for Foo::staticMetaObject, it will find
any *::staticMetaObject. Looking for the mangled name
finds the one we need.

Change-Id: I4508a3c282bc8a46efa011efb73f32cdbf46398c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The wizard in 3.1 uses a Window QML type instead of a Rectangle,
which means that states must be placed within a statusGroup.
The example can no longer be built from Qt Quick 1 elements.
Replaced \snippet commands with \quotefromfile commands.

Change-Id: Ia2cec2b8b638913a2b9b2e27b36e6f2f1ffc4a49
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

Change-Id: I7bd3813bab7a8006ab418990f0e742be7d6f400a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
(cherry picked from commit 0d303db8)

When inserting new items into the TaskFilterModel we could end up
duplicating the items. Do not do that.

Change-Id: I2450bac185a881e16f23368b39ce5e273c061d99
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

There's no need to keep those handles open throughout the
lifetime of the stub.

Change-Id: I27dd1f26edc1ccd150b913a7f38bab70d8b10763
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>

Update screen shot.

Change-Id: I770a83c282bc8a46efa011efb73f32cdbf46398c
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

The Qt Quick Application wizard now offers the latest versions
of Qt Quick Controls (1.1) and Qt Quick (2.2).

Change-Id: Ief8c2c83632ad77dfdaaec2361ed7913538a0f9c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

Change-Id: I5a8be96da231a8f7ced19aa6010ae08a55fcc601
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>

Change-Id: I2dd795b3731b30e2af6f4d0e5da71dbde8996649
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I90669dac9de394e2d80be1a689b3b8b443296942
Reviewed-by: Robert Loehning <robert.loehning@digia.com>

Change-Id: Id3e6eddffe8d0edd7d5947c2eec03d707bd2436b
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

This mostly re-activates code from the old code path
in the QObject dumper.

Task-number: QTCREATORBUG-11997

Change-Id: Ie3e6eddffe8d0edd7d5947c2eec03d707bd2436b
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Translated by Japan Qt Users' Group
on Transifex.com
https://www.transifex.com/projects/p/qt-creator/language/ja/

Change-Id: I0398a8f5b2dd0b7f1d10280d2387758a734b45ad
Done-with: Tasuku Suzuki <stasuku@gmail.com>
Done-with: Takahiro Hashimoto <kenya888@gmail.com>
Done-with: yikei lu
Done-with: Noboru Murakami <nobo66@hotmail.com>
Done-with: Naoki MATSUMOTO
Reviewed-by: Tasuku Suzuki <stasuku@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: I66f8f5df5931c1d273d33f2d95a9bf130c1dec15
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>