GitLab

Mostly done using the following ruby script:
Dir.glob('**/*.cpp').each { |file|
  next if file =~ %r{src/shared/qbs|/qmljs/}
  s = File.read(file)
  s.scan(/^using namespace (.*);$/) {
    ns = $1
    t = s.gsub(/^(.*)\b#{ns}::((?!Const)[A-Z])/) { |m|
      before = $1
      char = $2
      if before =~ /"|\/\/|\\|using|SIGNAL|SLOT|Q_/
        m
      else
        before + char
      end
    }
    if t != s
      puts file
      File.open(file, 'w').write(t)
    end
  }
}

Change-Id: I1d05d48b23f44e3d589cc2a790803714786b57d2
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>

The action was triggered after the focused widget was reset.

Change-Id: I093d827472fa608649f98ac1339e957532965c0d
Reviewed-by: hjk <hjk@theqtcompany.com>

Invalid positions should not happen, but handle them anyway if they do.
There is one report about a crash in the task model that may be related
to this.

Task-number: QTCREATORBUG-13861
Change-Id: Iae1b25974220d3622ecc39bd1a073c299b843fea
Reviewed-by: Sandro Mani <manisandro@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: I923b856170f1c4ddd48da2434bf77d4b46da8d99
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Iaec01ca0e7a43592528bcaf4252540561e109919
Reviewed-by: hjk <hjk@theqtcompany.com>

... only not simultaneously

Task-number: QTCREATORBUG-3443
Change-Id: Ie88ee305a1ad134d81a19cece42f7fd81fc08f16
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>

Change-Id: I4852ff215abf25649fc5eac1e922ae901839ca3d
Reviewed-by: hjk <hjk@theqtcompany.com>

Qt nowadays logs into journald in some setups, so retrieve the output
from there and put it into the application output pane.

Change-Id: Ia2199a1420e1d80541f2f455e242d0b473922125
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: If4e5eebea2502bba3a85b8f8f87a9a81514f4fb5
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: If53a0c4d2b0e34a724ffeac1c3e489fb1240d176
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: I4a84579311a606d442805acbac2793e8b5ddf515
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I7c6829462c627638da0b8452a17cdf179ac71087
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The Checkout wizard will not feature any generator.

Change-Id: I05900309a5ea8a638493ab0fa5499759bcdc181f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I6f5fd3818d51ee531b92be0b78b4435d621fe0ed
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: Ia96ac950ec209fcbc82c7b49b72d0b6417b99906
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Make VcsManager provide a generic way to list all IVersionControls
and to search for a specific one based on its id.

At some point we want to register the IVersionControls directly
with the VcsManager instead of going through the object pool and this
is a first step into this direction.

Change-Id: Id4ded85b29487f6d8adcd0cec1de490afae07132
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Full separation does not seem possible as QTreeView assumes
all items to have equal column count.

Change-Id: Ia260924fe13ea62789923af8484f9838295355b6
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

The code that invalidates m_currentNode folder nodes on removing wasn't
run due to a typo.

Change-Id: Ib7d545da4078275b2875c9a4c6246909234c8073
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: I6631f0aec8a487095f4c6133c1c2a4dad8f810ee
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Removing a kit removes the item from the TreeModel and puts it into
KitModel::m_toRemoveList. A later update to that kit would trigger
the lambda connected to the dirty signal, thus calling node->update(),
which eventually ends up calling node->parent()->m_children, and
node->parent() is a null pointer there.

Change-Id: I9006f1eea036ae99b48a47baa2bc2a33bdcb84b1
Reviewed-by: hjk <hjk@theqtcompany.com>

D'oh. This boolean needs to be set to true to have any effect.

Task-number: QTCREATORBUG-13848
Change-Id: Idb6559a9b395b3aea4f3379698914b00eb9a031d
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Introduced in 1ed12d39

Change-Id: I623e081a6abc80bd6926daf55fc18ab0cb400863
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Task-number: QTCREATORBUG-13831
Change-Id: Iaeb11014ed16bc9f08d7c12d81c1b7b8a4163d21
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Ided1a14481cfbbcc49e901f3837e056582ff60e3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The output windows nowdays have a "focus-stealing" preventing mechanism,
where if a outputpane has focus, we typically don't switch but instead
flash the corresponding pane.

Maybe the api for outputpanes needs another rethinking to come up with
the correct enums.

Task-number: QTCREATORBUG-13646
Change-Id: I9db7da7e23206617f6da1c4d24ba8c2ba5583612
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Follows the recently established pattern.

Change-Id: I869da4df9d1d879ebff3ed7c45e8c33f376968a0
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Opening the context menu would move the focus, which then would
reset the current node/project to come from the DocumentManager.

So move the context menu handling code to the ProjectTree class
and ensure that while it is open, the corresponding ProjectTree
is considered the focused widget.

Task-number: QTCREATORBUG-13684
Change-Id: I8b3dc410f5f5bc5e9a2dd663421b22cf3f147190
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

... and use the items themselves as main entry point for
item related operations.

With non-uniform tree items it's easier to have item specific
functionality directly in the item implementation instead of
the model.

Change-Id: I4e9b7db98d16b91ddef81917417691129bb83621
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

The Generic Project Manager builds the tree from the bottom to the
top. Previously no signals were emitted while doing that since
the watchers were added on adding the top level node at the end.

With the new ProjectTree that leads to lots of signals, and leaves
the FlatModel confussed, as that expects the nodes to be already
in the hierarchy and crashes otherwise.

Restore this behavior by checking if the affected nodes are in
the hierarchy.

Change-Id: I832b348867a8abad2afef11297b44f058592cb1d
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

The idea behind NodesWatcher was that it was the central place
to catch node related signals, so that users didn't need to
connect to each individual node and the nodes didn't need to
be QObjects. Somehow Nodes ended up being QObjects anyway.

Both the recently added ProjectTree and the FlatModels consume
the signals the NodesWatcher sends. Unfortunately there's a
ordering dependency between the ProjectTree and the FlatModels.

This patch removes all NodesWatcher and instead makes the
ProjectTree singleton the emitter of various project tree
related signals. The ProjectTree also ensures that the ordering
between the FlatModel and itself is taken into account.

And it makes Node not derive from QObject, saving some memory
in that process.

Task-number: QTCREATORBUG-13756
Change-Id: I8b0d357863f1dc1d2d440ce8172502594138b9fb
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Using a (local) widget derived class for the main page all
keeps the .h cleaner and removes the need for the custom
model plus related signaling.

Change-Id: If1b118b56cc1cd06d459fd5491de673e2436dd77
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I212ea6a177d7364778c28e30225c6f0da926bbd2
Reviewed-by: hjk <hjk@theqtcompany.com>

Qt Creator has been showing them as errors, but they're little more than
noise in the output.

Creator still doesn't understand "remark" lines from ICC, but that's
something for another day.

Change-Id: Ic894fe41f92a677ddbe09beb0ea4c557edeb0547
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Make DeployConfigurationFactory a true base class. Introduce the
DefaultDeployConfigurationFactory as the implementation that
actually creates DefaultDeployConfigurations.

This mostly moves code around. The virtual canHandle method was
mostly unused and was removed from most classes.

Change-Id: I170d94c648e67f3fe52a76ffb5344f389ae49efc
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I07244e510e44a3ee2af5e771450ab6413a5a5c2d
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I7a113418205485b1f616d4b92666a8fc92edd399
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

ProjectTree::currentProject is not the right project to track.

Change-Id: Ia9da32a24e73565c4b9a3739c4000c13b803375f
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>

Change-Id: I285437f8eb21ce9f1a32d631a9c75d32d5ab2859
Reviewed-by: hjk <hjk@theqtcompany.com>

Make it possible to set or clear the file iterator while a search is
currently running.

Change-Id: I5309a8920057112375ce22e5fd24806fb6f09857
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Simplifies code.

Change-Id: I3db07f8b0ffd980856e65abee856559a0a85dfdb
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>