GitLab

It was for llvm/clang >= 4.0, but we are still on 3.9 for now.

Change-Id: I29338b6ed90b3ac4f32021085139e6917fd5ac9e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>

That centralizes all the focus setting, raising of windows, etc. This
was for example already done wrong when opening links in help mode and
external window.

Change-Id: I5036b5caa751d1f36dc442078624a31fb8f573ee
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

When using the "Web Search" locator filter ('r') or "Get Help Online"
from the context menu on build errors in the issues pane, we already
know that we want to show the URL in an external browser, not help mode.

Task-number: QTCREATORBUG-17795
Change-Id: Ie7faa527907124251a60e7618747d81a6003fa19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

A header file was indirectly included in debug mode.

Change-Id: I9142fc9b92fd6db1182c6602a0ac4a723aa2c9f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: Id902cfa6387bcb6ad96da0cd36f3114f795afd99
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Use one-line lambdas

Change-Id: I85d1fe33283b6c517a1942d833d6b127002540f5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

Change-Id: Id0f9a8ca3d0e395e46d6f7a4c01c6a33d1bc7688
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Change-Id: Ie846d6996298b74a4b55c359787fd4f63b471cdf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

Change-Id: Id2ccd3712370609e2d6a0b126ba2d4934ff1f763
Reviewed-by: Niels Weber <niels.weber@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I6d189aa17c43d740115cbaa5f410059f364b82d5
Reviewed-by: Jake Petroules <jake.petroules@qt.io>

That's what it is.

Change-Id: I8cf9af23bb7cafe1cde8f165fdbf85cdeb79f7e4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: Ie649a4a11c88f3686cd6ed1e73f34c7c78fd0e13
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: If5d7368cf46b789c80162271cb6e71ebaae1548e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: Ifb1dcc847ba4b32a79b349955fad5207e402cb7b

RunControl::setRunnable is meant to go in the long run, individual
RunWorkers are better suited to handle their needs (and only their
needs) than trusting a one-Runnable-fits-all-workers-in-RunControl
setups.

Change-Id: I6bdb32cc69581503dd252af83b75428c0de2f648
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: Idf5297b2b29f74722bfc7f8ae1b1aa7e6de92f90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

QGraphicsObject is a QObject and significantly heavier
then QGraphicsItem. There is no need to use
QGraphicsObject in our case.
Using QGraphicsItem instead is simply good practice.

Change-Id: I65f9db85eace25fd0e7873093e903d923eb338dc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

I also removed the hard assert.

Change-Id: Ia15d9f82fb63e7d8dd6acf8547b9e96bad838d3f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

If QtQuick Controls 1 are missing there is no reason to
build QmlDesigner.

Change-Id: Ic8777fef6addc460b05c8218d96aa13379f02cea
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

This amends commit a6c17fc5.

Change-Id: I365513a9e11e6c07310799f87a4e299cd110dcf3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

It breaks running over PuTTY with VcxSrv.

This reverts commit 36c8227c.

Task-number: QTCREATORBUG-18467
Change-Id: Id93497ee24cdb574d1e4a1ac1b0fb112012a695d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

Less code.

Change-Id: Ie3bd75557e4f4b5acff65a9b3a074692ea652253
Reviewed-by: hjk <hjk@qt.io>

This enables us to mark perspectives as disabled.

Change-Id: I52b2434f33f8550b6d2459f915dfd8cdb1389140
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>

Less code, and it's what most other targets do nowadays.

Change-Id: I2cf55d1a32ad10427ce2508536d03bca8921b451
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: Ic5947003945d4cfc87484106052e98e06e4e700a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Change-Id: I3743815c14151b49784a20cdb0c0bba2fbde4e7b
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Aspect creation must stay for now as the object pool is the only
central registry for it right now.

Change-Id: Ibe42009db6b0351aaa36e9ac8f0f6f7a0562167e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Let the workers keep track of errors instead of passing around
string pointers in some but not all interesting places.

Change-Id: I3956bc947a50747dd3a0c9302b9f9873d192e9c6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: I97a532f80b9dc2b40ec5931116b207cfaeef8f4b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Task-number: QTCREATORBUG-15710
Change-Id: Id4a0e3e42249cdd281ed79b0914faacfb3450e37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I0df22407e19a71a4ab216d413ce682a793287aa3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I05c8345e5f1618e7ecbb8a9c27feb5b9a321dc11
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: hjk <hjk@qt.io>

Change-Id: Icfe86b98ab8162fe613dbf089fec1692c5d3dbea
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

When navigating to headers that are not part of the project, avoid
showing the inline diagnostics. In most cases, these files can't be
changed.

This helps also for the session-load case where files are opened/parsed
when no project information is available yet.

Change-Id: I7fce24af78b3b1efbf64dd27d8ca2a053e02d4ec
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: Ie05ad37ae7711a6deb152c5aa0a926e9b83b082b
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

Change-Id: Idd0115937c6db36f64087f49c116339f291bfcd3
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>

And move the "Show Sidebar" button into the status bar that we
need now anyhow.

Change-Id: I24bfa0991cbdcdba4d1a8cd6cbacde28d459972d
Reviewed-by: David Schulz <david.schulz@qt.io>

A RunControl is re-runnable if all its workers are,
a RunWorker is re-runnable if it's Stopped and unless it
says otherwise.

Also ensure SimpleTargetRunner only reportStop() once
per run and make process error message re-usable.

Change-Id: I73f5fb724d3026ceb81d5e32a3a71b4814b2bca9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Task-number:  QTCREATORBUG-18498
Change-Id: Ie40a066508bb52f53b8ad528f9d4cf6969fc0632
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>

Task-number: QTCREATORBUG-18512
Change-Id: I4713165f131894bd9b881d8de25ff1e8a1a39e51
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>