GitLab

We settled now on global objects being fine for the purpose
in Core and ProjectExplorer, so there's no point in using
something more fancy in the debugger.

Change-Id: I72e45f398c09d22894419c274dfbea77da0fc153
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Some leftover stringfreeze workaround, plus QLatin1*.

Change-Id: I5e143af5cda64cb29b7769174187fc86185a89cb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ice7e751609503a55ebcd8a488e42feecd0a293c0
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Change-Id: Id955967e57c12839dec5a54511662ec92f1e43e5
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

This is a real bottle neck on Windows
and I do not know of a case where it is required.

Change-Id: I99ebf3bfdd22cfb0ed82d6d39eeb83f079f654d6
Reviewed-by: Marco Benelli <marco.benelli@qt.io>

In the tests we have cases with no rewriter attached.
We warn in these cases.

Change-Id: Ibc89ff501bf6d48ed3a2f230ee6e1afda5d4d06c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

...with MSVC2013.

tst_lexer.cpp(406) : error C2398: Element '1': conversion from
  'CPlusPlus::Kind' to 'unsigned int' requires a narrowing conversion

Change-Id: I1c9415cb02d2f0fa85d48a1abbc688d8f53b5b43
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
(cherry picked from commit 04b21947)

The heavy lifting was done by clazy.

Change-Id: If3332a2b4a6d011d2cb74996f5dd750452093f31
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Change-Id: I59e7df86e24f4be5c2c69313883fdc182f3071d2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

... and remove casts where possible.

Change-Id: I10305efbe336de7aa5efdb73a52c5f89cd2d089e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

Avoid using functionality introduced with Qt5.6.

Change-Id: Icfa4eeb547b651a19aa745b5de1cb413f9b6b4ef
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

States can of course contain PropertyChanges.

Change-Id: Ie78be1db58c6820a49356b1cd70102e10211030b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

...when showing the refactoring marker and generating the quick fix
operations.

Opening main.cpp

  main.cpp:
   #include "file.h"
   void f(char *s) { foo(s); }

  file.h:
    // significant line 1
    // significant line 2
    // significant line 3
    bool foo(int fd);

led to

    SOFT ASSERT: "textBlock.isValid()" in file
    clangdiagnosticmanager.cpp, line 205

and a misbehavior when applying the fixit from the tooltip.

We take the line of a diagnostic to display the fixit marker if it has
any fixits. But the (child) diagnostic might be issued for an other file
(that's what happening here), so better take the line of the location
where the fixit is meant to be applied.

Same applies for generation of the quick fix entries.

Change-Id: I48d38420b285d2d2f86e3faa2319513aa8b47848
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

 Conflicts:
	src/plugins/projectexplorer/runconfiguration.h
	tests/unit/unittest/unittest.pro

Change-Id: I3d327b1198df2a7e9268916af9624ce5d21195df

Change-Id: I97cd6f47c20867277ed7612a0cf5a179dedd7501
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Rip out QFileSystemWatcher and use Qt Creators IDocument for file
watching instead. The latter properly delays any action till creator
gets focus again.

Task-number: QTCREATORBUG-16354
Change-Id: Ibb71963416b09712a80ee95347425550453b7fd4
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

Task-number: QTCREATORBUG-15934
Change-Id: I54fdb505a451fb269c3747a370c8dfd7043c6c9d
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

The heavy lifting was done by clazy.

Change-Id: I56550546b341d486d321329e9a90b9369d56af40
Reviewed-by: Marco Benelli <marco.benelli@qt.io>

For external windows we need to separate the contexts in which help
mode's "add bookmark" and editor's "toggle bookmark" are present.

Task-number: QTCREATORBUG-16286
Change-Id: I2a7a28c75dc53e1dd0b21c0a8833bd4594d5afad
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

...and not all projects parts of a project if it is closed.

Re-produce with:
  open a project A with subdirs (e.g. qtcreator.pro)
  open a subdir project from project A (e.g. cppeditor.pro)
  close project A
  --> The project part representing the subdir is announced as removed
      although it is still open.

The clang code model was the only affected user - affected translation
units were not parsed/updated anymore
("ERROR: ProjectPartDoesNotExistMessage").

Change-Id: Ia79341ce201e3b4aefff9f597920dbc6f7d67634
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Most Qt4 connects are gone.

Change-Id: Ie74cfb11fc4b4c531f9e22c95a4d18336e1c29e8
Reviewed-by: hjk <hjk@theqtcompany.com>

It is used in invokeMethod

Change-Id: Ic4c1d69efefc41069f36be4cf94b06efdc265b11
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: Ifd9f89c0d3b5c060af28bdb29e93a5b95f6dc9cd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

When e.g. examining 'CONFIG+=foo bar' Creator would turn that into
CONFIG+=foo and 'CONFIG+=foo bar', which seems wrong to me.

Task-number: QTCREATORBUG-16492
Change-Id: I37b83f1e8415d421abb2df7a9466651bff502d17
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Change-Id: I4cbfa65c5b8481c859081f43893431c0b93b3cd7
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

This was a regression after the merge of error/warning
dialog.

Change-Id: I6bd9d2e81d118018a40745a98e67b1bff8f84d4f
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>

If the project contains .ui.qml files the designer proposes to
open .ui.qml files instead of opening a .qml file.

This encourages to not open the .qml files in the designer.

This feature can be disabled.

Change-Id: I47a877ea72fafb07ebee485b8f22509f6162993c
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

Change-Id: Ie652f1bc8b04163befc012e4abd7432d71f4d92c
Reviewed-by: Jake Petroules <jake.petroules@qt.io>

If there are manu components (e.g. 200) in the same directory,
the model was updated for each component.

This patch compresses the signal and therefore reduced the updates.

Change-Id: I80b38df59952dda7e67e258ecd6e5f29d6a036e6
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

Initially this adds basic gtest testing - to be improved later on.

Change-Id: I2121cd24493a8d65c5acd0be5c9dd5858702645d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: Ic838f141956f3aa1f32d90e977dd1e59d22df016
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Expanding variables includes calling cleanPath on the input. At that
point macros like %{buildDir} need to be expanded already or working
directories like "%{buildDir}/../test" will get turned into "test",
which is not what a user expects to happen.

Change-Id: I61e6604a621f632ddee87766d38ab3c863bdb9dc
Reviewed-by: hjk <hjk@theqtcompany.com>

Re-enable macro substitution in work directory of run configurations.

This makes it possible to do %{sourceDir} or %{buildDir} again.

Task-number: QTCREATORBUG-16338
Change-Id: Ifff7831bf3aa0078d13185da5f5e7c6a3be2f852
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I56399e6938a5f5096c0b1a1561a54d34a5c96330

This moves the fromUserInput that used to be in rawFileName to fileName,
so that fileName produces the same output it used to produce.

Change-Id: Ifb209af3f60d959c3f7119ebfa20f999c5d5f0ca
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I4294fb7dd448e74236e085f7a1884ecedd5a5b90
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Saves a couple of static_casts on the user side.

Change-Id: Ib8f70046ae40539813c01e3ff7d790bf7a170bee
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

... and use it to add a ParentType *parent() function.

Also, de-virtualize the TreeModel::parent(), this flexibility has not
been needed so far.

Change-Id: I0bcf930a0d6b05d5621753a5a8a1f8c3e5017386
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Do not call cleanPath on rawFileName as that sanitizes %{buildDir}/.. to '.',
which is not what is expected for a rawFileName.

Change-Id: I4bb95b33f4c12c79ed0029d5fbf539e113a3774c
Reviewed-by: hjk <hjk@theqtcompany.com>