GitLab

Change-Id: Ife43116c45299811f4b2f80364346f4d267f26d7
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

MSVC suddenly has this problem when bulding Qt Creator master Qt5 dev.

error C2352: 'TextEditor::BaseTextEditorWidget::extraSelections' :
illegal call of non-static member function
error C2825: 'T': must be a class or namespace when followed by '::'
...

This patch works it around by simply using this->

Change-Id: I8aae3e76f80248e1dd27d87552d14a81eda0d25f
Reviewed-by: hjk <hjk121@nokiamail.com>

the non-const QImage::bits() performs shared-data checks. With
QImage::constBits() we can skip those for sure in cases where we only
want to read.

Change-Id: Ic5f328b54eb2d9930ad31b4df8d9b636dc005982
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Iaf89bc399db65e17345effb2e9767692786b5ca8
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

...where applicable. Shorter, faster, more semantic.

Change-Id: Ifb1cf200f489f62a79e12c761e98a846992744dc
Reviewed-by: hjk <hjk121@nokiamail.com>

Turns out we don't even need two-phase initialization,
by transparently postponing registration until we get
a non-empty file name, either at constuction, or at
file name change times.

Change-Id: I3e87e47c820066e6707e946fc474ab9c1993e61f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I1e31529081002f3bdfe4be7b610ec6ec8e6139df
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I733aa001a721376ad69c0ae492290e37c71b6f84
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

By moving internally used methods to EditorManagerPrivate

Change-Id: I046ce92b8baffe4bcd2ea0529557a3ae69f74338
Reviewed-by: hjk <hjk121@nokiamail.com>

The only project manager that actually sometimes changes the displayname
is the cmake project manager. And that one failed to emit the right
signal. And since the signal was never emitted a few places handled the
signal wrongly.

Change-Id: I4aa75dc3032efe49263143dbadb7585a378b9be9
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Since projects without targets are special, this code apparently tracked
if hasTarget() changed due to a kitUpdate. But we are already connected
to targetRemoved() and checks whether a project has no target anymore.

Thus this code is redundant and can be removed.

Change-Id: I245887075509ed4c0ecda383de0227ccbc58b9af
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

The indirection via a factory is no longer useful, since the
targetsettingspanel is hardcoded for a build and run panel.

Change-Id: I75543f777a4a7df4cadf12667652424056829689
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Instead hide it in a standard IProjectPanelFactory

Change-Id: I7e49b7be00e26c5f33e32d692079e2b82cbfe087
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ib2ad82c8bbbb62dd72b3a2497a7e213206613654
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I6d5442fb42727fd3fa0a841800cbf55c5ec494f0
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I40f9411f305ab7764b904306bbccd45887dc7432
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

This was the common base class of IProjectPanelFactory and
ITargetPanelFactory. Nothing was using the IPanelFactory interface, and
there's actually no common interface between those classes.

Of the old interface IPanelFactory:
id() => only used in ITargetPanelFactory
displayName() => only used in IProjectPanelFactory
priority() => only used in IProjectPanelFactory

This removes lots of boiler plate code for the unused functions.

Change-Id: I8488a4e5134fd451907f02c45b7847673e4dc714
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I657277feb77f33b345f58729cdc1c05b1fdb5528
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The TargetSettingsPanelWidget wants to keep whether the Build or Run tab
is shown synchronized between projects. Moving the code to
TargetSettingsPanelWidget removes some of the special handling
ProjectWindow does.

Change-Id: Ic4e85b6458a1271ea2de4d8c5786e95d3a78fbbd
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I257bb9310bb3bde493aff4cd43091ec63fcb5203

Use a variable for the path to the bin directories,
because the example PATH is most likely wrong.
Add a link to "Using Command Line Options" and move the
note there, because it is advanced usage (needed only for
self-built Qt Creator). However, these developers will
probably know how to set the PATH.

Change-Id: I6d6563f0c7d6aebcc4a5887f9cbb86b5d7e1676a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Idbe281a55fd6a30b258686f7d384a9a8d5088ed1
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

A case or a default statement must be followed by another statement.
When a such a case (or default) statement is followed immediately by
another case (or default) statement, then this would create a linked
list, and the parser will recurse to parse such input.

In order to prevent the parser running out of stack space while
recursing, parse this corner case by blocking parsing a labeled
statement as the first statement after a labeled statement.

The advantage is that these statements do not form a linked list, so any
subsequent visitation of the AST won't run out of stack space either.

Change-Id: Id2111a49509132997f5fbe4bb12c92c729ec2522
Task-number: QTCREATORBUG-12673
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Change-Id: I92edf53230d34cb222dcc82391b8046e09c7599d
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This partly reverts commit a1274c93.

Change-Id: I1ba8586ae51a42a2239ee4ae5c8ead2ac880ecfa
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I0b977d3186d8a0ab8f48e1d689e0ab9d045b46e3
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: I52ddd7cc89950c38e95135fdc2ee7cf655782165
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I245af5cc77360aa70838153e0fd8eb15ffe659d8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ie61f71f143ac1b46e092167abb9b58a1d16c36c6
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I4b16d0b511b7e5755c50391c4e1bdf2fabcdc4ab
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

Actually return the value of the m_line member varibale instead of -1.

Change-Id: I23ee47638e9b35cafcedca827790b4c2e0a02462
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I0c2281703d4708bf07702d9d2fc148842489bb04
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

There is no reason for the editor manager itself to be a widget. This
makes even less sense in the presence of multiple windows.

Change-Id: I384f8945fdd5632d64643e473e6637e05abbce7e
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Task-number: QTCREATORBUG-3423
Change-Id: I708302b94caa9ad50fc0e7f65a635a7ec4f753d4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Alongside with Ministro is by far the fastest deployment method.

Change-Id: I02de831d312d60c50762e8130ccffefcf1f36843
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

The debug deployment method can't be used to create APKs that can be
published on Android markets.

Change-Id: I0539e1e7bcbf5935d74f9ee93cadc8b296a94664
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I7adc3a814a82c0621d8caf315021f0510c390488
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Task-number: QTCREATORBUG-12705
Change-Id: I3daee35ed5a5ce8688e54a50b3a8ca4f5c9d4c5b
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: I52cf75ec558b6f59b731abdca2bbebafb527f181
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: I5f8b8436815c871e462c888e9963c8ee754bbc72
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>