GitLab

take it out of the editor->open() error path. it's unrelated.

Change-Id: I8b73d583be1ee7183f4074bce49d5390e38631a2

add/unify read error handling in all affected classes

this centralizes error reporting (in fact, in most cases it adds any in
the first place).

Task-number: QTCREATORBUG-1619

this replaces the ever-repeating idiom block/save/unblock with a single
call.

Acked-by: hjk

With some refactorings to make the code look better.

Reviewed-by: con

The chooser allows choosing variables from a list, and inserting them
into previously focused line edit, text edit, or plain text edit.
Variables are now registered with a description in the variable manager.
Also make the QT_INSTALL_BINS --> CurrentProject:QT_INSTALL_BINS for
consistency.

It's done via a external tool description now.

For now that removes the CURRENT_DOCUMENT variable and derivates.

Reviewed-by: hjk

Reviewed-by: Tobias Hunger

Reviewed-by: Tobias Hunger

This plugin let the user record and replay some macros:
 * 3 handlers: action, find and texteditor
 * almost all texteditor and cpp actions recorded
 * options page to set the directories where the macros are stored
 * optional dialog to give a name and comment at the end of a macro
 * locator integration to play a macro
 * shortcuts assignment to macro

The most important change outside the plugin macros is the isScriptable method
for command: All scriptable commands can be stored in a macro.

Merge-request: 2176
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>

Task-number: QTCREATORBUG-1785

Fixes a gcc warning about different visibility of struct in files.

Reviewed-by: con

That fires when the current editor fires its changed signal.

Tries to figure out the editor type from the title pattern in that case.

Task-number: QTCREATORBUG-3192

Move #include directive along with matching code.

Written-by: con

promptReadOnlyFile: EditorManager-->FileManager
fileFilters: EditorManager-->MimeDataBase
saveFile & saveFileAs --> IFile based

Reviewed-by: mae

Use the editor's displayName for the window title.
Also there were missing change signal emissions in setDisplayName
implementations.
Moves the actual handling of the window title from Session to
EditorManager (so it now is also done for the hypothetical case of no
project explorer plugin).

Task-number: QTCREATORBUG-3207

We didn't watch the symbolic link itself before, only the final link
target. We are watching the symbolic link and the final link target now.
Ugly hack: We need to work around QTBUG-15522. The inotify and kqueue
based file system watcher engines (Linux + Mac) don't report changes to
symbolic links. The workaround is to use the polling engine *only for
the links themselves*. The only way to force the use of the polling
engine is by using the auto test hook in QFileSystemWatcher.

Krazy was complaining about those.

TextEditor will now recognize an UTF-8 BOM.

A setting to determine what to do on saving has been added as well - the
options are "Always Add", "Keep Already Present" and (mostly for
completeness) "Always Delete".
Note: if encoding is "System", "Always Add" doesn't work, because there
is no API to know what the System encoding is.

Task-number: QTCREATORBUG-1857

Merge-request: 2180
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

* Editor manager should abort closing core, if there's a ICoreListener
that aborts closing of a editor.
* Don't save state of temporary editors, and don't save them as open in
  a splitter. So restoring the editor manager state won't try to reopen
  temporary editors.

Task-number: QTCREATORBUG-2845
Task-number: QTCREATORBUG-2841
Reviewed-by: Tobias Hunger

The debugger plugin opens an editor in this case, leading to fakevim and
cppeditor crashing.
This commit doesn't fix the problem's source, but adds safeguards that
are sensible anyhow: FakeVim should not register with editors during
shutdown, and CppEditor should not unconditionally assume an existing
editor manager in the destructor.

Reviewed-by: Friedemann Kleint

Task-Nr: QTCREATORBUG-2582