GitLab

None of the callers need anything beyond ::map.clear()

Change-Id: I8296d04019f58e0c2fceb672a0e717146b91c1a7
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ie92d142ef92a597ed9174ebfd54b645618e1bed6
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ie73a6c433f52f71edde6f0670956c6b72405e2f1
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Also rename it into Settings.

Change-Id: Id01f664b0cac4de58ffe52eea1aeeaf9cf0891d5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Iba22b820ce5b671a924757d5a24900e20f8c46ae
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ifb886a9ff1ae89063af2ce303f28baf0e92a3ba4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Also rename it bestSettings()

Change-Id: I0d9053d6429b0bd4e51ab9320f114e0a750dd77c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I16564c95769f3bb3af6b096aff2658e1232df35e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

For those functions that don't need the filename.

Change-Id: I10344b164f60d61f3e411e19c4563958a9989479
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Keep the value instead in the map.

Change-Id: I6eec7642104149e1b812efd67a673e112f267630
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Introduce a original version to indicate which version the map was
upgraded from.

THIS CHANGE REMOVES SUPPORT FOR .USER FILES WITHOUT VERSION INFORMATION!

Those files were written before Qt Creator version 1.3.

Change-Id: I2c7264cf84c458b139a9073fc415c257dfbd0498
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I32f5a72900e5bd5446540cb139ff5c004216bde2
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

For now only hold m_writer and m_upgraders (which was m_handlers before)

Change-Id: If0baf99207e777f5d3349d32ef9ddee1b657f604
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ib800069148ed2790bb5f71b9ff42357ead642892
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Instead of hardcoding Core::ICore::mainWindow()

Change-Id: Iec7747945cbcb335ae552a0277a1527f598f1ff7
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Also since incrementVersion is always called in a loop, move the loop
inside the function.

Change-Id: I6550a322b2423ed41f05c729b913647e52906cb9
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I5243a1e7f38314ecd17a157e16b8cb6834a5b75c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

We only save .user files, those are always environment specific

Change-Id: I230ebc769f0fba66546607888bbd8cca5b622a51
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

The idea is to reuse this code elsewhere, so do not talk about
.user files.

Change-Id: I5db557a2c56b1eba2527b0cad2d1bdad4818ab8e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

We do not want to produce output here when those files can not be found,
that is a perfectly normal thing nowadays. So do not produce any output.

Simplify the code a bit now that we do not need to do extra checking.

Change-Id: Ifdfe3148e8a350bf3cd2aca5e78c2458274d75f9
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Also make sure the sanitization of the suffix happens for both
possible suffixes and not just for the first one.

Change-Id: I5d34582323ce147bdf4638e5ec3321227d329609
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I78976e34a0b98e851c7852116a588b0f49009267
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

The PersistentSettings::writeFile needs it, and SettingsAccessor
should not hardcode it to Core::ICore::mainWindow()

Change-Id: I6ca99e9cd861fd81337028055fe0ed4d158b152f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

So far only instantiates the .user file specific upgraders.

Change-Id: I9a16dfe4c3c61093ea1231413495eec2e8fe648e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

The VersionUpgrader is supposed to be generic and not bound to .user
files. Move ahead with the merge of the settings refactoring.

Change-Id: Ie781a1b23dd60d4b15f7fe260f3dad315a8fa503
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

That name is cleaner.

Change-Id: Idafc6d01b79f1748884a77fe06d407a76fa83026
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Instead of a template use a abstract base class.

Change-Id: I92675bf1c19ef60bec22836eda56240c2f2e4c80
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Also rename class from UserFileVersionHandler to VersionUpgrader
userFileVersion -> version
displayUserFileVersion -> backupExtension
update -> upgrade

Change-Id: I2641b6eaee13aa07380a3ccf0e4c13d61f18f920
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ida513eb0537e2ef0c55887d0df21de956e85e983
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ib5423fdd064e4546f848c0b640b0ed0514c26d3a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

More fallout from the non-Python removal.

Change-Id: I15534dd92dfa9823e0a7d609c13f8a71caa9b093
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Id49e347cc448f6a28271b6af775d56b6e00b4908
Reviewed-by: David Schulz <david.schulz@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

First step towards plugin renaming.

Change-Id: I8ac017660a7aa2bda0d7bb7d72ab0cfceaf6cfd2
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Ic4c78e4d2eefeefe55e2868a7f9db1eca52c3863
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: Ibe505c8331f7d1280fdb8784a00321742f5d94cb
Reviewed-by: hjk <hjk121@nokiamail.com>

Apply static 'pattern' for ToolChainManager, de-noise using code.

Change-Id: I196dc6f39dc2c61b1783aecad3faa0b23849e00a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Use setBuildDirectory() in the different BuildConfigurations instead
of reimplementing that over and over again.

Change-Id: Ic355fdb4624c71667ce470b3e2865c9a8722ef09
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ica6cf20c4ae1c7d58386d4970e468a105a3263b3
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ia49c6552a5aae72870687ef9c64f2642fbe24155
Reviewed-by: hjk <hjk121@nokiamail.com>

Broken by 0addee8b

Change-Id: I86caf4146556b1bde0ba7798115672b840ca8621
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>