GitLab

QObject::disconnect: Unexpected null parameter

Change-Id: I9b7fe695f7d9d6acb233d8e9ff1030636559d548
Reviewed-by: hjk <hjk@theqtcompany.com>

when there are removed files in navigation history. Steps to reproduce:
Open file in editor. Remove it outside the qtc. Activate qtc. "File Was
Removed" prompted - agree to remove it. Navigate back(alt left two
times). Qtc goes crazy with endless Error messages like a "Cannot open /
path/to/that/dead.file for reading: No such file or directory"

Change-Id: I10a4c178ba83a8dc769895830b6f76da2e676556
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

That was used during the times where OS X still had alternating row
colors in item views.

Change-Id: I6622604502a768c4abeb42f25bcfea5c65f66395
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: I01621753851a99275ef8bee2c55c69840dc29580
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

It is more reasonable to elide filenames at left and messages at right

Change-Id: I980026eb558c6528da85a5ddb1a7125bb3d7fdce
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The default in QMacStyle, to use FieldsStayAtSizeHint, just almost
always is the wrong thing to do. Additionally this goes undetected for a
while most of the time, because most people do not run their code on OS
X. Override it globally to AllNonFixedFieldsGrow like in other shipped
styles.

Task-number: QTCREATORBUG-14337
Change-Id: I3b0719c0201871fbf0163b54b1a54823bf5d14f3
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: Id39b63876938c6759829786f54f2448ff730d500
Task-number: QTCREATORBUG-13868
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

The view is also used for the regular expressions for FakeVim's
ex command mapping, so we should not do special filtering for
keyboard shortcuts on OS X

Change-Id: I437b45a53beb93caeaec43af2f898c55b2a1601f
Reviewed-by: hjk <hjk@theqtcompany.com>

Incorrect conversion from the Variant to the String is fixed.

Change-Id: I082cdbeee1568d0b6b567232b50419d76572a197
Task-number: QTCREATORBUG-14404
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Rename the signals used to report stdout/stderr to make it clearer
what they actually do. Remove some unimplemented private member
functions while at it.

Change-Id: I7e856f906ccb45964f3b1b64336d4d8ebca7b9ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Ic1988a3a046bf5a4c262d1e648376f077ed97448
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The IOptionsPage parts in it were trivial, and we need more flexibility
for the shortcut settings options pages.

Change-Id: I93ddaf060ac88ef339da9f542719f2d695660ac0
Reviewed-by: hjk <hjk@theqtcompany.com>

For example when developing on Windows, cross compiling to Linux, the
result is not executable from the Windows perspective.
Reverts f2cfd3c0 which changed the code
to use ExistingCommand to get the automatic expansion of app bundles on
OS X, and do automatic expansion of app bundles also when using path
chooser of type File. Choosing an app bundle in a path chooser of type
File would previously lead to an invalid entry in the path chooser
anyhow, because the app bundle itself is not a file.

Change-Id: Ie710c47918d2b8735009e290301ed2683e354f2c
Task-number: QTCREATORBUG-14412
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I88f1de02edcb6c4406de64745ccc4cfc85f3d562
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

The window was cleared even if the option to clear it wasn't
selected. Moving the cursor to the end, has the side effect of
clearing the selection, so do that always.

Change-Id: I6b61981f46394c61e61066aa8033c7e3391e6c07
Task-number: QTCREATORBUG-14410
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Turns out that using Id::uniqueIdentifier() is not deterministic across
invocations of Creator...

Change-Id: I8b78a5b36c2cd61e4b9c5d8cc8eb2c6083282c01
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

... instead of a SLOT(...)

Change-Id: I32ed3ea014d1efde54bac2d5153f3083e37ef7ec
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Idba2af421e07f09b89392b490d0b2eb388553ec9
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Use aggregation instead of inheritance for customization of validation.
Gets rid of a few additional classes.

Change-Id: Iaf8f12026c40a55bfde98b3786100f8ac431d750
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I7bd688333eba40c798e5ba7ae094ee27bac977f4
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

If no node is selected, e.g. no document is open, the ProjectTree
currently claims that there is no current project.

This adds a fallback to startup project in that case. This especially
fixes the case where only one project is open and as such it is clear
from context which project the user expects to be current.

Revert a few places where I implemented this fallback manually.

I do not like this. If multiple projects are open, this fallback can be
surprising and not what the user wants. Everything works fine in the
simple case with one project open but breaks with multiple projects
open, this actively hides bugs.

Change-Id: I6259834ca2220dd83bdffb16c3a0eac8f98e504b
Task-number: QTCREATORBUG-14394
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Just return the last style sentinel.

Change-Id: I2bd1a6e12913e0c208b11efae3baae87c183f39a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Broke in 7481bff2 which split up
LibraryTemplate in SharedLibraryTemplate and StaticLibrary.

Change-Id: I797c007fff09ffd09b7744cf3543217b936dea12
Task-number: QTCREATORBUG-14382
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Change-Id: I0e7112ee3f3790fba42fc882cb98e06ec6a2186d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Task-number: QTCREATORBUG-2536
Change-Id: I94471c265c9f9dbffe253d7c6e8a1e834b47f91f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

By the use of P4CONFIG (p4config.txt) one can now specify workspace
details (P4USER, P4CLIENT, P4PORT) individually for specific projects.

Previously one had to reconfigure Qt Creator in Settings for every
workspace switch.

Change-Id: I117829ab3cf592562a4662f85314aa3c125e7610
Task-number: QTCREATORBUG-14378
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

As the default-constructed value is not zero. This was not considered in
7aa8ae54.

Change-Id: I1f32b1c317e0de34b48dbe003c3968f66133a64d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

It is used in some comments but doesn't compile...

Change-Id: I5ba3afbe927c3b625218c0c2fee2c9ee6f53f4aa
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Introduced with b5090ddd

Change-Id: Iab60896cc27e9b9403c68aafe6fec9c4ed47b60d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Move the biggest chunk into Utils::ShellCommand, add some Qt Creator
specific magic in Core::ShellCommand and leave the rest in
VcsBase::VcsCommand.

Change-Id: I5fe6f7076e96023ad2164bcfaacfb3b65a7ff8a8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Just accept the dialog and try to generate files when no page is
displayed.

Change-Id: I0ae9aa6c29e55f52f3edad35742869a0cc535521
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

... when used with an vcsId instead of with an IVersionControl.

Change-Id: Id906db07165535d4f505c7696e29bb8b9026f840
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: Ic7066aa4ce1a8b2e584c825b5b013b9621c28010
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I5038963f13ab82a58fddbf0dd95fa173d5f07424
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

A lot of qmake expand and test functions were missing from
the ProFileCompletionAssistProvider.

This patch brings the database on par with the listing in
the qmake build in functions from current qmakebuiltins.cpp.

Change-Id: I635776f6b449d62fd6a505969451e8630fb26ee8
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

A connection was missing, so the actions weren't updated on
closing the new dialog.

Change-Id: I3ee8c4ed3d7fc4a81dcdd067897f42ac70118b77
Task-number: QTCREATORBUG-14377
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

To allow invoking it from BaseTextFind.

Task-number: QTCREATORBUG-14300
Change-Id: Id9f553d166f7b929e00238327e22d6a915957b77
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I9571b70b6eb3c6e27adf482ea24049d66244bbc7
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

C4138: '*/' found outside of comment

Change-Id: I4c68d57643cceb1a9f088c9a944d3a365e345711
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I30fbfc0bcc5e6c997190c3f1a1c279dab06fdbc0
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>