1. 19 Sep, 2017 2 commits
  2. 31 Aug, 2017 1 commit
  3. 27 Jul, 2017 1 commit
  4. 26 Jul, 2017 1 commit
    • Eike Ziller's avatar
      Locator: Fix diverse issues with drawing highlighted text · 3841d2fc
      Eike Ziller authored
      To draw the result items with highlighted parts, we split the text to
      draw into "before highlight", "highlight" and "after highlight", and
      painted them separately. This had several issues:
      
      It breaks the text layout. Characters within a text are often started at
      subpixels, which was not so visible in the static search results, but
      lead to ugly artifacts while typing in Locator (enter a search term, and
      then continue adding characters that still match the first found item,
      and watch the effect in the "after highlight" part).
      
      It needs a lot of custom painting code. Properly supporting text elide
      modes is hard, scaling to more than one highlight as well. Reusing parts
      of the QItemDelegate base functions also has its issues, e.g. that
      clipping doesn't work well.
      
      Instead, QItemDelegate::drawDisplay should make it possible to set
      format ranges for the text it draws. This patch copies part of
      QItemDelegate to be able to add this parameter. Unfortunately Qt
      currently has a bug (QTBUG-62019) that character backgrounds are not
      painted far enough (1 pixel to the right has the wrong background), which
      looks very ugly in selected items in the search results. So we use the
      new delegate only for Locator for now, to be used later for the search
      results too, when that bug is fixed.
      
      Task-number: QTCREATORBUG-18532
      Change-Id: Idf59b2c2bcfa6b188a810f7a3128a81e7e6fffb1
      Reviewed-by: default avatarAndré Hartmann <aha_1980@gmx.de>
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: David Schulz's avatarDavid Schulz <david.schulz@qt.io>
      3841d2fc
  5. 17 Jul, 2017 1 commit
  6. 10 Jul, 2017 1 commit
    • Eike Ziller's avatar
      Locator: Fix data processing from multiple filters · 6b0d9f70
      Eike Ziller authored
      The tree view uses a connection to rowsInserted internally for updating
      the view, so we may only remove our specific connection to updateSize.
      Otherwise the view stops showing items after the first rowsInserted.
      
      Task-number: QTCREATORBUG-18522
      Change-Id: Ib80fa39ee5556221a447db3556495a3608e3f62b
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      6b0d9f70
  7. 06 Jul, 2017 4 commits
  8. 03 Jul, 2017 1 commit
  9. 23 Jun, 2017 2 commits
    • Eike Ziller's avatar
      Separate locator input widget from result list & popup · e133ee89
      Eike Ziller authored
      The input field may not care whether the result list is actually in a
      popup or not.
      
      Change-Id: Ia15f9a32441243de458e4e55d2daef6204b9dd59
      Reviewed-by: David Schulz's avatarDavid Schulz <david.schulz@qt.io>
      e133ee89
    • Eike Ziller's avatar
      Locator: Reduce interdependency between item list and input field · a9eb1d39
      Eike Ziller authored
      By not getting the currently selected row at arbitrary times.
      This introduces a slight behavior change for an improbable edge case,
      which could be viewed as an improvement:
      If there are multiple filters active, and the first, higher priority one
      could finished much faster than the second, lower priority one, the
      following sequence
      
      Wait for results from first filter
      Press return
      Move up or down
      Second filter finishes/cancels
      
      without this patch did not select the item where you pressed return, but
      the item that was selected when the second filter finished.
      
      Change-Id: Iba2c72e2494824de961782ba3fe0bb1041072614
      Reviewed-by: David Schulz's avatarDavid Schulz <david.schulz@qt.io>
      a9eb1d39
  10. 19 Jun, 2017 1 commit
  11. 16 Jun, 2017 2 commits
  12. 13 Jun, 2017 1 commit
    • Eike Ziller's avatar
      Remove 1-1 dependency between locator and locator input widget · 247639d9
      Eike Ziller authored
      Add possibility for filters to set a new search text when accepting
      an entry.
      Move placeholder text update from locator manager to widget.
      Propagate filter update through signal-slot connection instead of directly.
      LocatorManager::show is the only place left that directly references the locator widget.
      
      Change-Id: Id61354d9f166c2af8c9d5528ad8998c7c6b8e1ab
      Reviewed-by: David Schulz's avatarDavid Schulz <david.schulz@qt.io>
      247639d9
  13. 02 Jun, 2017 1 commit
  14. 22 Mar, 2017 1 commit
  15. 21 Mar, 2017 1 commit
  16. 13 Mar, 2017 1 commit
  17. 01 Sep, 2016 1 commit
  18. 23 Aug, 2016 1 commit
  19. 15 Aug, 2016 1 commit
  20. 08 Aug, 2016 1 commit
  21. 05 Aug, 2016 1 commit
  22. 31 May, 2016 1 commit
  23. 30 May, 2016 1 commit
    • Shinnok's avatar
      Add Ctrl+[n,p] Locator keyboard movement shortcuts. · 14ca25f3
      Shinnok authored
      On OS X, Ctrl+n and Ctrl+p, the Emacs bindings for next and previous,
      are global throughout the system. In Qt Creator they work for menus,
      code completion widget and other places like Vimium plugin, but not
      the Locator widget. This change adds that functionality to Locator
      too and makes navigating Locator items easier.
      
      Change-Id: Iebce53d55841ba97d35ad2d433b0d9840d5e4137
      Reviewed-by: default avatarDavid Schulz <david.schulz@theqtcompany.com>
      14ca25f3
  24. 18 May, 2016 2 commits
  25. 08 Apr, 2016 1 commit
  26. 09 Mar, 2016 1 commit
  27. 10 Feb, 2016 1 commit
  28. 03 Feb, 2016 1 commit
  29. 19 Jan, 2016 2 commits
  30. 14 Jan, 2016 1 commit
    • Eike Ziller's avatar
      Locator: Avoid use of QtConcurrent · 27425b62
      Eike Ziller authored
      QtConcurrent limits resource usage to a global number of simultaneous
      threads. That means that if some QtConcurrent based algorithm currently
      grabs all threads, any other use of QtConcurrent blocks, which is not
      what we want.
      Use the new threading methods of C++11 instead, but still use
      QFuture(Interface) manually for status reporting.
      
      Task-number: QTCREATORBUG-14640
      Change-Id: I8fecb43b5235da92c0d239e7dd5f2c108ab32ebf
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarEike Ziller <eike.ziller@theqtcompany.com>
      27425b62
  31. 07 Jan, 2016 2 commits