GitLab

Task-number: QTCREATORBUG-3192

Move #include directive along with matching code.

Written-by: con

promptReadOnlyFile: EditorManager-->FileManager
fileFilters: EditorManager-->MimeDataBase
saveFile & saveFileAs --> IFile based

Reviewed-by: mae

Use the editor's displayName for the window title.
Also there were missing change signal emissions in setDisplayName
implementations.
Moves the actual handling of the window title from Session to
EditorManager (so it now is also done for the hypothetical case of no
project explorer plugin).

Task-number: QTCREATORBUG-3207

We didn't watch the symbolic link itself before, only the final link
target. We are watching the symbolic link and the final link target now.
Ugly hack: We need to work around QTBUG-15522. The inotify and kqueue
based file system watcher engines (Linux + Mac) don't report changes to
symbolic links. The workaround is to use the polling engine *only for
the links themselves*. The only way to force the use of the polling
engine is by using the auto test hook in QFileSystemWatcher.

Krazy was complaining about those.

TextEditor will now recognize an UTF-8 BOM.

A setting to determine what to do on saving has been added as well - the
options are "Always Add", "Keep Already Present" and (mostly for
completeness) "Always Delete".
Note: if encoding is "System", "Always Add" doesn't work, because there
is no API to know what the System encoding is.

Task-number: QTCREATORBUG-1857

Merge-request: 2180
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

* Editor manager should abort closing core, if there's a ICoreListener
that aborts closing of a editor.
* Don't save state of temporary editors, and don't save them as open in
  a splitter. So restoring the editor manager state won't try to reopen
  temporary editors.

Task-number: QTCREATORBUG-2845
Task-number: QTCREATORBUG-2841
Reviewed-by: Tobias Hunger

The debugger plugin opens an editor in this case, leading to fakevim and
cppeditor crashing.
This commit doesn't fix the problem's source, but adds safeguards that
are sensible anyhow: FakeVim should not register with editors during
shutdown, and CppEditor should not unconditionally assume an existing
editor manager in the destructor.

Reviewed-by: Friedemann Kleint

Task-Nr: QTCREATORBUG-2582

Moving the logic out of BaseTextDocument for use at other places.

Fix ignoring temporary files when saving a session. This could crash
when opening a session and saving it again if not all open editors
were actually shown to the user.

Do not save temporary editors in the session. Chances are high
that files opened in those editors are not around when the
session is reopened.

Task-number: QTCREATORBUG-2422

And make use of it to accept on the command line the patterns:
"filename" "+45", "filename" ":23", "filename:12" and "filename+42"

Task-Nr: QTCREATORBUG-2428

Introduce some more private classes for the coreplugin,
use header include convention
<QtModule/QClass>, de-qobjectify VariableManager.

Also introduce a indirection, modes have now types, edit and debug have
the same type, and editors do have a prefered type of modes instead of a
prefered mode.

That fixes the bug that if the prefered qml editing mode was set to
design, then in switching between qml editors would
- in Edit Mode: stay in edit mode
- in Debug Mode: switch to debug mode

There is still an open issue in this fix since the new extension might be of a different mime type (and our editors are attached to it currently).
More details documented in the code.

Task-number: QTCREATORBUG-2094
Reviewed-by: Thorbjorn Lindeijer

The function always switched to Edit Mode, which was the cause for
several bugs. Since openEditor() already does switch to the right mode,
the function is not really needed.

The following actions now respect the prefered mode of the editor:
"f file"-locator
The Open Documents list
Editor history navigation

Reviewed-by: Lasse Holmstedt <lasse.holmstedt@nokia.com>
Task-number: QTCREATORBUG-2002

Using more *::Constants::ICON_* where it makes sense and
wrapping the file names into QLatin1String where they were
missing.

The increased usage of the ICON constants needed a few more
cross plugin includes of *constants.h, here and there.
I think that it is OK, since the dependencies were alredy there
icon resource wise.

in VCSBaseEditor  and BaseTextEditor::createNew to the size
used for limiting file size.
Reviewed-by: Robert Loehning <robert.loehning@nokia.com>
Task-number: QTCREATORBUG-1847

when attempting to save a file under Perforce.

Reviewed-by: con
Task-number: QTCREATORBUG-1823

There are cases like when editing, or when jumping to a line, where we
shouldn't cut it though (so we don't).

Task-number: QTCREATORBUG-1535

A mostly mechanical change.

Reviewed-By: con

This fixes the Ctrl+W vs. Ctrl+F4 for close on MS-Windows
by introducing Ctrl+F4 as an alternative shortcut.

Reviewed-by: con

It creates too much headache with widgets calling setWindowTitle
themselves and Qt spilling out warnings about missing "[*]".

Reviewed-by: Thorbjørn Lindeijer

Task-number: QTCREATORBUG-1118

We don't call EditorManager::openEditorWithContents without a
titlepattern, but that would crash

Qt Quick Designer.

preferred mode.

Switching to preferred mode is solely done by the editor manager.

Reviewed-by: dt

Added icons for Save As, Exit, Select All, Go To Line, About
and Search & Replace actions.

Previously it was possible to end up with the wrong editor state
(the one from a duplicate editor), i.e. the cursor position
was wrong.