GitLab

The messages were computed, but not added to the document.

Change-Id: Ibeea802cf9f291ad14b2fe2e9d2a285c927a4449
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Some plugins use extra selections to provide additional editor annotations: code coverage, spelling
mistake... This was possible for C++ editor in previous version, using
CppModelManagerInterface::setExtraDiagnostics(), but this API has been removed.

This commits adds alternative API directly in the editor, allowing to pass a Core::Id instead of
the enum value.

Change-Id: I3040bd144d6fe0876d861dd28e832729bd5d6602
Reviewed-by: hjk <hjk121@nokiamail.com>

Some derived classes already had one, at times.
Make it uniformly accessible in the base class.

Change-Id: Iccb7ebf9d163daba46a01ae5de150af4a883fad6
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

It's a normal MacroExpander by now, with some extra setup code that's
used only in one place.

Change-Id: I97244b93d5c165245b02748508c7fdef1b191582
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Neither used nor needed anymore.

Change-Id: I5f55af10eb5fe8aa4109c1fe0fc9f764f51c6b4a
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

This can rely on subexpander and the global expander now.

Change-Id: I994c7f930322f45cdb57799b0d03ab822cd73bd3
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I168fb29bab905a9bfad427ab9ed6ebdf0067e28a
Reviewed-by: David Schulz <david.schulz@digia.com>

Task-number: QTCREATORBUG-13229
Change-Id: I91fd996cdbf5f3e71bdf817e9c5beebbb007681b
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

When the length of the highlight is specified, the code does not properly
check for end of line. This causes some lines to be highlighted when only
the last word was supposed to be.

For example, with this code:
   1: void foo(int x);
   2: int a = foo
   3:            ();
   4: int b = foo(
   5:             );
line 2 and 4 used to be completely highlighted (underlined), instead of
just 'foo'.

Change-Id: I40e895410ce0f38bad0adbccd509fd2943c93c97
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Broken in cabf14ba

Change-Id: I83da1254ceb4636f2b75f5ef75c9f790fd13f140
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

The re-index button was connected to the wrong help search engine.

Change-Id: I945853886a8cb0462eef71d22c48a1ac92c1eec1
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Do not add the header file to the sources group of the project.

Change-Id: I2850854e0ded1fa226c7ef5f4428d0de7ec20c75
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>

Change-Id: I1cac24387cc74ade9113b4ecbe503871e9c6150b
Reviewed-by: hjk <hjk121@nokiamail.com>

Work around compiler bug.

Change-Id: I2ed209ff7920fc54cdcd89f8beb601fc85909478
Reviewed-by: hjk <hjk121@nokiamail.com>

And do not save the default page anywhere at all.
This simplifies the logic, and makes the setting independent of help
engine initialization.

Change-Id: I264903229e274a0bf25c18b33734d36432aa525f
Task-number: QTCREATORBUG-13198
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I6492d625ede6c4425e5dd4b6f19a327f1931f64c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I49344683f2a5d80d6191e996161d70cd9fe5e2dd
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: If31df61e1e4aa7133d6384e91a362405149c2883
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

The setTextMargin call which makes room for the button, can result in
sizeHint changes of the line edit, and therefore in relayouting and
geometry changes.

The patch also moves the escape key handling to the (line)edit instead
of unconditionally the focus widget, since there is code to hide the
chooser when the focus widget is not the (line)edit anyhow.

Change-Id: I687307985ca95e63c16086b8e77c371f642ab060
Task-number: QTCREATORBUG-13221
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: I94b8d4e66982a365c5a8ae5c6a7429a1cb2d9c45
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I3043f613ba2bbafe1e6b32013be5e59cc1da412c
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I747b36b0f6a63dcf60eebd95cb1acf72e1629c1c
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Task-number: QTCREATORBUG-13217
Change-Id: I26ac5db79c0e1b6556d085648f9ebc71efae015d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I7b69ff062222c44ac11c4961c3a221917df73df2
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

The problem are tooltips not triggering, not triggering too often.

Change-Id: I707f3c5014bde310e778c6c4d604aeb4e5b8f7c3
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Issue was introduced in 5003bc60;

Change-Id: Ibe016f884e4eea8093173ced497ee4c62f1265c3
Reviewed-by: hjk <hjk121@nokiamail.com>

* Fixes multiple addition of same include.
* Takes over the check of AddIncludeForForwardDeclaration for forward
  headers.

Task-number: QTCREATORBUG-9704
Change-Id: I84629d35ae433385942a9157e5d32ef04159d07f
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: Iba365f9abeff2573296295e50a6100cc480374b4
Reviewed-by: hjk <hjk121@nokiamail.com>

 - it has the same life cycle like the Qt5NodeInstanceServer
 - we don't need to create and delete it (with maybe memory leaks)
 - this fixes a crash while the puppet is closed after an item deletion

Change-Id: Iecd6515eb41324b95e99e151d77ee74895230182
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

Change-Id: Ib44c93c6708ac651f1140c2654d89344a1b12b2c
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Task-number: QTCREATORBUG-2042
Change-Id: Ie1769cb44f60da8ef6b26d5d27f9c7a600534f6b
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

All static functions, can live closer to related code.

Change-Id: I54c5680256c78f1d09b4bee3e8843b2f4350b75a
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

This currently duplicates a few lines, but lets us address the
"better" context-specific case properly later.

Change-Id: I0e8249823d4f6d6e8f3a5f4c86b2cb0410ae3195
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Make const-correct, add convenience function for commandline parameter
expansion.

Change-Id: I12c3651e4e7b8a0a9319d1dfbea676b622b1a41a
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I4e86a2549f58c2f5ddf00b609598e426de2d3128
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: Ie034aa91b5ccc44338ce7db86259e57e9f2c95ef
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

Change-Id: I54a7122f72e3c13c239af1b4293b187cff5b1fd2
Reviewed-by: Thorben Kroeger <thorbenkroeger@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

Change-Id: Idddf0c3505875e2bb61106ced8692715619dc14b
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

For some reason the load() calls in the nested HelpViewer::setSource
calls lead to even more nesting because webkit decides to cancel loading
inbetween...... so we make the side bar viewer synchronization async on
the event loop.

Task-number: QTCREATORBUG-12742
Change-Id: I276272af7c477d627638e9611a34e80cca945b21
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I30bad85ce2fbaf1f02043b3d97f657461f5a1995
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>