GitLab

Reviewed-By: Thomas Hartmann

Reviewed-by: Thomas Hartmann
Task-number: QTCREATORBUG-4459

Reviewed-by: Marco Bubke

Reviewed-by: Thomas Hartmann

The Text element has an implicit size.

Reviewed-by: Marco Bubke

Qt::transparent != 0 !!

Reviewed-by: Marco Bubke

Reviewed-by: Marco Bubke

Reviewed-by: Marco Bubke

The Cleanlooks style is broken on the Mac atm.

Task-number: QTCREATORBUG-4296
Reviewed-by: Kai Koehne

column count for errors start with 1.

Task-number: QTCREATORBUG-4347
Reviewed-by: Thomas Hartmann

Reviewed-by: Thomas Hartmann

A defaultProperty is always a list property.


Reviewed-by: Marco Bubke

Reviewed-by: Marco Bubke

Reviewed-by: Marco Bubke

Task-number: QTCREATORBUG-4317
Reviewed-by: Thomas Hartmann

Reviewed-by: Marco Bubke

AddProperty also sets a value.
RemoveProperty and then AddProperty cannot be compressed like this.

Reviewed-by: Kai Koehne

Do not add QtQuick 1.0 import if we already have a QtQuick 1.1
import.

Reviewed-by: Kai Koehne

Something could go wrong while adding the import.
e.g.: qmldump can fail

Reviewed-by: Kai Koehne
Task-number: QTCREATORBUG-4323

The fill button should only be checked
if all 4 anchors are set and the margins are 0.

Reviewed-by: Kai Koehne

Searching through "children" is not enough since
some items have default properties like "flickableChildren".
So we mimic instanceChildren here by taking all subnodes and
comparing the instanceParent.

Reviewed-by: Kai Koehne

To handle defaultProperties correctly in the text buffer for
copy n paste we have to forward the meta system.
Since the text buffer is not a qml document in Qt Creator
with all the infrastructure attached the meta system is
incomplete.
So we forward in these cases the meta system of the actual document.

Model::create() now gets an additional paramater where we can specify another
model for proxying the meta system.

Reviewed-by: Kai Koehne

The stack trace from 4282 indicates that in fact currentState is invalid.
We should check for this.

Reviewed-by: Kai Koehne
Task-number: QTCREATORBUG-4282

The problem was that the transaction was commited outside of the try {}
catch {} block (RAII)

1. I extended to the try block arround the fxObjectNode.setVariantProperty()
to avoid similar bugs
2. I force a commit of the transaction before leaving the try block

result:
If anything is wrong with the entered expression an exception is thrown
(like before) but now is is catched and we show a messagebox.

Reviewed-by: Kai Koehne
Task-number: QTCREATORBUG-4312

Duplicate ids for not handled 100% correctly in the property editor
and in the navigator.

Reviewed-by: Kai Koehne

Since the buffer for copy and paste has no proper
representation in the project managment QmlJs::Check cannot
handle components. For now we just turn of Check for this case, since
we check the final document anyway.

Reviewed-by: Kai Koehne

Avoid recursion if item is not movable.

Reviewed-by: Kai Koehne
Task-Nr: http://bugreports.qt.nokia.com/browse/QTCREATORBUG-4284

Non existing properties are not enums.
Fixes some rewriting errors in combination with
PropertyChanges.

Reviewed-by: Kai Koehne

We have to Guard events. The Formeditor has to be fully initialized.

Task-Nr: QTCREATORBUG-4225

The combobox showing all available files did not work.

10 seconds were a little bit too long.

Since instances are asynchronius now, we cannot
rely on instance feedback (for e.g. fill).

This beautification code has to be rewritten using the model.

Reviewed-by: Kai Koehne

In the stateseditor we have to use propertiesRemoved instead of
propertiesAboutToBeRemoved when reseting the model. Otherwise
the change we want to react to has not happened, yet.
Some sanity checking in the property editor.

In the DesignDocumentController we slightly change the order.
The textMoifider is activated (again) before we set back the old
state.
Note: We do check for isValid() since the rewriter might delete the state.


Reviewed-by: Kai Koehne
Task-number: QTCREATORBUG-4199