GitLab

In case the list of source files to be parsed is empty, the
CppSourceProcessor is never deleted.

This was never a real problem because of the guard in
CppModelManager::updateSourceFiles().

Change-Id: Icfd6962d11f2b2bf2ac28825f2fa0af0838a09c8
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: Ia76a59f0c2739bec5e145edce3ca8711f54b5fa4
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: I32c22dfa32ee0345b76e8c35381bce988d20ed49
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

qbs::Group is a reference-counted value-like class, and it makes no
sense to hold it as a pointer. It makes even less sense to compare that
pointer when deciding whether a project node needs an update, as this
comparison will always be false (and technically undefined behavior as
well if the original qbs::ProjectData object no longer exists).

Change-Id: If188f83802bf6cffd04215d192667cf0200e25d3
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Yield an error if the executable file path of the project
cannot be determined.

Change-Id: I37d6123cf3cd66280a180e586aac716933f375b2
Reviewed-by: Oliver Wolff <oliver.wolff@digia.com>

Before the working directory was the working directory of Qt Creator.
If the working direcotry was the bin diredtory of Qt Creator the puppet
picked up the qt.conf from Qt Creator and could not load the platform
plugin.
Change-Id: Iab22267c578fc837b1b52bded850f0033618811c
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: Ib8fd13a3688447dcb7eeaca811f3abfefa4b5089
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

Change-Id: I981df3a89dcd7aacd19f7c5eb8c15b027bdd16e4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

We have have to check and handle sourceComponent and component (Tab).

Change-Id: I736648fc09fe4ee3333c4524666e3acea500804a
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Loader was also interpreted as a component, but the handling
of component and sourceComponent was incorrect.

Change-Id: I5cd691ece1a29c77b52dc74785013f08d589b2eb
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: Ia59098be3ca25753f03f31f964c6fb824bae677a
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: Ie8857eb180109fff3fb8e1eb14a493b38f2133a7
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: I9600439e1236c52b347c667bac6b6d79e2335375
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: Ib9af721d195291886a78fc300e24691827f56ade
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

The crash happens on Linux/Xming. 2 subsequents calls to
slotRefreshCommitData occur, m_commitDataFetcher is released when the
first one is handled, and the second call dereferences NULL.

Change-Id: Ibc06fe5dd89b790ac84544f6842cbf345d118703
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Detect also "mips" and "mips64" as mips

Change-Id: Ia2259bc4c1144834d20f6bd1c7c91f359e1a67d8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

* Avoid duplication
* Avoid unnecessary casting

Change-Id: Idb1426e4a128044091fb52450b5662ff54012f59
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Detected by CppCheck

Change-Id: I4dfafc75349a6f14e050cbf405f0b2dc9fce5cef
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: If98a66e77e47167b77e45c38682b818f41205e19
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Detected by CppCheck

Change-Id: If81c6567fa26556c3bada69ee184cd24b468e3ba
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

It doesn't need the editor parameter anymore, so the two-phase
setup can go. Note that both paths through ctor() finally hit
*Widget::createEditor() (one directly, one indirectly through
the first BaseTextEditorWidget::editor() call), so this doesn't
change what's set up, only when.

Change-Id: I65d9e317d796c8a5fe755d3d674cf79801e60617
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

It doesn't need the editor parameter anymore, so the two-phase
setup can go. Note that both paths through ctor() finally hit
*Widget::createEditor() (one directly, one indirectly through
the first BaseTextEditorWidget::editor() call), so this doesn't
change what's set up, only when.

Change-Id: If92a7e2a60ea3df417ecdeabc6f8e9dc3a23e4f8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Winrtrunner was called with the executable file path for the
top-level .pro file, which happens to be the empty string.
We now store (and use) the right .pro file path.

Change-Id: I7d71e6b99393e863f3ba0df2d2902f29d75a9583
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Task-number: QTCREATORBUG-12627
Change-Id: I7df1fe27f6502895ab9c82178084d2b631468c5d
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

There was document(), textDocument() and baseTextDocument().
Two should be enough...

Change-Id: Id9e41c8d857c5cb3269a9fce5ab594d34448c982
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Nested event loops are dangerous and in this case lead to a crash.
So change the api of ensureConfigured to not use a nested event loop.
The CustomExecutableRunConfiguration then has to manage the dialog more
explicitly. Also this makes the dialog non modal, since it should then
cope with every situation.

Task-number: QTCREATORBUG-11416
Change-Id: I2af782915c148f8dff1b0df54fdb64aa83f684d2
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

This causes unnecessary name ambiguity.

Change-Id: Id27060edb19b4902f2a93da042eb8389754b8e04
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>

The menu is expected to be populated after the signal is emitted.

Change-Id: Ibcb9eaf3742942801ad79b98000d48cb93d5ae31
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>

Lifetime is coupled to the widgets, not the editor.

Change-Id: I01560bbdd6c399376d3a4184f0eb83e4153f830e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I4385cf9ec71d85e70984fb2225b772743991e418
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Change-Id: Ic88d9a87a9eb08e597a0aa5652ac061b54d86d1e
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I77560b1a3744abad0a41f84cb386b3f688381b9b
Reviewed-by: hjk <hjk121@nokiamail.com>

This is a workaround for user mistakes and should not be generally done.
It can result in e.g. redundant relinking.

Change-Id: Ia14854c9d260f5d7a8175d105b9bce896fcdeebf
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

The qbsProjectData() member function always returned the top-level
project data, which messed up a couple of things, for instance
"build sub-projects" and the node tree updates.
Instead, return the project data corresponding to the node.

Change-Id: If40c441c62334f0069a5fe3cb4873cf973baf135
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Its lifetime is connected to the widget.

Change-Id: Iebf1a524511051f40869803426e274e8909c87e4
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I39ada562d3ef390fee0fee303fb84033c506f41e
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I2a652dd8552d3ec4622c854690c92c8d48e1c9ba
Reviewed-by: Oliver Wolff <oliver.wolff@digia.com>

Not needed otherwise

Change-Id: Ie178ae7c8a5216e351360b45d9c75c8b32dd2a54
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Some imports are known to create trouble in the designer.
There is no reason to allow adding imports using the designer, that
will just create issues.

Change-Id: I95437f39c02fd06650285a5184a77669ae32b705
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

There are conceptually only two: one that operates a new document,
and one that shares one. Being explicit makes moving data over to
the Editor hierarchy easier. Convenience can be re-added there,
later.

Change-Id: I9b34ff26628c99ffff01201dcf99332d5e7253e9
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>