GitLab

Introduces a "prepareSearch" method for locator filters that is called on
the UI thread prior to the threaded matching.
Fix various small thread-safety issues in the various filters.

Change-Id: If5ae7d205e126d367420936a93f8d9a84496edb8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

The all/current project searches use metacalls on the UI thread to work
around thread-unsafety of the Project::allFiles method, so we cannot jus
t block the UI thread to wait for the old search to cancel.
On the other hand, many of the ILocatorFilter::matchesFor implementation
s do not work when they are run in multiple threads simultaneously (most
implementations access unguarded member variables, help index filter tend
s to crash), so we _do_ have to wait for the search to cancel before sta
rting a new thread.
Broke with 05c26767 and 6fc39f0c
00c5673ae80d03d115bf3739

Change-Id: I93c607c879e8ba6ef60f94719812edb3df43a154
Task-number: QTCREATORBUG-12875
Task-number: QTCREATORBUG-12592
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: I3803fbd6d99a4b2d113997f56ab8f05e5c169937
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Change-Id: I55caca6dd5b316b2573b443175448d732101871c
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ice5f232d5d7bed32b23f6713b7fa44f44a3ea502
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This adds a "Utils" object to the Js runtime offered by the
JsExpander that adds some useful functions.

Mostly file name mangling and finding preferred extension
from the MIME type database.

Change-Id: I907dae7f295167667ac2ae81461bbff16dc98ef4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Broken in 6f7a6282e59a82e4c7609c0090da05f5da1dda91

Change-Id: I752295af28494efe3eb59ef31b111a0079d47ff7
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I61ca02b7cbdc124f756f9ca86b2ea297fd03f623
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I941179964158eb869299f068f8cd92a45f230967
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Add JsExpander that can be used to register additional functionality
in its qscriptengine and to evaluate expressions.

Register that with the VariableManager, using the "JS" prefix.

Change-Id: I7d8f1ddc3484104f3943685dbac09e786d60212e
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I7c53a91dec1e0a863f37d24787582a1ee1ba0adf
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

E.g. "Env:<some environment var>".

Remove the special handling for the "Env:" varibale that was coded
into the VaribaleManager.

Change-Id: If8b074b66eeaa97903b41634f9a3c86dd73087d4
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

it's the correct variable to use.

Change-Id: I9ec7795099097715a64969516cd3fae9e213a0f4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I6f8685319f0afe2a326a66e36a1e6b671e317614
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I0a66d7a2a77ed0b2c7c87005887a7847bb9ee5f5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ia1e43cb44639e332ee4f9100c7ce3029e9485198
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Iaa9182579afa19c9c8f184f964eeace3bc7b7906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

When the check would fail, it would result in an nullptr deref 4 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.

Change-Id: I7e504f16f3bd07e3669c02773434915bc817c8bd
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I4910c6a8de05a7ceead5b25c877ec2892be4affd
Reviewed-by: Oliver Wolff <oliver.wolff@digia.com>

Change-Id: Icb4dca2d814aebb1d55881a38294c955c515e1a4
Reviewed-by: hjk <hjk121@nokiamail.com>

Replaced the style sheet and sub-widget by plain painting code. At the
same time achieveing high-DPI support by adding the @2x variants of the
border images.

Change-Id: I09804e3349b4650c7c6cfc2341913079a51a52a7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-12974
Change-Id: I69cacab32de0454a78c5a67edcc7dcbbdcb12784
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Qt 5.3 is the minimum requirement these days. Remove all fallback code
from sources and project files.

Change-Id: If6188a471197acadda4d6baee71804ba1a8026c6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This eliminates a bunch of list->set->list conversions. Especially the
ProjectInfo::appendProjectPart takes lots of time converting for every
part added.

Change-Id: Ib3c8cd4b0ad6c012ccbeed12ebedd46b9b6cca95
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I2f90c8ae7b5e968b9de882833f8661ab540a9232
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: Iae7cbef053bfe86a7692e09f66af91117815d2a6
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Define constants for the different kinds of wizards as well as
to force override of files.

Change-Id: Ic4bf49bdb8a0b7469ddcab12d61ed8f0498c7d87
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I8e8c5ec691f7054e1c57994d3ee599a6942ddf8d
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

This is necessary since the JsonWizard will need to trigger this dialog, too.

Change-Id: Ic8eebc77282a620b13c227890b5f1861a31a2b20
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Detected by CppCheck

Change-Id: I6a5a7b5707619e3588d8a52d3fd31ffc446a5ca1
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Detected by CppCheck run.

Change-Id: I2fb506b76757d2bd0a7a1c220a9cbe1d7f63a468
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Capturing const references in lambdas is potentially dangerous.

Change-Id: I4b4ddc8dcb1e839e4ed919caccdf0010ed8e6a34
Task-number: QTCREATORBUG-12948
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: I2b2c704260c613985a4bda179658ec1f8879e70f
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

This only triggered activity if it's the currentEditor().

Change-Id: If9239901c5b30bbb0156e9f6964965cf41db7c16
Reviewed-by: hjk <hjk121@nokiamail.com>

QMenu::setAsDockMenu defined only on OsX

Change-Id: Ie9c572e450fc01662d0a1a0b2f514fa026ad4a6d
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I8b81fff7e33878282e9a4c9d9335985a5949cba2
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Replace all* remaining deprecated Qt 4 functions with
their Qt 5 counterparts. This means we no longer need to
define the QT_DISABLE_DEPRECATED_BEFORE macro.
This patch is relatively small because most source-compatible
changes of this kind have been done before.

* The one exception is the QmlDesigner, which uses QWeakPointer
in a deprecated way all over the place.

Change-Id: Id4b839c6685f3b5bdf2b89137f95231758ec53c7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

This will hopefully help a bit in resolving the crashes that happen in
QCoreApplication::notifyInternal.

Change-Id: Ib3aa8c1a1f50778bd89938d7c529d8399ccf91ea
Task-number: QTCREATORBUG-11262
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Very unusual construct...

Task-number: QTCREATORBUG-12922
Change-Id: Ia7c3a3c2520ed53fdb83d91b50a0a6737f87d4f6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Like we have now for the qmake build too.

Change-Id: I00a4cc01f35a4d93b52951c5591dadd4b6aa5e79
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>