1. 23 Sep, 2014 1 commit
  2. 22 Sep, 2014 2 commits
    • Eike Ziller's avatar
      Locator: Fix the fix of the deadlock · 10cb7abe
      Eike Ziller authored
      The all/current project searches use metacalls on the UI thread to work
      around thread-unsafety of the Project::allFiles method, so we cannot jus
      t block the UI thread to wait for the old search to cancel.
      On the other hand, many of the ILocatorFilter::matchesFor implementation
      s do not work when they are run in multiple threads simultaneously (most
      implementations access unguarded member variables, help index filter tend
      s to crash), so we _do_ have to wait for the search to cancel before sta
      rting a new thread.
      Broke with 05c26767 and 6fc39f0c
      00c5673ae80d03d115bf3739
      
      Change-Id: I93c607c879e8ba6ef60f94719812edb3df43a154
      Task-number: QTCREATORBUG-12875
      Task-number: QTCREATORBUG-12592
      Reviewed-by: default avatarChristian Kandeler <christian.kandeler@digia.com>
      10cb7abe
    • Eike Ziller's avatar
      Locator: Fix local variable name · 48c2bc1e
      Eike Ziller authored
      Change-Id: I3803fbd6d99a4b2d113997f56ab8f05e5c169937
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      48c2bc1e
  3. 29 Aug, 2014 1 commit
    • Christian Kandeler's avatar
      Do not use deprecated Qt functionality. · 1d5091e4
      Christian Kandeler authored
      Replace all* remaining deprecated Qt 4 functions with
      their Qt 5 counterparts. This means we no longer need to
      define the QT_DISABLE_DEPRECATED_BEFORE macro.
      This patch is relatively small because most source-compatible
      changes of this kind have been done before.
      
      * The one exception is the QmlDesigner, which uses QWeakPointer
      in a deprecated way all over the place.
      
      Change-Id: Id4b839c6685f3b5bdf2b89137f95231758ec53c7
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      1d5091e4
  4. 25 Aug, 2014 2 commits
    • hjk's avatar
      Use Qt 5's QStringList::join(QChar) · 6431ab2c
      hjk authored
      Less typing and less cycles than join(QString) where appropriate
      
      Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      6431ab2c
    • Eike Ziller's avatar
      Locator: Fix deadlock · 6fc39f0c
      Eike Ziller authored
      Updating the completion list is done in a separate thread, and for the
      all and current project filters that requires a slot to be synchronously
      executed on the main thread.
      Triggering the update first canceled a running update and waited for
      it to finish, before starting the next update. If the first update
      hadn't run its code on the main thread yet, it was never be able to,
      and never finished.
      
      The patch just removes the waitForFinished after the cancel. There is no
      reason to wait, since we retrieve all results only when we get the
      finished signal of a non-canceled update anyhow.
      
      Broke with 05c26767 when fixing
      QTCREATORBUG-12592
      
      Task-number: QTCREATORBUG-12875
      Change-Id: Iba9d46d469e6b2c7e894963d964c2eaca4bc4d93
      Reviewed-by: default avatarChristian Kandeler <christian.kandeler@digia.com>
      6fc39f0c
  5. 24 Jul, 2014 1 commit
  6. 16 Jul, 2014 1 commit
  7. 15 Jul, 2014 1 commit
    • Alessandro Portale's avatar
      Core: Use enable the use of magnifier@2x.png · 5f23a899
      Alessandro Portale authored
      magnifier@2x.png was already part of the core plugin, but never used
      since the @2x logic is in QIcon and for the magnifier.png we use QPixmap
      for loading.
      This patch uses Utils::StyleHelper::dpiSpecificPixmap() to load the
      image in the findtoolbar and locatorwidget. It also removes the image
      centering code in FindToolBar::updateIcons() (most likely a by now
      obsolete workaround) since the image gets properly centered in the
      Utils::FancyLineEdit.
      
      Change-Id: I5cd6d22fc5cce3838db6164568cb9165da052c49
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      5f23a899
  8. 08 Jul, 2014 1 commit
  9. 04 Jul, 2014 1 commit
  10. 02 Jul, 2014 1 commit
  11. 19 Jun, 2014 1 commit
  12. 17 Jun, 2014 1 commit
  13. 13 Jun, 2014 1 commit
  14. 03 Jun, 2014 1 commit
  15. 02 Jun, 2014 1 commit
    • Andreas Pakulat's avatar
      Fix matching of partial paths on Windows · cf6e4b8d
      Andreas Pakulat authored
      The paths against which the match is done always have forward slashes (i.e.
      uniform separator on all platforms). However the needle passed in has
      backward slashes on Windows usually, since this is how the paths are shown
      to the users and what is natural on windows too. Even explicitly using
      forward slash in the needle does not work here, since then the needle is
      not detected as containing a path (hasPathSeparator is false since it uses
      the native separator).
      
      Since it seems that the code internally favors the 'uniform' separators
      using slashes, simply convert the needle from native to uniform separators
      and use the forward slash to decide whether the needle has a path in it.
      
      Side effect of this is that it is now possible to use forward slashes when
      typing into the locator UI on windows. The opposite does not work on Unix
      though. That could be considered a feature though for cross-platform
      developers.
      
      Task-number: QTCREATORBUG-12007
      Change-Id: I5064bd9c60936466dd04671ef42a578df26ea7b8
      Reviewed-by: default avatarDavid Schulz <david.schulz@digia.com>
      cf6e4b8d
  16. 13 May, 2014 1 commit
  17. 28 Apr, 2014 1 commit
  18. 22 Apr, 2014 1 commit
  19. 14 Apr, 2014 1 commit
  20. 03 Apr, 2014 1 commit
  21. 24 Mar, 2014 1 commit
  22. 12 Mar, 2014 1 commit
  23. 07 Mar, 2014 1 commit
  24. 25 Feb, 2014 2 commits
  25. 21 Feb, 2014 1 commit
  26. 17 Feb, 2014 1 commit
  27. 14 Feb, 2014 3 commits
  28. 13 Feb, 2014 1 commit
  29. 12 Feb, 2014 1 commit
    • Orgad Shaneh's avatar
      Clean up single namespace forward-declarations · 7ed15760
      Orgad Shaneh authored
      Done using the following ruby script:
      
      Dir.glob('**/*.h').each { |file|
        if File.file?(file)
          s = File.read(file)
          t = s.gsub(/^namespace .+ \{\n\s*class .*;\n\s*\}.*$/) { |m| m.gsub(/\n\s*/, ' ').gsub(/\s*\/\/.*$/, '') }
          if t != s
            puts file
            File.open(file, 'w').write(t)
          end
        end
      }
      
      Change-Id: Iffcb966e90eb8e1a625eccd5dd0b94f000ae368e
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      7ed15760
  30. 15 Jan, 2014 1 commit
  31. 14 Jan, 2014 1 commit