Skip to content

GitLab

Switch branch/tag
  1. 25 Nov, 2014 1 commit
  3. 15 Oct, 2014 2 commits
  5. 09 Oct, 2014 1 commit
  7. 06 Oct, 2014 1 commit
  9. 30 Sep, 2014 1 commit
  11. 29 Sep, 2014 2 commits
  13. 26 Sep, 2014 2 commits
  15. 25 Sep, 2014 1 commit
  17. 19 Sep, 2014 1 commit
  19. 16 Sep, 2014 1 commit
    • Erik Verbruggen's avatar
      C++: Move preprocessor settings handling to the document. · cc6a9bab
      Erik Verbruggen authored 
      

This cleans up the handling of those settings, and makes sure that the
C++ document is setting those settings before parsing. This also
prevents lock contention in the parser, because before this patch the
document would kick of the initial parse (after opening a document),
after which the editor would come in and try to set the preprocessor
settings, resulting in the UI thread locking until the initial parse was
done.

Change-Id: Ia2e18a9667e10279f045c1c5849046ec4cfe85ae
Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      cc6a9bab
  21. 09 Sep, 2014 2 commits
    • hjk's avatar
      TextEditor: Merge some "assist" related classes · 0edefc4c
      hjk authored 
      

Simplifies the code base by removing one level of unused
and unneeded abstraction.

- Merge {I,Default}AssistInterface to AssistInterface
- Merge {IAssist,Basic}ProposalItem to AssistProposalItem
- Merge {IGenericProposal,BasicProposalItemList}Model to GenericProposalModel

Change-Id: I54ee7b095427383d67a00fc1d87c3808c21d812d
Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      0edefc4c
    • Nikolai Kosjar's avatar
      CppEditor: Fix local renaming · e9e111ff
      Nikolai Kosjar authored 
      CppLocalRenaming was connected to the initial QPlainTextEdit::document()
and not the "updated" QTextDocument set by
BaseTextEditorWidgetPrivate::setupDocumentSignals().

Broken by

    commit c655d7e5


    CppEditor: Convert to new construction scheme

Change-Id: I2e785a9d62a3bd39d9e613776cfc8e35dd9ff5d4
Reviewed-by: default avatarChristian Stenger <christian.stenger@digia.com>
      e9e111ff
  23. 08 Sep, 2014 1 commit
  25. 04 Sep, 2014 3 commits
  27. 03 Sep, 2014 3 commits
  29. 02 Sep, 2014 3 commits
  31. 29 Aug, 2014 5 commits
  33. 28 Aug, 2014 1 commit
  35. 27 Aug, 2014 2 commits
  37. 25 Aug, 2014 1 commit
    • Nikolai Kosjar's avatar
      C++: Base parsing on editor document instead of widget · 89bd4ee3
      Nikolai Kosjar authored 
      

This mainly takes CppEditorSupport apart.

* Parsing is now invoked by CPPEditorDocument itself by listening to
  QTextDocument::contentsChanged().

* Upon construction and destruction CPPEditorDocument creates and
  deletes an EditorDocumentHandle for (un)registration in the model
  manager. This handle provides everything to generate the working copy
  and to access the editor document processor.

* A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that
  controls parsing, semantic info recalculation and the semantic
  highlighting for the document. This is more or less what is left from
  CppEditorSupport and can be considered as the backend of a
  CPPEditorDocument. CPPEditorDocument itself is quite small.

    * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor
      derive from BaseEditorDocumentProcessor and implement the gaps.

    * Since the semantic info calculation was bound to the widget, it
      also calculated the local uses, which depend on the cursor
      position. This calculation got moved into the extracted class
      UseSeletionsUpdater in the cppeditor plugin, which is run once the
      cursor position changes or the semantic info document is updated.

    * Some more logic got extracted:
	- SemanticInfoUpdater (logic was in CppEditorSupport)
	- SemanticHighlighter (logic was in CppEditorSupport)

    * The *Parser and *Processor classes can be easily accessed by the
      static function get().

* CppHighlightingSupport is gone since it turned out to be useless.

* The editor dependency in CompletionAssistProviders is gone since we
  actually only need the file path now.

Change-Id: I49d3a7bd138c5ed9620123e34480772535156508
Reviewed-by: default avatarOrgad Shaneh <orgads@gmail.com>
Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      89bd4ee3
  39. 22 Aug, 2014 2 commits
  41. 21 Aug, 2014 1 commit
  43. 20 Aug, 2014 3 commits