GitLab

Formatting of disassembler view took too much time.

The breakpoints are now (fairly) tightly guarded by the BreakpointHandler.
Engines and Views are only supposed to refer to them by id. They also have
individual states now. The breakpoint data is split into a "user requested"
"fixed" part in BreakpointData and the engines' acknowledged data in a new
struct BreakpointResponse.

TODO: Move m_state and m_engine members to BreakpointResponse. Fix regressions
in the marker handling.

There's  some 'external' and some 'internal' part now. Other plugins
are only supposed the external interface.

Remove internal markers from exported headers,
introduce private class for BaseTextDocument.
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

Reviewed-by: con

Account for "0x0000000100002682sub    $0x68,%rsp", convert
hex address correctly to match the location.

Reviewed-by: hjk

Reviewed-by: con

Account for "0x0000000100002682sub    $0x68,%rsp", convert
hex address correctly to match the location.

Reviewed-by: hjk

Acked-by: hjk

Make address a quint64. Enable DisassemblerViewAgent
to match the disassembly-addresses by converting the numbers,
making it more robust. Remove the complicated formatting needed
for CDB.

Make address a quint64, linnumber and ignoreCounts int.

Reviewed-by: hjk

Also introduce a indirection, modes have now types, edit and debug have
the same type, and editors do have a prefered type of modes instead of a
prefered mode.

That fixes the bug that if the prefered qml editing mode was set to
design, then in switching between qml editors would
- in Edit Mode: stay in edit mode
- in Debug Mode: switch to debug mode

namespace (from Debugger::Internal) as they are exported classes.
Introduce private classes to avoid exposing private JS debugger
headers.

Task-number: QTCREATORBUG-1600

... on clicking stack frames or disassembler/
memory views.

Introduce flags to openEditorAt, pass
EditorManager::NoModeSwitch where applicable.

Task-number: QTCREATORBUG-2278

Also adds the "new range" ability to the debugger's memory viewer.

Remove hardcoded highlighter, give DisassemblerViewAgent
a mimetype property. Default to a generic Qt Creator
Assembler mimetype.
Acked-by: hjk
Rubber-stamped-by: Leandro T. C. Melo <leandro.melo@nokia.com>

This replaces the (de facto) singleton engines and data handlers by classes
that are instantiated per run. The DebuggerRunControl will now create an
object of (a class derived from) DebuggerEngine that contains all the relevant
"dynamic" data.

DebuggerManager is no more. The "singleton" bits are merged into DebuggerPlugin,
whereas the data bits went to DebuggerEngine.

There is no formal notion of a "current" DebuggerEngine. However, as there's
only one DebuggerEngine at a time that has its data models connected to the
view, there's still some "de facto" notion of a "current" engine. Calling
SomeModel::setData(int role, QVariant data) with custom role is used as the
primary dispatch mechanism from the views to the "current" data models
(and the engine, as all data models know their engine).

Pass output through the RunControl instead of the DebuggerManager.