1. 19 Sep, 2014 1 commit
  2. 09 Sep, 2014 1 commit
    • hjk's avatar
      TextEditor: Merge some "assist" related classes · 0edefc4c
      hjk authored
      Simplifies the code base by removing one level of unused
      and unneeded abstraction.
      
      - Merge {I,Default}AssistInterface to AssistInterface
      - Merge {IAssist,Basic}ProposalItem to AssistProposalItem
      - Merge {IGenericProposal,BasicProposalItemList}Model to GenericProposalModel
      
      Change-Id: I54ee7b095427383d67a00fc1d87c3808c21d812d
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      0edefc4c
  3. 27 Aug, 2014 1 commit
  4. 25 Aug, 2014 1 commit
    • Nikolai Kosjar's avatar
      C++: Base parsing on editor document instead of widget · 89bd4ee3
      Nikolai Kosjar authored
      This mainly takes CppEditorSupport apart.
      
      * Parsing is now invoked by CPPEditorDocument itself by listening to
        QTextDocument::contentsChanged().
      
      * Upon construction and destruction CPPEditorDocument creates and
        deletes an EditorDocumentHandle for (un)registration in the model
        manager. This handle provides everything to generate the working copy
        and to access the editor document processor.
      
      * A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that
        controls parsing, semantic info recalculation and the semantic
        highlighting for the document. This is more or less what is left from
        CppEditorSupport and can be considered as the backend of a
        CPPEditorDocument. CPPEditorDocument itself is quite small.
      
          * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor
            derive from BaseEditorDocumentProcessor and implement the gaps.
      
          * Since the semantic info calculation was bound to the widget, it
            also calculated the local uses, which depend on the cursor
            position. This calculation got moved into the extracted class
            UseSeletionsUpdater in the cppeditor plugin, which is run once the
            cursor position changes or the semantic info document is updated.
      
          * Some more logic got extracted:
      	- SemanticInfoUpdater (logic was in CppEditorSupport)
      	- SemanticHighlighter (logic was in CppEditorSupport)
      
          * The *Parser and *Processor classes can be easily accessed by the
            static function get().
      
      * CppHighlightingSupport is gone since it turned out to be useless.
      
      * The editor dependency in CompletionAssistProviders is gone since we
        actually only need the file path now.
      
      Change-Id: I49d3a7bd138c5ed9620123e34480772535156508
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      89bd4ee3
  5. 04 Aug, 2014 1 commit
  6. 31 Jul, 2014 1 commit
  7. 01 Jul, 2014 1 commit
    • Christian Kandeler's avatar
      Always pass Core::Id by value. · 93304df0
      Christian Kandeler authored
      Currently we pass in some places by value, elsewhere by const ref and
      for some weird reason also by const value in a lot of places. The latter
      is particularly annoying, as it is also used in interfaces and therefore
      forces all implementors to do the same, since leaving the "const" off is
      causing compiler warnings with MSVC.
      
      Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      93304df0
  8. 08 Jan, 2014 1 commit
  9. 18 Dec, 2013 1 commit
  10. 01 Oct, 2013 1 commit
  11. 09 Jul, 2013 1 commit
  12. 10 Apr, 2013 1 commit
  13. 08 Apr, 2013 1 commit
  14. 03 Apr, 2013 1 commit
  15. 19 Mar, 2013 1 commit
  16. 14 Feb, 2013 1 commit
  17. 29 Jan, 2013 1 commit
  18. 24 Jan, 2013 1 commit
  19. 05 Oct, 2012 1 commit
  20. 19 Jul, 2012 1 commit
  21. 19 Jun, 2012 1 commit
  22. 20 Feb, 2012 1 commit
  23. 15 Feb, 2012 1 commit
  24. 26 Jan, 2012 1 commit
  25. 10 Nov, 2011 1 commit
    • hjk's avatar
      more Id type fixes · 82f55736
      hjk authored
      Change-Id: I3720946ba5485696822976567d83b4d6cb1fb283
      
      x
      
      Change-Id: Iab58bc34bc56371405d132315573b484a533b77c
      Reviewed-by: default avatarhjk <qthjk@ovi.com>
      82f55736
  26. 03 Nov, 2011 1 commit
  27. 19 Aug, 2011 1 commit
    • Christian Kamm's avatar
      Refactoring changes: Cleanup and improvements. · 8a6d767a
      Christian Kamm authored
      Previously RefactoringFiles were usually passed around by value.
      However, since a RefactoringFile may sometimes own a QTextDocument
      (when it was read from a file), that's not great and caused the
      file to be reread after every copy.
      
      With this change RefactoringFile becomes noncopyable and is always
      owned by a shared pointer.
      
      This change also allowed having const RefactoringFiles which is
      useful because they can be safely used from other threads. See
      CppRefactoringChanges::fileNoEditor.
      
      Change-Id: I9045921d6d0f6349f9558ff2a3d8317ea172193b
      Reviewed-on: http://codereview.qt.nokia.com/3084Reviewed-by: default avatarLeandro T. C. Melo <leandro.melo@nokia.com>
      8a6d767a
  28. 16 Aug, 2011 1 commit
  29. 18 May, 2011 1 commit
    • Leandro Melo's avatar
      New code assist API · bec4f024
      Leandro Melo authored
      This is a re-work of our completion engine. Primary goals are:
      
      - Allow the computation to run in a separate thread so the GUI is not locked.
      - Support a model-based approach. QStrings are still needed (filtering, etc), but
      internal structures are free to use more efficient representations.
      - Unifiy all kinds of *assist* into a more reusable and extensible framework.
      - Remove unnecessary dependencies on the text editor so we have more generic
      and easily "plugable" components (still things to be resolved).
      bec4f024