GitLab

* Use pragma once
* Use override
* Remove Q_DECLARE_PRIVATE as that makes no sense for QtCreator

Change-Id: Ic31d4868c172a0b8fcb50cc9a71a6e95639cf84c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Alternative fix to ff8dd50f .

Change-Id: I151b45f73b19309979f1a3a1d6617e45f3205442
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

There is no need for the highlight files processor to be a Q_OBJECT, and
it can also be created on the stack (and moved to the thread).

Change-Id: Ic347b1b7e5ece50642b85654fb2701fe5994619b
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: I8975b474cf8c009e5a634464a451ef922adb02ec
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Test parser is normally disabled as long neither test tree nor results
pane is opened. The new setting allows the user to enable the parser
without the need to have one of these widgets opened.

Task-number: QTCREATORBUG-15669
Change-Id: I354e1a3cb91eeca2302f2344fd443c81c4b15406
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>

Fixes warnings:
warning: 'QStyleOptionViewItemV4' is deprecated (declared at ../../../../qt-dev/qtbase/include/QtWidgets/../../src/widgets/styles/qstyleoption.h:390) [-Wdeprecated-declarations]

Change-Id: I41683dc7f449b7e738a6e058b8c0a1e051da6c50
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I66cfcce3668d7c08d4a5f5dfe230c94f7c641759
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: Ibeb767edf29b180041267355711a69a5839f9388
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

It was only ever used to run second valgrindProcess()->setValgrindArguments
(fullValgrindArguments()) in the memcheck tool which was already done in
ValgrindRunner::start()

Change-Id: I95a6005e2131eea25215f17cd0e7244a3d8df12e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

* Use override where appropriate
* Use pragma once
* Make more constructors explicit

Change-Id: I2865fe10f288e3de570826058e43b70a0cb4ee37
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

If the process is already finished, and cancel is triggered Creator crashes.

For example, search for "q" in qt-creator, wait for >200K popup, then wait a few
seconds for the process to finish and press Cancel.

The reason for the crash is that reportFinished() is called twice - one from
GitGrepRunner::finish() and another one from Utils::runAsyncImpl().

Change-Id: I61d379f5e3a5ae86c9a48a3751dbb2e00203516d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The heavy lifting was done by clazy.

Change-Id: I2dde14919d917816d02117338205f8f861d8af0a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Id95acdeb2be21721950c6926494a5d2e5a00d8bb
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I15a985880cdd48b74524089492dc9a32f7448999
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: I62cf0ebc766c1d8543adff8d2a23a22f2bf31d18
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Change-Id: I0842544abfe55e9f168e6e19b2bd8c38cf506564
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

So that they are properly aligned in columns.

Change-Id: I71279133492fee477541e255da809662b6f1ba5a
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I4a5281f1c43fb8a86ed1a37bb59622daec7a0cd7
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: Ic139f61ad60f322e3efd4b33e123d3ac7d976c2d
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

Change-Id: Ic407ee1d29ec83ace610b852a05f1bfc7402513a
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

Change-Id: I1f4b6855cc3fc3a418e26f4900c3fd439cfa6f36
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Fixes warnings:
WARN  : ProjectExplorer::ProjectExplorerPlugin::testMsvcOutputParsers(Multiline error) QObject::connect: invalid null parameter

when running:
qtcreator -test ProjectExplorer,testMsvcOutputParsers

Change-Id: I07285b43873d76d67fcb0a67a9955d95ec1ac267
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

It is perfectly valid for a kit to not have a debugger. Do not
soft-assert in that case.

Change-Id: I89b7a125935188c0ce9479ea68cd403b59e72563
Reviewed-by: hjk <hjk@theqtcompany.com>

Not needed anymore. The combination works nevertheless.

Change-Id: I3e24be38061b78b1d107eed5b2f1ae4cc1cfc64f
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Compiles fine with the generic base classes.

Change-Id: I39b669a1c85379ca938d35d753a19debb1fd59cd
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Instead, use the copy in the RunControl base class.

Change-Id: Ib72876b131236de8cb8f5cecbad9ec381d7e0e3e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Otherwise, they cannot be run from the test system.

Change-Id: I6137548b20718b44565281edcd55f48667054878
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

The base RunControl has now a copy of its own.

Change-Id: Ic830015603975891ef96335518f39b4cf032f29f
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: If24db77c644d0b7cf0e27fd18818f0671572fabc
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Use an QTC_ASSERT in favor of an if. This may not happen.

Change-Id: I4e8d58210f9caff9b8ae7d0fccf764d8ceeace9e
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I59b401c4d7a75398fddc8f6e3a0671fc49f0cb47
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

 - also clean up some empty lines and include orders

Change-Id: Ia076951a6b0060ae70c53f213bdb5d6a12abd319
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>

Change-Id: I73db95aca8d082943f076d243db3926f560209f1
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>

Make isLocal() less intrusively used and correct.  Use the stored device
more often, also handle errors more quickly.

Change-Id: I146d1f5788ea79d0a9d7b058c81908d451cf00d0
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

The check is covered by canRun().

Change-Id: Id2360a5d2cb2fd915e164a6b5a533f008fe670f1
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: Iaf2145047fd7901472f6b5af205572cf0db2ccbc
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

This one covers the time between a QmakeProject being constructed and
has its settings read or is being parsed.

Change-Id: I64d6a9d39b1e188d2af10c58135ab9174af8d701
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

The decision is wrong anyway, no harm done. Move it closer to a
location where it can be done correctly.

Change-Id: I92de8ffec92cae6b3de3322d5045b696ae62932f
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: Ia6377114267fe0f708826b5a9ea43d7c46998a17
Task-number: QTCREATORBUG-11321
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>

This can happen.

Change-Id: Id8c077592ecc77b5d774cf60dc1faca4e5dbead5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>