- 21 Aug, 2014 1 commit
-
-
hjk authored
Change-Id: Ifb51606f71100223631d086318c230a478d70712 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 20 Aug, 2014 6 commits
-
-
hjk authored
All editors did that manually, with varying approaches. Connect once when the document is made known to the EditorWidget instead. Change-Id: Ib0828b08158539859f6f89c8080435a027aa06ed Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
Nikolai Kosjar authored
Change-Id: I3c42d9df93756d9f85682465b9661d7e75ffa71e Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I1d572e8cc3e76ef6bbae720e3c3482292aab9609 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I554b5e9e3f1ef7c167fa45b5cd0c230fdf63073b Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I447acf28849bffb52c1e6b6eafdde221ec0b179e Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
They do not really depend on CppEditorWidget and will be re-used in a follow-up change. CppEditorWidget::identifierUnderCursor() CppEditorWidget::findCanonicalMacro() Change-Id: I553bb68694fb4b5f1baa331debf33ae234e3dedf Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 19 Aug, 2014 2 commits
-
-
hjk authored
In most cases, the *Editor constructor does not need to access the *EditorWidget. Change-Id: I1f5c076a0f723d5d82b398e8c250c7bd1d47eb17 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: I45d87d0be722ac36d64af222f03f8cb76242c9df Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 18 Aug, 2014 3 commits
-
-
hjk authored
A more direct approach than going through the widget's baseTextDocument, relying on widget life time. Change-Id: I62c10e53b1a9a1e6717c6eb3e3cc78dcbfd2868e Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Change-Id: I6462403d2d06c7c6c3f79627fbba80f0ce0683ef Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
Erik Verbruggen authored
FunctionDeclDefLink::changes is called from CPPEditorWidget::updateFunctionDeclDefLinkNow() where it receives the snapshot by reference from the semantic info. The semantic info is recalculated in a/the future, so it might change the snapshot or its documents while it's still being used by the decl/def link finder. So, this patch takes a copy of all relevant semantic info (snapshot and document) before starting to calculate the changes. Change-Id: I78244a4ca8149233403b3c35ee05a2d4ed4b2770 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 04 Aug, 2014 2 commits
-
-
hjk authored
It doesn't need the editor parameter anymore, so the two-phase setup can go. Note that both paths through ctor() finally hit *Widget::createEditor() (one directly, one indirectly through the first BaseTextEditorWidget::editor() call), so this doesn't change what's set up, only when. Change-Id: I65d9e317d796c8a5fe755d3d674cf79801e60617 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
There was document(), textDocument() and baseTextDocument(). Two should be enough... Change-Id: Id9e41c8d857c5cb3269a9fce5ab594d34448c982 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
- 01 Aug, 2014 1 commit
-
-
hjk authored
Lifetime is coupled to the widgets, not the editor. Change-Id: I01560bbdd6c399376d3a4184f0eb83e4153f830e Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
- 31 Jul, 2014 4 commits
-
-
hjk authored
Goal is to consolidate "controller" related data in the *Editor hierarchy. This patch introduces temporary "cross-Private" accessors dd() to keep the patches small. First item moved is the AutoCompleter, a glimps at long term benefits is the simplification in the JavaEditorWidget which is now essentially a BaseTextEditorWidget, only containing the still-wrong createEditor(). But that can only be move if the *Editors are self-contained, i.e. keep data themselves, not indirectly through the *EditorWidgets. Change-Id: Ia0ab90f0322bb17ac20458e6581069eed30acbaf Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
In case of the CppEditor a direct member is not possible due to setup restrictions inside the CppEditor machinery. I'd expect that to be fixable when the editor base system is in good shape. Change-Id: I184e219ca2dff6f67c9b58c182212eb12972cc84 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
The base pattern is FooEditor for BaseTextEditor derived classes and FooEditorWidget for BaseTextEditorWidget derived classes. So: CPPEditorWidget -> CppEditorWidget CPPEditorWidgetPrivate -> CppEditorWidgetPrivate ...::EditorWidget -> PythonEditorWidget GLSLTextEditorWidget -> GlslEditorWidget GLSLEditorEditable -> GlslEditor Change-Id: I76d34a3694c2fb35491982d86e83f7e4774c0be6 Reviewed-by:
Daniel Teske <daniel.teske@digia.com> Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
No need for most of the machinery. Change-Id: I9078174582d83da94c6c7f20282fd3a5f1742911 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 28 Jul, 2014 1 commit
-
-
hjk authored
That was the only user of that layer of abstraction. Change-Id: I2bdc4abb8b2b33bfb70398dd11f7ecc4745ddc43 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
- 25 Jul, 2014 1 commit
-
-
hjk authored
Adjust all callers, de-export BaseTextEditorAnimator Change-Id: I2329d976c1398e2449844bb480a4d4ed29859506 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
- 13 Jun, 2014 7 commits
-
-
Nikolai Kosjar authored
Change-Id: I42c55f844c4228725251df8c985bfc275925f2ff Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
* Remove the static function since it's not really needed * Make it independent of SemanticInfo Change-Id: I8d8ea5578f5f9364a26c543277e56bdb5b947049 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: Iefaff837565f0aaf7e52263daa40a58fc391df36 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Change-Id: I3b41f91f17ce9fb24796f2f6bff353fb3c6177ec Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
Now CppEditorWidget is much less convoluted with the local rename mode. This class can be reused since there is no dependency on CPPEditorWidget. Change-Id: If513e59a03214cf9f2e3831f7e3616c001e1f036 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
* Kill duplicate code * Kill useless forwarding function * Regroup some declarations * Replace include by declaration Change-Id: I54656e4e97b1fbdf7cf2f4a87d17955128f3825e Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
...to cut some build depedencies. Change-Id: I11b7e5f3c12b6821d0825a94ad74a7e4b69c4b12 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 12 Jun, 2014 1 commit
-
-
Nikolai Kosjar authored
This one will get some more functionality. Change-Id: Ifba410e32f98c28cbfbb5a72493906ab3d681225 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 10 Jun, 2014 1 commit
-
-
Nikolai Kosjar authored
* Excess includes and forward declarations * Access protection levels * QTC_OVERRIDE * Remove declared but not implemented/used functions. * Remove unused class Change-Id: Ia19ddddccd9adde827a7875b466fde5ca4d96e7d Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 02 Jun, 2014 1 commit
-
-
Nikolai Kosjar authored
In the light of Obj-C properties this seems to annoy more than to help. Change-Id: I48f92d505035369f48e8798d0972ef00306bdde0 Reviewed-by:
Eike Ziller <eike.ziller@digia.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 23 May, 2014 4 commits
-
-
Nikolai Kosjar authored
...since it's superseded by the class Matcher. For consistency, rename FullySpecifiedType::isEqualTo() to match(). Change-Id: I07640f9218d814e0350265de45f05929e5d595a9 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
In most cases we need to work with the utf16 indices. Only in cppfindreferences the byte interface is still needed since there we read in files and work on a QByteArray to save memory. Change-Id: I6ef6a93fc1875a8c9a305c075d51a9ca034c41bb Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
* Consolidate code dealing with C++ identifiers into cpptoolsreuse.h * Handle code points that are represented with two QChars Change-Id: I4fb4435aa539f65d88598cac0b50629f33f32440 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
...especially in CppTools/CppEditor where the offsets are used with a QString/QTextDocument. Change-Id: Ic6d18fbc01fb9cc899a9bd2d7424cd2edae487f1 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 21 May, 2014 1 commit
-
-
hjk authored
Change-Id: Iee75dd4155d5074bb319df79d006b6d5e2989e14 Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
- 15 May, 2014 2 commits
-
-
Nikolai Kosjar authored
This will avoid confusion when later more length and indices methods are added. In Token: length() --> bytes() begin() --> bytesBegin() end() --> bytesEnd() Change-Id: I244c69b022e239ee762b4114559e707f93ff344f Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
Nikolai Kosjar authored
They are already inlined. Now it's easier to find read-only accesses. Change-Id: I9aaeca3bc5860e3a20a536a2484925e4334c005f Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 13 May, 2014 2 commits
-
-
hjk authored
Move item model implementation to private, adjust user code. Change-Id: Ifbe94e7c7b9b1e8be1b4c531958dbd7a9413af13 Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
Orgad Shaneh authored
Change-Id: I1f3e316336376887ec2e546fcb0cb714c777ee0b Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-