- 04 Aug, 2014 2 commits
-
-
hjk authored
It doesn't need the editor parameter anymore, so the two-phase setup can go. Note that both paths through ctor() finally hit *Widget::createEditor() (one directly, one indirectly through the first BaseTextEditorWidget::editor() call), so this doesn't change what's set up, only when. Change-Id: If92a7e2a60ea3df417ecdeabc6f8e9dc3a23e4f8 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
hjk authored
There was document(), textDocument() and baseTextDocument(). Two should be enough... Change-Id: Id9e41c8d857c5cb3269a9fce5ab594d34448c982 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
- 01 Aug, 2014 17 commits
-
-
hjk authored
Lifetime is coupled to the widgets, not the editor. Change-Id: I01560bbdd6c399376d3a4184f0eb83e4153f830e Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
Daniel Teske authored
Change-Id: Ic88d9a87a9eb08e597a0aa5652ac061b54d86d1e Reviewed-by:
hjk <hjk121@nokiamail.com>
-
Daniel Teske authored
Change-Id: I77560b1a3744abad0a41f84cb386b3f688381b9b Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Its lifetime is connected to the widget. Change-Id: Iebf1a524511051f40869803426e274e8909c87e4 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: I39ada562d3ef390fee0fee303fb84033c506f41e Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
Christian Kandeler authored
Change-Id: Ia4a9ce7df4694056bc499be773f9472ae9f0542d Reviewed-by:
Joerg Bornemann <joerg.bornemann@digia.com> Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
Daniel Teske authored
Change-Id: I2a652dd8552d3ec4622c854690c92c8d48e1c9ba Reviewed-by:
Oliver Wolff <oliver.wolff@digia.com>
-
Daniel Teske authored
Task-number: QTCREATORBUG-10906 Change-Id: I9a3143eecf663085988eaff0fc3d34bd653f9c0a Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@digia.com>
-
hjk authored
Not needed otherwise Change-Id: Ie178ae7c8a5216e351360b45d9c75c8b32dd2a54 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
There are conceptually only two: one that operates a new document, and one that shares one. Being explicit makes moving data over to the Editor hierarchy easier. Convenience can be re-added there, later. Change-Id: I9b34ff26628c99ffff01201dcf99332d5e7253e9 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
Christian Stenger authored
Change-Id: I38580087c1d8e3419698371970d0e6f9188d284d Reviewed-by:
hjk <hjk121@nokiamail.com>
-
Alessandro Portale authored
The imageViewer currently always renders the images smooth/interpolated. When loading an image in an IDE and zooming in, I usually do that in order to examine the details on pixel level. Therefore, I believe that smoothing/interpolation should be turned off with a scalefactor >= 1. This patch does that for images and movies. Svg files remain always smooth. Change-Id: I327583b1f46132d179a1e0425f146106d962377b Reviewed-by:
Daniel Teske <daniel.teske@digia.com>
-
BogDan Vatra authored
It might happen when the user changes the kit from Qt 5.4 to Qt 5.3. Change-Id: Ib9597ac0189bdc1ac4e82ac8b5de5e090f09283e Reviewed-by:
Daniel Teske <daniel.teske@digia.com>
-
Alessandro Portale authored
m_cancelRect is a QRect (not a QRectF) Change-Id: I301f5957284ffe66c94067adc64763878ef1b37f Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
Tobias Hunger authored
Change-Id: I70e4b5aa756ac216590192c8a1de593bf9ab8eab Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
Daniel Teske authored
The stylesheets sets two toolbar buttons, which were last seen in 2011. They were removed in 2fc8c10b. I checked that the it looks the same as before. Change-Id: Ifa59f626b3588e0833a046e432606eabbc9c00be Reviewed-by:
Alessandro Portale <alessandro.portale@digia.com>
-
Przemyslaw Gorszkowski authored
The parent of instantiation of nested class of template class should be the instantiation of enclosing template class. To prevent the infinite loop for case with local typedef of enclosing template we should not change a parent of typedefed instatiation of enclosing template. Example: template <typename T> struct Enclosing { typedef Enclosing<T> EnclosingT;// first case struct Nested { typedef Enclosing<T> EnclosingT;// second case }; }; Task-number: QTCREATORBUG-11752 Task-number: QTCREATORBUG-11999 Change-Id: Iadd7b5ef73ee0c4881f59c9dabfe03339f55827b Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 31 Jul, 2014 11 commits
-
-
Przemyslaw Gorszkowski authored
Fix code completion for using pointer in template specialization and initialization. Example: template <typename T> struct S {}; template <typename T> struct S<T*> { T* t; }; struct Foo { int foo; }; int main() { S<Foo*> s; s.t-> //no code completion return 0; } Task-number: QTCREATORBUG-12638 Change-Id: Idcd461806a22f08b76236f2db6346f157b12f5d3 Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
Daniel Teske authored
Change-Id: I8ff911a0d242d910dbd841a73d1eb6c7a8331f4d Reviewed-by:
hjk <hjk121@nokiamail.com>
-
Daniel Teske authored
This was implemented aeons ago. Change-Id: I4bfe5c6c5734c4267715c237810996bb0a65ad92 Reviewed-by:
Daniel Teske <daniel.teske@digia.com>
-
hjk authored
Goal is to consolidate "controller" related data in the *Editor hierarchy. This patch introduces temporary "cross-Private" accessors dd() to keep the patches small. First item moved is the AutoCompleter, a glimps at long term benefits is the simplification in the JavaEditorWidget which is now essentially a BaseTextEditorWidget, only containing the still-wrong createEditor(). But that can only be move if the *Editors are self-contained, i.e. keep data themselves, not indirectly through the *EditorWidgets. Change-Id: Ia0ab90f0322bb17ac20458e6581069eed30acbaf Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
In case of the CppEditor a direct member is not possible due to setup restrictions inside the CppEditor machinery. I'd expect that to be fixable when the editor base system is in good shape. Change-Id: I184e219ca2dff6f67c9b58c182212eb12972cc84 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: I1078174582d83da94c6c7f20282fd3a5f1742911 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
Fawzi Mohamed authored
Change-Id: Ie6f99ec2728f8584031d6b6f7d8c3c897300ea9e Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
The base pattern is FooEditor for BaseTextEditor derived classes and FooEditorWidget for BaseTextEditorWidget derived classes. So: CPPEditorWidget -> CppEditorWidget CPPEditorWidgetPrivate -> CppEditorWidgetPrivate ...::EditorWidget -> PythonEditorWidget GLSLTextEditorWidget -> GlslEditorWidget GLSLEditorEditable -> GlslEditor Change-Id: I76d34a3694c2fb35491982d86e83f7e4774c0be6 Reviewed-by:
Daniel Teske <daniel.teske@digia.com> Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
No need for most of the machinery. Change-Id: I9078174582d83da94c6c7f20282fd3a5f1742911 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
Christian Stenger authored
Change-Id: I4d3f273c157db98615c9aee0152b04dd41f3e1fa Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
Thiago Macieira authored
Qt 5.4 is adding ref-qualified overloads to toUpper, toLower, trimmed and some others, so the cast becomes ambiguous or just plain wrong. Change-Id: Idff0b3e100f075b9b995aeb84d88575afecb2d6f Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 30 Jul, 2014 10 commits
-
-
Samuel Gaist authored
Currently, if the AndroidManifest.xml file is not present in the installation folder (e.g. failed make install), the error message shown to the user just tells him that some operation failed. This patch tries to be more verbose to give the user some clues for the failure reason. Task-number: QTCREATORBUG-11503 Change-Id: I013de394c87b3adb53ec86dd97433567d7f63049 Reviewed-by:
Daniel Teske <daniel.teske@digia.com>
-
Tobias Hunger authored
I used to reimplement these a couple of times already. Change-Id: I265cf50bf976638b4ac5406ae4010cf33c20354c Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
hjk authored
Not just for selected documents. This also removes the need for the separate setupAsPlainTextDocument function. Change-Id: I51a04eebbad37a7598068ce6e157a53c1519464f Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Same patter. Plain is fully merged now, so remove the files, too. Change-Id: Id8c0ba5689ad9980a0db3580cb9833344fd911f3 Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com> Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
hjk authored
Change-Id: I1088062d0b74fd0dd69e92c55cc8bb80da61ae2d Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
Tobias Hunger <tobias.hunger@digia.com>
-
Fawzi Mohamed authored
First tests using the new qmljs testing architecture Change-Id: Id88fe53dddbb720c56cd0473e74f476862feb803 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@digia.com>
-
Fawzi Mohamed authored
Language::Enum -> QmlDialect * class instead of enum * moved Language specific operations to it (from Document) * nicer handling QStringList -> PathsAndLanguages * store language along with path, to perform a correct scan and improve path handling Change-Id: If69d35c63cfeb48aa670b51870916cd0c40f1916 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@digia.com>
-
hjk authored
Change-Id: I91a3bfb66a72e9234ca59f97d5260bbfc3ccb0d3 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Change-Id: Ib10d938fce352f59bcd40f1c6aa493794fe90f8d Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-
hjk authored
Do it in the users "that know" and remove the special constructor case. Change-Id: I9298c8d13118068adc7958c0894dccb7af4d7855 Reviewed-by:
Christian Stenger <christian.stenger@digia.com> Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com> Reviewed-by:
hjk <hjk121@nokiamail.com>
-