GitLab

Clang used to complain about this several dozen times when building
Qt Creator.

Change-Id: I4dadd40de1133fe8558d6b50730f68b40e07de55
Reviewed-by: hjk <hjk121@nokiamail.com>

The functionality it offers is not essential, and it has side-effects
that can lead to bugs if users turn it on for no particular reason.

Change-Id: Iaed660c649de46e7f81d3a1c3311693ed0820d50
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Started-by: Tobias Hunger <tobias.hunger@digia.com>
Change-Id: Id2e88efbb475221cd7c0347f7d5e7009e4372eec
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Instead call it once per .pro file and pass that to all .pri file parses
and other functions. This cuts down the number of calls for opening
qtproject.pro from ~3000 to ~700 and speeds up opening qtproject.pro
by roughly 3%.

Change-Id: Iffd46d4bbedc9c380f70e916dae7151495990b39
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I4f3075aa8ab1b3fe12eabe39740d28ff06a87f88
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Task-number: QTCREATORBUG-12846
Change-Id: I02b3d713df8cc0e28d1bd32a401f692460c5fdbd
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Task-number: QTCREATORBUG-12415
Change-Id: I6328c8b0e3579eeddae9051a9ac5c587426163fe
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

At least on Windows it fails.

Change-Id: I2e119bf47b468a9f881184ad26fa9fbd10f16124
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ia5b6fdf4303b889337442903eeb2a4efda6720ca
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Implemented pure virtual methods features, loadData with protected
access modifier

Change-Id: I75b0c0ed1f56a06a401d69f538462367de442d88
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>

Change-Id: Ibfeb6e26404468b02a5bd06a7b2ebc65ead65128
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>

the latter variable is entirely meaningless to qmake and should have
never been recognized by creator. unfortunately, qmake's dist target
wasn't very useful before qt 5.4, so it didn't occur to anybody to
actually use the variable associated with it, even though it is
semantically exactly the right thing.

Change-Id: I249857f54fdc38fb5ecac0f608e5f4140624c23c
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

these cases are automatically covered by other variables

Change-Id: Ic32411fa361346633d3127be063fcaabc9ef7c28
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I4f695a74032aa9f1e1b4d45f17ab8c4170717297
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: Ib356baed758437f5b549df060ca3ee62ee61b9fb
Reviewed-by: hjk <hjk121@nokiamail.com>

it's the correct variable to use.

Change-Id: I9ec7795099097715a64969516cd3fae9e213a0f4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

The future is now.

Change-Id: I68fa2fc75d8fe4437600a808949892e9002d950d
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

It was missing the dependency to the utils lib

Change-Id: I215dff08036b3cfb7a28cedad99932bb7dd916f1
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Change-Id: Ia1cd72b598555681e62444f6843a746049c5c04d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I5e316ada7d03c465a7f60246e2c04e1a89078689
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

It's very nice to see that at a glance, rather than searching around
in the code.

Change-Id: I1d1cdf10d98578ca1fe3275fdf2dfc98f6499eed
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Change-Id: Ia1e2cd87523d53d4a2d0de9f74980e05c565f8e0
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

It looks better, both in the code and in the result.

Change-Id: I5d24b24de429fb6a6d15c2df97f977924bb9fb00
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Like this we can properly refer to them from QML.

Change-Id: I98378d543d307f78909191225e72c9d0404dfa1d
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

They really shouldn't be called from outside. We'll introduce an
"empty" property whose notify signal will depend on data handling to be
done in a controlled way.

Change-Id: I272eaa3638ba571d9f9ffd964b0d33449d0adda1
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Change-Id: I0db3641c0d6e750459d815e25909babf8534a4f6
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Like this we can still save some time and memory if the profiled
application doesn't support filtering.

Change-Id: I534ad4a11f62d28bd2fcfbffdc44f3902758dcbe
Task-number: QTBUG-41118
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

This allows us to reduce the amount of data we need to handle
if the user isn't interested in certain categories.

Task-number: QTBUG-41118
Change-Id: Ieaac12fb1dec29d6035642f433bc1a1d49e545c2
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

So that recalculating the information is not O(n^2) but linear.

Change-Id: I69903e0b5ad321d071804d782ad634a3f300e71a
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

The current item was displayed using the hardcoded "monospace" font, so that the current/system
font and size was not used. We now use start with the same font as the error list, and simply
activate 'fixedPitch'.

Change-Id: Ifcf6f0fc044e47b3a57281f6af2d70b7f1c618e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I0e44d60aa22eeb7da9020f6028899a42f07e212f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

At the end of QmlProfilerFileReader::load() we have a perfectly valid
set of types and events which we can just pass on to the model as-is.

Change-Id: I6981663f409c4647f4d5ae8a73b5d14cc701017b
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Change-Id: I06bac5443af41a27c2641199948705c45e8a4586
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

With EngineControl multiple QQuickViews can be profiled in one
profiler if they're all running in the same thread. As the QML
engines are never run in parallel then this results in useful
data.

Change-Id: I83a34fb81fd466c5cac838b096c1b1f322ded882
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Add make std::string usable as "compact" key.

Change-Id: Idbfcf9d299e2dde392025166a20c3d0ab60239a6
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Looks like they are zombies scince
b419403b

Change-Id: I5fe0c728dcce1931e543e15f04ae24e0c65db61a
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I4b216e9e228668c7e01bc31c30334397cb07b15e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Remove the '.' as the VariableManager will append text starting with ':'
to that textFix strings.

Change-Id: I490319fac964ea8fd8078dff90ec81c9bdef8d09
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Iaf7a3d69d920f8096763e2d8033df2d6371683a7
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I6f8685319f0afe2a326a66e36a1e6b671e317614
Reviewed-by: Daniel Teske <daniel.teske@digia.com>