1. 04 Sep, 2014 2 commits
  2. 02 Sep, 2014 2 commits
  3. 29 Aug, 2014 7 commits
  4. 28 Aug, 2014 2 commits
  5. 27 Aug, 2014 3 commits
  6. 25 Aug, 2014 2 commits
    • Nikolai Kosjar's avatar
      C++: Base parsing on editor document instead of widget · 89bd4ee3
      Nikolai Kosjar authored
      This mainly takes CppEditorSupport apart.
      
      * Parsing is now invoked by CPPEditorDocument itself by listening to
        QTextDocument::contentsChanged().
      
      * Upon construction and destruction CPPEditorDocument creates and
        deletes an EditorDocumentHandle for (un)registration in the model
        manager. This handle provides everything to generate the working copy
        and to access the editor document processor.
      
      * A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that
        controls parsing, semantic info recalculation and the semantic
        highlighting for the document. This is more or less what is left from
        CppEditorSupport and can be considered as the backend of a
        CPPEditorDocument. CPPEditorDocument itself is quite small.
      
          * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor
            derive from BaseEditorDocumentProcessor and implement the gaps.
      
          * Since the semantic info calculation was bound to the widget, it
            also calculated the local uses, which depend on the cursor
            position. This calculation got moved into the extracted class
            UseSeletionsUpdater in the cppeditor plugin, which is run once the
            cursor position changes or the semantic info document is updated.
      
          * Some more logic got extracted:
      	- SemanticInfoUpdater (logic was in CppEditorSupport)
      	- SemanticHighlighter (logic was in CppEditorSupport)
      
          * The *Parser and *Processor classes can be easily accessed by the
            static function get().
      
      * CppHighlightingSupport is gone since it turned out to be useless.
      
      * The editor dependency in CompletionAssistProviders is gone since we
        actually only need the file path now.
      
      Change-Id: I49d3a7bd138c5ed9620123e34480772535156508
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      89bd4ee3
    • hjk's avatar
      Use Qt 5's QStringList::join(QChar) · 6431ab2c
      hjk authored
      Less typing and less cycles than join(QString) where appropriate
      
      Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      6431ab2c
  7. 22 Aug, 2014 1 commit
  8. 21 Aug, 2014 2 commits
    • Nikolai Kosjar's avatar
      CppTools: Remove concurrent write access to diagnostic messages · 6d70418e
      Nikolai Kosjar authored
      ...in CheckSymbols (highlighting backend). CheckSymbols might run
      concurrently several times with the same CPlusPlus::Document and modify
      the diagnostic messages in an unsave manner. See stack straces below.
      
      While the generated diagnostic messages ("Only virtual functions can be
      marked 'final'", "Too few arguments", ...) are useful, they weren't
      propagated to the editor widget since several minor versions.
      
      =================================================================
      ==23724==ERROR: AddressSanitizer: attempting double-free on 0x60c0072fcd00 in thread T528 (Thread (pooled)):
          #0 0x4787c1 in __interceptor_free (/home/nik/dev/creator/creator-ut_clang-qt5/bin/qtcreator+0x4787c1)
          #1 0x7fa15e5da4ac in QTypedArrayData<unsigned short>::deallocate(QArrayData*) /home/nik/usr/qt-5.3.1/include/QtCore/qarraydata.h:234
          #2 0x7fa15e5d87db in QString::~QString() /home/nik/usr/qt-5.3.1/include/QtCore/qstring.h:995
          #3 0x7fa15e5f4f6a in CPlusPlus::Document::DiagnosticMessage::~DiagnosticMessage() /home/nik/dev/creator/creator-ut/src/libs/cplusplus/CppDocument.h:140
          #4 0x7fa15e5f4de2 in QList<CPlusPlus::Document::DiagnosticMessage>::node_destruct(QList<CPlusPlus::Document::DiagnosticMessage>::Node*, QList<CPlusPlus::Document::DiagnosticMessage>::Node*) /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:432
          #5 0x7fa15e5f4ae9 in QList<CPlusPlus::Document::DiagnosticMessage>::dealloc(QListData::Data*) /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:784
          #6 0x7fa15e5f47ed in QList<CPlusPlus::Document::DiagnosticMessage>::~QList() /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:760
          #7 0x7fa15e7533c2 in QList<CPlusPlus::Document::DiagnosticMessage>::clear() /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:793
          #8 0x7fa15e6f2ed2 in CPlusPlus::Document::clearDiagnosticMessages() /home/nik/dev/creator/creator-ut/src/libs/cplusplus/CppDocument.h:205
          #9 0x7fa15e6c5f5b in CppTools::CheckSymbols::run() /home/nik/dev/creator/creator-ut/src/plugins/cpptools/cppchecksymbols.cpp:337
          #10 0x7fa15e6c83c2 in non-virtual thunk to CppTools::CheckSymbols::run() /home/nik/dev/creator/creator-ut/src/plugins/cpptools/cppchecksymbols.cpp:348
          #11 0x7fa17f0ccab1 (/home/nik/usr/qt-5.3.1/lib/libQt5Core.so.5+0x98ab1)
          #12 0x7fa17f0cfa5e (/home/nik/usr/qt-5.3.1/lib/libQt5Core.so.5+0x9ba5e)
          #13 0x7fa17eaeb181 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x8181)
          #14 0x7fa17dbec38c (/lib/x86_64-linux-gnu/libc.so.6+0xfb38c)
      
      0x60c0072fcd00 is located 0 bytes inside of 128-byte region [0x60c0072fcd00,0x60c0072fcd80)
      freed by thread T539 (Thread (pooled)) here:
          #0 0x4787c1 in __interceptor_free (/home/nik/dev/creator/creator-ut_clang-qt5/bin/qtcreator+0x4787c1)
          #1 0x7fa15e5da4ac in QTypedArrayData<unsigned short>::deallocate(QArrayData*) /home/nik/usr/qt-5.3.1/include/QtCore/qarraydata.h:234
          #2 0x7fa15e5d87db in QString::~QString() /home/nik/usr/qt-5.3.1/include/QtCore/qstring.h:995
          #3 0x7fa15e5f4f6a in CPlusPlus::Document::DiagnosticMessage::~DiagnosticMessage() /home/nik/dev/creator/creator-ut/src/libs/cplusplus/CppDocument.h:140
          #4 0x7fa15e5f4de2 in QList<CPlusPlus::Document::DiagnosticMessage>::node_destruct(QList<CPlusPlus::Document::DiagnosticMessage>::Node*, QList<CPlusPlus::Document::DiagnosticMessage>::Node*) /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:432
          #5 0x7fa15e5f4ae9 in QList<CPlusPlus::Document::DiagnosticMessage>::dealloc(QListData::Data*) /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:784
          #6 0x7fa15e5f47ed in QList<CPlusPlus::Document::DiagnosticMessage>::~QList() /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:760
          #7 0x7fa15e7533c2 in QList<CPlusPlus::Document::DiagnosticMessage>::clear() /home/nik/usr/qt-5.3.1/include/QtCore/qlist.h:793
          #8 0x7fa15e6f2ed2 in CPlusPlus::Document::clearDiagnosticMessages() /home/nik/dev/creator/creator-ut/src/libs/cplusplus/CppDocument.h:205
          #9 0x7fa15e6c5f5b in CppTools::CheckSymbols::run() /home/nik/dev/creator/creator-ut/src/plugins/cpptools/cppchecksymbols.cpp:337
          #10 0x7fa15e6c83c2 in non-virtual thunk to CppTools::CheckSymbols::run() /home/nik/dev/creator/creator-ut/src/plugins/cpptools/cppchecksymbols.cpp:348
      
      Change-Id: Ifab2842ea43aeb26099835966b02d8afc4b85df4
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      6d70418e
    • Erik Verbruggen's avatar
      GenericProject: put different languages into separate project parts. · 876ea282
      Erik Verbruggen authored
      This is in preparation for changes to the ProjectParts, where one part
      can only hold files for 1 language.
      
      Change-Id: I5e9a1a803ecc3ecbb36added0d0094df63922549
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      876ea282
  9. 20 Aug, 2014 7 commits
  10. 19 Aug, 2014 1 commit
  11. 18 Aug, 2014 2 commits
  12. 07 Aug, 2014 3 commits
    • Nikolai Kosjar's avatar
      CppTools: Tests: Add "Find Errors Indexing" mode · 0f3032f8
      Nikolai Kosjar authored
      Adding QTC_FIND_ERRORS_INDEXING=1 to the run environment will Creator
      force to do some "extended indexing" in order to find bugs:
      
         1) The project files are parsed as if they would be opened in an
            editor. That is, parsing happens as precisely as possible, based on
            the ProjectPart information.
      
         2) Symbols are looked up by invoking CheckSymbols, the backend of the
            semantic highlighter.
      
         3) A "Task List File" (*.tasks) will be written with all diagnostic
            messages.
      
      This special indexing mode is meant for testing purposes. E.g. it can be
      run nightly on some bigger projects to find regressions.
      
      Note that Qt Creator will quit exactly after the first time some source
      files are indexed. E.g. that will happen if you open a file manually or
      if you open a new unconfigured project. Therefore it's required to
      configure projects as needed before invoking in this indexing mode.
      
      Change-Id: If25b83e67d24df9e28e107cb062f21cbf3b4c643
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      0f3032f8
    • Nikolai Kosjar's avatar
      CppTools: Builtin-Indexer: Fix potential memory leak · 8bf4a5b0
      Nikolai Kosjar authored
      In case the list of source files to be parsed is empty, the
      CppSourceProcessor is never deleted.
      
      This was never a real problem because of the guard in
      CppModelManager::updateSourceFiles().
      
      Change-Id: Icfd6962d11f2b2bf2ac28825f2fa0af0838a09c8
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      8bf4a5b0
    • Nikolai Kosjar's avatar
      CppTools: Builtin-Indexer: Remove superfluous member · 70ca7496
      Nikolai Kosjar authored
      Change-Id: Ia76a59f0c2739bec5e145edce3ca8711f54b5fa4
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      70ca7496
  13. 04 Aug, 2014 1 commit
  14. 01 Aug, 2014 2 commits
    • hjk's avatar
      TextEditor: Remove one stack of EditorWidget constructors · f5b0bd32
      hjk authored
      There are conceptually only two: one that operates a new document,
      and one that shares one. Being explicit makes moving data over to
      the Editor hierarchy easier. Convenience can be re-added there,
      later.
      
      Change-Id: I9b34ff26628c99ffff01201dcf99332d5e7253e9
      Reviewed-by: default avatarChristian Stenger <christian.stenger@digia.com>
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      f5b0bd32
    • Przemyslaw Gorszkowski's avatar
      C++: nested class with enclosing template class · ba42ceb0
      Przemyslaw Gorszkowski authored
      The parent of instantiation of nested class of template class
      should be the instantiation of enclosing template class.
      
      To prevent the infinite loop for case with local typedef of enclosing
      template we should not change a parent of typedefed instatiation of
      enclosing template. Example:
      template <typename T>
      struct Enclosing
      {
        typedef Enclosing<T> EnclosingT;// first case
        struct Nested
        {
          typedef Enclosing<T> EnclosingT;// second case
        };
      };
      
      Task-number: QTCREATORBUG-11752
      Task-number: QTCREATORBUG-11999
      Change-Id: Iadd7b5ef73ee0c4881f59c9dabfe03339f55827b
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      ba42ceb0
  15. 31 Jul, 2014 1 commit
  16. 30 Jul, 2014 2 commits