1. 15 Dec, 2017 1 commit
    • hjk's avatar
      De-emphasize PluginManager::getObjects<Type>() · cc883023
      hjk authored
      ... by additionally keeping local (currently non-owning) pools per
      "interesting" type.
      
      Current situation:
        - The global object pool does not scale well for looking up
          objects, as iteration plus qobject_cast typically iterates
          over all pooled objects.
        - User code that can use typed results from the object
          pool need to have access to the full type definition anyway,
          i.e.  depend on the plugin of the target class anyway.
      
      The patch here solves the scaling problem is to have local
      type-specific pools to which objects register in their
      constructors and deregister in their destructors.
      
      This patch here does *not* change the ownership model of the
      pooled objects, however, it opens the possibility to change
      the ownership model per type (e.g. by not putting things into
      the global pool at all anymore and make the local pool 'owning')
      and the intent is to handle that in later patchs.
      
      Even without the follow-up patches this here is a performance
      improvement for the cases that access the local pools instead
      the global one, i.e. "practically all".
      
      Change-Id: Ib11a42df2c4ecf5e1155534730083a520dd1995b
      Reviewed-by: Eike Ziller's avatarEike Ziller <eike.ziller@qt.io>
      Reviewed-by: Christian Kandeler's avatarChristian Kandeler <christian.kandeler@qt.io>
      cc883023
  2. 16 Nov, 2017 1 commit
    • hjk's avatar
      Add some mechanism to help screenshot creation · cdaa4aee
      hjk authored
      If QTC_SCREENSHOTS_PATH points to a writable directory, each widget that
      has been registered with ICore's setupScreenShooter(const QString &name,
      QWidget *w) will dump a screen shot to this directory as soon as the
      widget is shown.
      
      Change-Id: I2dec12064f1bb3c510d2fd9d27c1b79f7b7d5f30
      Reviewed-by: Jake Petroules's avatarJake Petroules <jake.petroules@qt.io>
      cdaa4aee
  3. 24 Apr, 2017 1 commit
    • Alessandro Portale's avatar
      Reduce usage of qApp in favor of static function calls · 3624a663
      Alessandro Portale authored
      Q*Application classes have unusually many static functions. In many
      cases in our code, these functions are unnecessarily called as instance
      functions, using the qApp helper.
      
      This patch replaces many occurencies of qApp with the according
      Q*Application classname.
      
      Change-Id: I6099a419fa7bf969891269c37ed7a9e817ef5124
      Reviewed-by: default avatarhjk <hjk@qt.io>
      3624a663
  4. 16 Feb, 2017 1 commit
  5. 09 Aug, 2016 1 commit
  6. 18 Jul, 2016 1 commit
  7. 18 May, 2016 1 commit
  8. 11 Mar, 2016 2 commits
  9. 19 Jan, 2016 1 commit
  10. 14 Aug, 2015 1 commit
  11. 10 Aug, 2015 2 commits
  12. 20 May, 2015 1 commit
  13. 23 Mar, 2015 1 commit
  14. 24 Feb, 2015 1 commit
  15. 23 Feb, 2015 1 commit
  16. 16 Jan, 2015 1 commit
  17. 26 Nov, 2014 1 commit
    • Orgad Shaneh's avatar
      Core: Cosmetics · 7f341580
      Orgad Shaneh authored
      * Remove redundant namespace qualifiers
      * Qt5-ify some signal/slot connections
      * Replace some using Core::Internal with explicit namespace scopes
      
      Change-Id: Id1aae05e2c6fc2992c2716e1f8f9e985c6e56122
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      7f341580
  18. 24 Nov, 2014 1 commit
    • Daniel Teske's avatar
      SettingsDialog: Fix default button · 5449e0a7
      Daniel Teske authored
      The default button would move to the first pushbutton that got focus.
      E.g. tabbing through the android settings would move the default button
      to the first button that got focus.
      
      The cause of that is that for QPushButton::setDefault to work, the
      button needs to be a child of the QDialog. So call it after adding
      the buttongroup to the layout.
      
      Change-Id: Ife35bf15aa8585f7931a87ee715f316bb02b36be
      Reviewed-by: default avatarEike Ziller <eike.ziller@theqtcompany.com>
      5449e0a7
  19. 09 Oct, 2014 1 commit
  20. 22 Aug, 2014 1 commit
  21. 23 Jul, 2014 1 commit
  22. 30 Jun, 2014 1 commit
  23. 14 Feb, 2014 1 commit
  24. 08 Jan, 2014 1 commit
  25. 18 Dec, 2013 1 commit
  26. 10 Dec, 2013 1 commit
    • Eike Ziller's avatar
      Preferences: Add default implementation for filtering · deb43b4c
      Eike Ziller authored
      The default "matches" method now takes the widget and looks for all
      child labels, checkboxes, push buttons and group boxes.
      Because of that, the former "createWidget" method
      can be called multiple times without creating a new widget
      (-->widget()), and the "finished" method must ensure that the created
      widget gets deleted, since not all widgets that were created are added
      to the UI anymore.
      
      Change-Id: Ia231c7c78dd8819146668e6447d36d22e7836904
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      deb43b4c
  27. 27 Nov, 2013 1 commit
  28. 19 Nov, 2013 1 commit
  29. 24 Oct, 2013 1 commit
    • Eike Ziller's avatar
      Increase preference dialog height by 10% on Mac · 4161a528
      Eike Ziller authored
      Widgets and layouts take more space on Mac than on the other platforms,
      and that results in developers designing pages that are too heigh for
      Mac even though they fit on other platforms. Since redesigning
      preference pages so they also fit on Mac all the time is not ideal,
      simply account for the larger needed space.
      
      Change-Id: Ib8483713f562436bc9a86063f345ae4e44473608
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      4161a528
  30. 02 Sep, 2013 1 commit
    • Christian Kandeler's avatar
      Remove superfluous include paths from project files. · 72d17382
      Christian Kandeler authored
      A lot of our build system files specify unneeded include
      paths. These roughly fall into the following categories:
          a) Paths that are already set in more general files
             such as qtcreator.pri.
          b) Paths that serve no purpose at all, possibly
             left over from earlier versions of the project.
          c) Paths that act as workarounds for wrong include
             statements of the form '#include "xyz.h"', where
             xyz.h is not in the same directory as the including
            file.
      This patch removes such path specifications and fixes the offending
      include statements from case c).
      Tested on Linux, Windows and OSX with qmake and qbs.
      
      Change-Id: I039a8449f8a65df0d616b4c08081145c18ae4b15
      Reviewed-by: default avatarOswald Buddenhagen <oswald.buddenhagen@digia.com>
      Reviewed-by: default avatarJoerg Bornemann <joerg.bornemann@digia.com>
      72d17382
  31. 21 Jun, 2013 1 commit
  32. 27 Mar, 2013 1 commit
  33. 21 Feb, 2013 1 commit
  34. 29 Jan, 2013 1 commit
  35. 18 Jan, 2013 1 commit
  36. 17 Jan, 2013 2 commits
  37. 29 Dec, 2012 1 commit