1. 21 Jan, 2015 2 commits
  2. 09 Oct, 2014 1 commit
  3. 26 Sep, 2014 1 commit
  4. 25 Sep, 2014 1 commit
  5. 19 Sep, 2014 1 commit
  6. 09 Sep, 2014 1 commit
    • hjk's avatar
      TextEditor: Merge some "assist" related classes · 0edefc4c
      hjk authored
      Simplifies the code base by removing one level of unused
      and unneeded abstraction.
      
      - Merge {I,Default}AssistInterface to AssistInterface
      - Merge {IAssist,Basic}ProposalItem to AssistProposalItem
      - Merge {IGenericProposal,BasicProposalItemList}Model to GenericProposalModel
      
      Change-Id: I54ee7b095427383d67a00fc1d87c3808c21d812d
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      0edefc4c
  7. 04 Sep, 2014 1 commit
  8. 28 Aug, 2014 1 commit
  9. 25 Aug, 2014 1 commit
    • Nikolai Kosjar's avatar
      C++: Base parsing on editor document instead of widget · 89bd4ee3
      Nikolai Kosjar authored
      This mainly takes CppEditorSupport apart.
      
      * Parsing is now invoked by CPPEditorDocument itself by listening to
        QTextDocument::contentsChanged().
      
      * Upon construction and destruction CPPEditorDocument creates and
        deletes an EditorDocumentHandle for (un)registration in the model
        manager. This handle provides everything to generate the working copy
        and to access the editor document processor.
      
      * A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that
        controls parsing, semantic info recalculation and the semantic
        highlighting for the document. This is more or less what is left from
        CppEditorSupport and can be considered as the backend of a
        CPPEditorDocument. CPPEditorDocument itself is quite small.
      
          * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor
            derive from BaseEditorDocumentProcessor and implement the gaps.
      
          * Since the semantic info calculation was bound to the widget, it
            also calculated the local uses, which depend on the cursor
            position. This calculation got moved into the extracted class
            UseSeletionsUpdater in the cppeditor plugin, which is run once the
            cursor position changes or the semantic info document is updated.
      
          * Some more logic got extracted:
      	- SemanticInfoUpdater (logic was in CppEditorSupport)
      	- SemanticHighlighter (logic was in CppEditorSupport)
      
          * The *Parser and *Processor classes can be easily accessed by the
            static function get().
      
      * CppHighlightingSupport is gone since it turned out to be useless.
      
      * The editor dependency in CompletionAssistProviders is gone since we
        actually only need the file path now.
      
      Change-Id: I49d3a7bd138c5ed9620123e34480772535156508
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      89bd4ee3
  10. 20 Aug, 2014 1 commit
  11. 04 Jul, 2014 1 commit
  12. 02 Jun, 2014 1 commit
  13. 13 May, 2014 1 commit
  14. 14 Apr, 2014 1 commit
    • Nikolai Kosjar's avatar
      CppTools: Fix data race when accessing the editor revision · 9b2672cb
      Nikolai Kosjar authored
      Addresses the following findings of QTCREATORBUG-12030:
       * qtc.helgrind.plugintests.txt#2
       * qtc.helgrind.usingEditors1.txt#1
      
      Helgrind report (truncated):
      
      Possible data race during write of size 4 at 0x23679618 by thread #1
      Locks held: none
         at 0x6819003: ???
         by 0x681D713: ???
         by 0x68200DE: ???
         by 0x684B8F8: QTextCursor::insertText(QString const&, QTextCharFormat const&)
         by 0x684BCB9: QTextCursor::insertText(QString const&)
         by 0x139DA06C: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1866)
         by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)
      
      This conflicts with a previous read of size 4 by thread #18
      Locks held: none
         at 0x680BC54: QTextDocument::revision() const
         by 0x159047F3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
         by 0x158E39BF: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
         by 0x158E3D5B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
         by 0x1589FF6F: CppTools::Internal::CppCompletionAssistInterface::getCppSpecifics() const (cppcompletionassist.cpp:1957)
         by 0x158A1158: CppTools::Internal::CppCompletionAssistInterface::snapshot() const (cppcompletionassist.h:200)
         by 0x1589707C: CppTools::Internal::CppCompletionAssistProcessor::startCompletionInternal(QString, unsigned int, unsigned int, QString const&, int) (cppcompletionassist.cpp:1212)
         by 0x15893CC7: CppTools::Internal::CppCompletionAssistProcessor::startCompletionHelper() (cppcompletionassist.cpp:970)
      
      ---
      
      Possible data race during write of size 4 at 0x24C8AD18 by thread #1
      Locks held: none
         at 0x684AF23: QTextCursor::beginEditBlock()
         by 0x139D7D05: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1578)
         by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)
         ...
         by 0x40F15A: main (main.cpp:533)
      
      This conflicts with a previous read of size 4 by thread #11
      Locks held: none
         at 0x680BC54: QTextDocument::revision() const
         by 0x159048D3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
         by 0x158E3A9F: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
         by 0x158E3E3B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
         by 0x1590741E: parse(QFutureInterface<void>&, QSharedPointer<CppTools::SnapshotUpdater>) (cpptoolseditorsupport.cpp:299)
      
      Task-number: QTCREATORBUG-12030
      Change-Id: Idf0aa47f1f6bfd6814a961fe39d3b19b98f934f5
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      9b2672cb
  15. 12 Mar, 2014 1 commit
  16. 21 Feb, 2014 1 commit
  17. 17 Feb, 2014 1 commit
  18. 08 Jan, 2014 1 commit
  19. 15 Oct, 2013 1 commit
  20. 02 Oct, 2013 1 commit
  21. 01 Oct, 2013 2 commits
  22. 09 Sep, 2013 1 commit
    • Erik Verbruggen's avatar
      C++: clean-up CppCompletionAssist. · b4a1bd41
      Erik Verbruggen authored
      This is step 1 of 2 for merging the various provider factories into a
      single class. Merging has the advantage that selecting based on editor
      (content) mime-type only has to select one class, instead of re-doing
      the selection for each class separately.
      
      Change-Id: I11f815151bd4769ae6028b636793d6a80d02e202
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      b4a1bd41
  23. 10 Apr, 2013 1 commit
  24. 08 Apr, 2013 1 commit
  25. 03 Apr, 2013 1 commit
  26. 19 Mar, 2013 1 commit
  27. 30 Jan, 2013 1 commit
  28. 29 Jan, 2013 1 commit
  29. 15 Oct, 2012 1 commit
  30. 05 Oct, 2012 1 commit
  31. 19 Jul, 2012 1 commit
  32. 29 Jun, 2012 1 commit
  33. 23 Feb, 2012 1 commit
  34. 20 Feb, 2012 1 commit
  35. 15 Feb, 2012 1 commit
  36. 09 Feb, 2012 1 commit
  37. 26 Jan, 2012 1 commit
  38. 10 Nov, 2011 1 commit
    • hjk's avatar
      more Id type fixes · 82f55736
      hjk authored
      Change-Id: I3720946ba5485696822976567d83b4d6cb1fb283
      
      x
      
      Change-Id: Iab58bc34bc56371405d132315573b484a533b77c
      Reviewed-by: default avatarhjk <qthjk@ovi.com>
      82f55736