- 07 Dec, 2011 1 commit
-
-
Christian Kamm authored
When property declarations use a custom type such as property Foo bar we now * highlight Foo as a QML type if it's found * complete bar. as a Foo Change-Id: I82c249646af19bfeb9f5a7a7692f0dc10b009835 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- 29 Nov, 2011 2 commits
-
-
Christian Kamm authored
Could lead to crashes when two threads initialize it at the same time. Change-Id: Ia8e2c280c89087b1195451948c36a384e1098423 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
Christian Kamm authored
Change-Id: Ib81d5e6baabf5ac8d18411e8936098908de2c2bb Task-number: QTCREATORBUG-6635 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- 25 Nov, 2011 1 commit
-
-
Christian Kamm authored
* Don't build all default values (including the global object) separately for each ValueOwner instance. * Instead, keep all global, immutable values in a single, shared instance. While refactoring, some cases where we *modified* the global object had to be removed: * C++ context properties no longer get injected into the global object, instead they now have their own scope just above the global one. * The Qt object's prototype no longer gets modified in Link. Instead, it's now a reference to the "Qt" object provided in a qmltypes file. * The whole concept of a function 'Activation' that could potentially affect the global object was removed. Change-Id: Id382faf965efa747fcc7a9b0bc2c90429d84d61b Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- 16 Nov, 2011 1 commit
-
-
Christian Kamm authored
* FunctionValues know about optional arguments (for builtins) * ASTFunctionValues only report themselves as variadic if they use the 'arguments' array. * Function argument hint shows optional args and variadic. * Completion automatically adds parentheses. Change-Id: Ib2598600ff8b1ce8c5de3bcabd24a3e171ff3a57 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- 15 Nov, 2011 1 commit
-
-
Christian Kamm authored
Also: * Remove unnecessary QmlJS:: qualifications in existing documentation. * Remove unnecessary explicit links in the documentation. Change-Id: Icb41941d98b5cfe9d2fb3b3887fafee16635eb13 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- 07 Nov, 2011 1 commit
-
-
Christian Kamm authored
Task-number: QTCREATORBUG-6450 Change-Id: Idd8e2ec3550190a137dbf0fe452c8488fb3fe1ad Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 03 Nov, 2011 1 commit
-
-
hjk authored
Change-Id: If18afb5d4665924e7d9250dccbc60a65e6daa75e Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- 31 Oct, 2011 1 commit
-
-
Christian Kamm authored
The qmltypes files shipped with libraries shouldn't, but could define components that form a prototype cycle. Use of the new QmlObjectValue::prototypes() function avoids the code model getting stuck in an infinite loop for these cases. For plain ObjectValues this is already solved by using PrototypeIterator. Change-Id: I0f562672ab99b454bc3a0121c7a1b9eca43476bb Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 21 Oct, 2011 1 commit
-
-
Christian Kamm authored
Change-Id: I18ec9daf8088f7db5ff2da11da14b539f501bab3 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 18 Oct, 2011 1 commit
-
-
Christian Kamm authored
To distinguish known-to-be-undefined from a genuinely unknown value. Change-Id: I606b4ea4d726f94553400b8950d3c0a4e76564a8 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 13 Oct, 2011 1 commit
-
-
Christian Kamm authored
And introduce a good error message for the case when someone forgets the specialization of the value_cast template. Change-Id: Iec55a839e8f5eef5872b1dab8601f66e0e0c88de Reviewed-by:
Leandro T. C. Melo <leandro.melo@nokia.com>
-
- 12 Oct, 2011 4 commits
-
-
Christian Kamm authored
And switch all existing dynamic_casts to value_casts. Change-Id: I93b89358e4802080f40b332074c64f4e91a2bc4c Reviewed-on: http://codereview.qt-project.org/6311 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com> Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Reviewed-by: Fawzi Mohamed Reviewed-by: Thomas Hartmann Change-Id: Ib89388d5a5678403e4637eec5829f3520637ee27 Reviewed-on: http://codereview.qt-project.org/6310 Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com> Sanity-Review: Christian Kamm <christian.d.kamm@nokia.com>
-
Christian Kamm authored
This means the code model will now offer correct completion and highlighting for arguments of signals in their handlers, example: MouseArea { onClicked: { mou<complete> // now also completes 'mouse' } } Reviewed-by: Fawzi Mohamed Change-Id: I01838ef00e391b13e6e5a832c9ec3cd983689c5b Reviewed-on: http://codereview.qt-project.org/6147 Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com> Sanity-Review: Christian Kamm <christian.d.kamm@nokia.com>
-
Christian Kamm authored
The important error in this case is on the import. Change-Id: I3a547ca7ac44a89aba6819ea80ec52185071408a Reviewed-on: http://codereview.qt-project.org/5879 Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com> Sanity-Review: Christian Kamm <christian.d.kamm@nokia.com>
-
- 06 Oct, 2011 1 commit
-
-
Christian Kamm authored
It's new in Qt 5. Change-Id: If3e670d42528ca6996ae280d96077ce744d281d9 Reviewed-on: http://codereview.qt-project.org/6121 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- 28 Sep, 2011 1 commit
-
-
Christian Kamm authored
* Allow .import... * Fix parsing of JS files when using Lexer::scanDirectives() * Clean up ImportInfo construction. * Rename ImportInfo::id to ImportInfo::as. Change-Id: I888da248f06dc6184db99aa74c3b50d7f2f5e491 Reviewed-on: http://codereview.qt-project.org/5625 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- 27 Sep, 2011 2 commits
-
-
Christian Kamm authored
Change-Id: Ieacc7896eaeb478c6bd79a0865280f0cb595101e Reviewed-on: http://codereview.qt-project.org/5619 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Still need to get rid of the lock in ValueOwner::registerValue. Change-Id: If9bbc548de54edf52805906aaaf730f5c66573dd Reviewed-on: http://codereview.qt-project.org/5542 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 26 Sep, 2011 1 commit
-
-
Christian Kamm authored
They need not to be identical. Additionally: * Rename ImportInfo::name to path, because that's what it does. * Add ImportInfo::name, for getting the uri with the names separated by dots. * Allow for exportMetaObjectRevisions in qmltypes files. * Allow for exports with an empty type name, as generated by qmlRegisterRevision. They are used for associating meta object revisions with non-exported types. * Rewrite the Qt 4.7 import to QtQuick 1.0 at an early stage. In preparation for the Qt 5 type information update, where Qt 4.7 is gone. Change-Id: Ia287193623d9530a56b9eb8d2481d50aabd94c3e Reviewed-on: http://codereview.qt-project.org/5309 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 19 Sep, 2011 3 commits
-
-
Christian Kamm authored
Change-Id: Ifc229c23c14a6395c9d3e5f7ec76b9b04678787d Reviewed-on: http://codereview.qt-project.org/5134 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
Christian Kamm authored
The problem was that if you exported A 1.0, A 1.1 and B 1.0 where A is the prototype of B the code model had not enough information to know that, depending on the import, B 1.0's prototype should be A 1.1 or A 1.0. To solve this problem QmlObjectValues now store the import's version as well as the local component version. In the example above B 1.0 would have import version 1.1 if the 1.1 module was imported and thus be able to choose the right prototype. Change-Id: I7ef33f12ca5a528c62b2a8240f4b5720b0ebd4c3 Reviewed-on: http://codereview.qt-project.org/5129 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
Christian Kamm authored
Tests indicate that lookup in QHash<QString, ...> is more performant even for short strings. Change-Id: I8e5a73d0f1a72e202522f397b16901887f9c3591 Reviewed-on: http://codereview.qt-project.org/5070 Reviewed-by:
Leandro T. C. Melo <leandro.melo@nokia.com>
-
- 15 Sep, 2011 1 commit
-
-
Christian Kamm authored
Change-Id: I9a74bd726d9691ca93477916159a80c04c35f52d Reviewed-on: http://codereview.qt-project.org/4987 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
- 14 Sep, 2011 3 commits
-
-
Christian Kamm authored
* Change from Reference to FunctionValue: There was no reason for them being References as the argument types never need lookup. * Enumerate in global completion: When you define 'signal foo(int a)' you now get completion for 'foo' and will get the function argument hint popup. Change-Id: Ic348db477a34ba468dfdb690499a9cd8fd605cd2 Reviewed-on: http://codereview.qt-project.org/4774 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
Christian Kamm authored
Change-Id: I153723eeb9973be025daf47e317f7b9d076a3c72 Reviewed-on: http://codereview.qt-project.org/4733 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
Christian Kamm authored
Task-number: QTCREATORBUG-6094 Change-Id: Icf286bc412b48dbd1cb38c47ad7b91040b5aae0f Reviewed-on: http://codereview.qt-project.org/4864 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
- 12 Sep, 2011 1 commit
-
-
Christian Kamm authored
Since several reference lookups involve Evaluate which may cause further reference lookups, we need to be able to pass the existing ReferenceContext to avoid cycles. Change-Id: I2f1eeaad4d6b6ff094413d51077b03c985f6fab4 Reviewed-on: http://codereview.qt-project.org/4653 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 05 Sep, 2011 1 commit
-
-
Christian Kamm authored
* Also look for enums in prototypes. * Report back which QmlObjectValue had the enum. * Fix a bug where enum lookup was always skipped. Change-Id: I9c9fd8f8cf9bd8cc5f1bb5688fef5786267cd794 Reviewed-on: http://codereview.qt.nokia.com/4192 Reviewed-by:
Thomas Hartmann <Thomas.Hartmann@nokia.com>
-
- 09 Aug, 2011 1 commit
-
-
Christian Kamm authored
Change-Id: I30773e8879086c1f85d331fabf9380e217b32dd7 Reviewed-on: http://codereview.qt.nokia.com/2745 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 08 Aug, 2011 3 commits
-
-
Christian Kamm authored
The distinction between QmlJS and QmlJS::Interpreter has always been weak and the extra namespace just added an unnecessary complication. Change-Id: I4db8ef4bd91b5f6bf610a9d23fdbf55bd60250fc Reviewed-on: http://codereview.qt.nokia.com/2743 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Previously Context was not entirely thread safe and had to be copied locally. Now it is thread safe and its lifetime managed by QSharedPointer. The non-safe parts were moved into ScopeChain in a previous commit. Change-Id: I851a93de85cbd6391dbea0fe33b011e2e093addb Reviewed-on: http://codereview.qt.nokia.com/1695 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Context is created by Link and has information about imports for all Documents in a Snapshot. ScopeChain represents how lookup is done at a specific place in a Document. Change-Id: I874102d57bbaf1a497fa3f27633bed6ee75dcf10 Reviewed-on: http://codereview.qt.nokia.com/1694 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 15 Jul, 2011 1 commit
-
-
Christian Kamm authored
0c0ffab1 accidentally always returned null if the type was not an enum. Change-Id: Ie16d96e59cefa50c345cddb4a053fd8b60ba3cd6 Reviewed-on: http://codereview.qt.nokia.com/1693 Reviewed-by:
Leandro T. C. Melo <leandro.melo@nokia.com>
-
- 13 Jul, 2011 1 commit
-
-
Fawzi Mohamed authored
Change-Id: I61f39f5bafcb2c84e91f5bca4b52010a08ed9f37 Reviewed-on: http://codereview.qt.nokia.com/1592 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com>
-
- 11 Jul, 2011 1 commit
-
-
Christian Kamm authored
Change-Id: I7b5179c4b33c24e83baf0536d158dd48d277637f Reviewed-on: http://codereview.qt.nokia.com/1305 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
- 05 Jul, 2011 3 commits
-
-
Christian Kamm authored
Change-Id: I62bb8f41177521db1f3213d6bd804d8e4852560d Reviewed-on: http://codereview.qt.nokia.com/1044 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Change-Id: I30c1636f4946f465e5924493e561310f506df3d7 Reviewed-on: http://codereview.qt.nokia.com/1043 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-
Christian Kamm authored
Change-Id: I91331b7039e27e2f57cc19b985c8ed86c955ec9e Reviewed-on: http://codereview.qt.nokia.com/1042 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-