GitLab

Hitting the remove button to delete buildconfigurations
resulted in the wrong buildconfiguration getting removed.

Reviewed-by: dt

Distinguish between pages that are target specific and project specific.
Do the magic hierarchy reduction if only one target is supported just in
the projectwindow. Treat the targets page specially.

Reviewed-By: hunger

That is e.g. buildSteps() and cleanSteps() --> steps(type)

This is now possible due to the async evaluation

 * Ease cross device development by introducing 'targets' which
   group build- and runsettings that are valid for this one target

 Most of the kudos for the code review go to dt. Con, thorbjorn,
 ckandler and others did also review parts of this patch.

Reviewed-by: dt

Show the state in the combo boxes instead.

 * Make use of the ProjectConfiguration base class in the
   BuildConfigurations and update the factories accordingly.

Reviewed-by: dt

On the project page

  * Use id() for methods returning a string used to represent
    some type of object.
  * Use displayName() for strings that are meant to be user
    visible.
  * Quieten some warnings while touching the files anyway.
  * Move Factories to their products in the plugins where that
    was not done before.

Reviewed-by: dt

 * Init is really setting up the UI, so rename it to setupUi.

Reviewed-by: dt

  * It was missing its margin.

Reviewed-by: Roberto Raggi

 * Merge BuildSettingsWidget and BuildSettingsSubWidgets. I don't
   see much need for this separation and it makes the indention harder
   to do.
 * Override contentsmargins set by the ProjectsWindow.
   This enables the toolwidget to be displayed properly.
 * Add a remove button to the toolwidget of the buildsteps. Remove the
   global one.
 * Simplify code a bit by using QSignalMapper instead of mapping signals
   manually.

Reviewed-by: dt

Fix for that will come later

The pointers can be used to distinguish BuildConfigurations

Each project has it's own BuildConfiguarion * classes, they'll get a
decent type safe interface and the setValue/value stuff will be removed.

 * Rename it to IPropertiesPanel in accordance with new naming standards.
 * Do not derive from Context. That is not needed.
 * Add an icon() method.
 * Fix all usages of this interface.

Reviewed-By: dt

 * Panel struct does no longer take ownership of its widget.
 * Panels consitently delete their widget in their destructor.

Reviewed-By: dt

It's easier this way for the unique naming.

Default creation type implementation are still missing for cmake and
generic projects.

Instead use the BuildConfiguration class methods directly.

Builds, but I'm pretty sure it doesn't *work* :)

Feedback welcome, some of them are not necessarily better. Some things
aren't solved.