GitLab

In addition to causing an unhelpful error message, we would also create
directories at unwanted places. For instance, deploying to a directory
called "/tmp/test dir" would result in this:
    mkdir -p /tmp/test dir
Which created two unwanted directories, one of them at a completely
unrelated place.

Task-number: QTCREATORBUG-14518
Change-Id: Ie1c287ca73d0815b9bed335141adb901e361e3e6
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Karsten Sperling Opdal
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: I38a0c5cef0f22e1b7eda218c3992fcecfe728455
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>

We may not use native path separators for internal data.

Task-number: QTCREATORBUG-14249
Change-Id: I0f00db235608e81cfefdd2359378020c7376768f
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Without it, Qt creator complains that the XML file is invalid and
it could not be parsed. Made a language edit as well based on the
sanity bot's recommendation.

Change-Id: I04acd60d9ee4f5f29f443fa56beed6ecfbdbef64
Task-number: QTBUG-41996
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>

The height of a model is 0 if the model is empty. Thus, when clearing
we have to emit heightChanged().

Change-Id: I6f05c2a32cff648d6aa8e623e17aebe9ae4fcb5c
Task-number: QTCREATORBUG-14507
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Introduced with 66f60362

Change-Id: Ifd114e7360bd5ee729d29a0f03116458d56c2afa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I707f348965cb66085e9e9b7b47613c65974a5f55
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>

The space character after the line number was removed from
the compiler messages.

Change-Id: Ia249a6d4416744c67aada2eb2c5c26cf87bd7ef7
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: I6e8b3cbedb78df08066f87d4aa9922145cfa151c
Task-number: QTCREATORBUG-14496
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

The format of the compiler warnings changed:
c:\foo.cpp(395) : warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning)
c:\foo.cpp(395): warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning)

Change-Id: Iaa04d8fedbb0a3da2802be1c860d54fefb7bfe5d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

To HEAD of 1.4 branch.

Task-number: QTCREATORBUG-14482
Change-Id: I97b870fe11fca3553015e79b5229096aa5d8cf2b
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: Ibb70d98a6b2ceeb72059a7a421ce2e1a38233d87
Task-number: QTCREATORBUG-14491
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

The code path can be triggered legitimately by removing breakpoints
without direct file association like "Break on throw" in the
breakpoint view.

Change-Id: If32a990f76d86386e40123c8f7a90613e15ca670
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: If15afbbc7bcf33367755cfd61d47670a28038e6f
Reviewed-by: hjk <hjk@theqtcompany.com>

DockWidget keeps a pointer to the initial inner widget which might change/delete.

Ex:
    QWidget *w = new QWidget;
    w->setWindowTitle("title");
    QDockWidget *dock = addDockForWidget(w);
//...
    dock->setWidget(0); // we want to set another widget
    delete w;

Change-Id: I04e3d1075787092f3789f32442990aa76848d1b7
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Change-Id: I56133c7459be50efe5eda7382de7a211a62ba34c
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

Change-Id: I21ff7f3f70116944ba08ea18bdeeb258c0984f09
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I18e2cb163f2aef81ca34994a38ceb4865b2ae5ad
Task-number: QTCREATORBUG-14307
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I5c85dda01a442e4b227c846d6fa5057e1fe82939
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: Id98acf623a7d5aa55c98f4c3db6e0a5447f59b7d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Apparently the chosen event type influences the stability of the
recording process and you can change the event type using the
additional arguments.

Change-Id: I0e1982d4d469e1e4d17e2aa01d3c5166ce8817a3
Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>

This fixes broken library paths for buildoutputparser and qbs
executables on OS X, making them unusable out of the box.

Task-number: QTCREATORBUG-14432
Change-Id: I81c64f962b0a1eee2800da04b5202f5fd9efb706
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

They were expanded but collapsed again when the model was reset in the
setShowReplaceUI(bool show) call. Avoid resetting the model by informing
about the data change individually.

Change-Id: I48a94f2aec5b5d31d11166a299a2463b757939fa
Task-number: QTCREATORBUG-14320
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: Iedc533079f0eaa7f0dd2cc241b012c3e07d935b0
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: If55a35fcd0960bd7ac215493ccc7e4118a8c3187
Task-number: QTCREATORBUG-14459
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

... when double-clicking on an entry for which debug information
but no corresponding sources were found.

Change-Id: I48f57794e072752d444d7c3ccd8bfe517c9db1dd
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Let the user decide whether to select items on mouse over by pressing
the respective toggle button. The current magic is hard to grasp and
mostly just annoying.

Change-Id: Ied6bb36bd675bdc7ad237f841ecd345ad6c97e7a
Task-number: QTCREATORBUG-14415
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>

Events with duration == 0 were erroneously filtered out by the items
render pass. Also, we have to give them a very small width in order for
the "stretching" mechanism in the vertex shader to work.

Change-Id: Icb76168f0831547a3ca55ab79df7161736ed4dc4
Task-number: QTCREATORBUG-14446
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

It is necessarye because fredesktop's version searches for /* and // magic
which is found in other files (e.g. .qml, .js, etc.)

Change-Id: I9cd3341167e5a0aa57d6046f4492bab241055c4b
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Icba0aa76b9db40c46c026177637c5ea92593c4c0
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

...with the environment variable QTC_CPP_FILE_SIZE_LIMIT_MB.

Task-number: QTCREATORBUG-14390
Change-Id: Iaefaa1a3db023b58f9351b96e1b9e2139797e280
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

Change-Id: Ibefa62dd30cc35d4eb1997484e28d91f1ab0288f
Task-number: QTCREATORBUG-14390
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

...to prevent out of memory crash for generated tables.

Change-Id: I8f9f51829fcce5bccfe0dba8852023f8dd7d6e37
Task-number: QTCREATORBUG-14390
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

This was forgotten in e488f10c.

Change-Id: I2fec272c9f1e44b3a691b782dcf6bee2a1768371
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Ic43e8d255ee36aa579c8a76da22e156346713dfa
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>

Visual Studio before 2013 had bugs in bool conversion of std::function,
leading to "true" in some cases where it shouldn't.

Task-number: QTCREATORBUG-14399
Change-Id: I8a1ad2f952247049355e11337ddf99f380ebde98
Reviewed-by: Oliver Wolff <oliver.wolff@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

To HEAD of 1.4 branch.

Change-Id: Iaf125c6222efea1957dc5a68cbc100100e33095e
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Linux test machines count 1673 files instead of 1675.
If this is a bug at all, I don't expect it to be in Creator.

Change-Id: I8202aae88ceda6b8bf472d8b9a7506862ad2473c
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

For example when developing on Windows, cross compiling to Linux, the
result is not executable from the Windows perspective.
Reverts f2cfd3c0 which changed the code
to use ExistingCommand to get the automatic expansion of app bundles on
OS X, and do automatic expansion of app bundles also when using path
chooser of type File. Choosing an app bundle in a path chooser of type
File would previously lead to an invalid entry in the path chooser
anyhow, because the app bundle itself is not a file.

Change-Id: Ie710c47918d2b8735009e290301ed2683e354f2c
Task-number: QTCREATORBUG-14412
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The window was cleared even if the option to clear it wasn't
selected. Moving the cursor to the end, has the side effect of
clearing the selection, so do that always.

Change-Id: I6b61981f46394c61e61066aa8033c7e3391e6c07
Task-number: QTCREATORBUG-14410
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>