1. 16 Sep, 2015 1 commit
  2. 02 Sep, 2015 1 commit
    • Nikolai Kosjar's avatar
      C++: Fix crash after triggering completion and closing editor · 169556db
      Nikolai Kosjar authored
      Fix use-after-free for the following case:
        1. Open an editor
        2. Trigger a long processing completion
           (e.g. simulate with QThread::msleep in
            CppCompletionAssistInterface::getCppSpecifics)
        3. ...and immediately close the editor (e.g. with Ctrl+W)
        4. Wait until it crashes.
      
      The completion thread relied on the BuiltinEditorDocumentParser object,
      which is deleted once the editor is closed. Fixed by sharing the
      ownership of that object between the *EditorDocumentProcessor and the
      completion assist interface.
      
      This case came up when doing tests for the bug report below.
      
      Task-number: QTCREATORBUG-14991
      Change-Id: I0b009229e68fc6b7838740858cdc41a32403fe6f
      Reviewed-by: default avatarDavid Schulz <david.schulz@theqtcompany.com>
      169556db
  3. 10 Jul, 2015 1 commit
  4. 10 Jun, 2015 1 commit
    • Nikolai Kosjar's avatar
      Clang: Use completion through backend process · 23b8a3b2
      Nikolai Kosjar authored
      This makes us independent of libclang crashes for completion.
      Re-parsing for highlighting still happens in the Qt Creator process.
      
      Run in verbose mode:
          qtc.clangcodemodel.ipc=true
      
      Run tests:
          -test "ClangCodeModel"
      
      Task-number: QTCREATORBUG-14108
      Task-number: QTCREATORBUG-12819
      Change-Id: Id3e95bd2afdb6508bbd1d35fddc69534a909b905
      Reviewed-by: default avatarMarco Bubke <marco.bubke@theqtcompany.com>
      23b8a3b2
  5. 04 Jun, 2015 1 commit
  6. 19 May, 2015 1 commit
  7. 24 Apr, 2015 2 commits
  8. 20 Apr, 2015 1 commit
  9. 13 Apr, 2015 1 commit
  10. 20 Mar, 2015 1 commit
  11. 05 Mar, 2015 1 commit
  12. 27 Feb, 2015 2 commits
  13. 25 Feb, 2015 2 commits
  14. 20 Feb, 2015 1 commit
  15. 17 Feb, 2015 2 commits
  16. 04 Feb, 2015 1 commit
    • Orgad Shaneh's avatar
      C++: Remove unneeded qualifications · 65e7db42
      Orgad Shaneh authored
      Mostly done using the following ruby script:
      Dir.glob('**/*.cpp').each { |file|
        next if file =~ %r{src/shared/qbs|/qmljs/}
        s = File.read(file)
        s.scan(/^using namespace (.*);$/) {
          ns = $1
          t = s.gsub(/^(.*)\b#{ns}::((?!Const)[A-Z])/) { |m|
            before = $1
            char = $2
            if before =~ /"|\/\/|\\|using|SIGNAL|SLOT|Q_/
              m
            else
              before + char
            end
          }
          if t != s
            puts file
            File.open(file, 'w').write(t)
          end
        }
      }
      
      Change-Id: I6fbe13ddc1485efe95c3156097bf41d90c0febac
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@theqtcompany.com>
      65e7db42
  17. 21 Jan, 2015 2 commits
  18. 16 Jan, 2015 1 commit
  19. 14 Jan, 2015 1 commit
  20. 03 Dec, 2014 1 commit
  21. 06 Nov, 2014 1 commit
  22. 13 Oct, 2014 1 commit
  23. 09 Oct, 2014 1 commit
  24. 29 Sep, 2014 1 commit
  25. 25 Sep, 2014 1 commit
  26. 19 Sep, 2014 1 commit
  27. 09 Sep, 2014 1 commit
    • hjk's avatar
      TextEditor: Merge some "assist" related classes · 0edefc4c
      hjk authored
      Simplifies the code base by removing one level of unused
      and unneeded abstraction.
      
      - Merge {I,Default}AssistInterface to AssistInterface
      - Merge {IAssist,Basic}ProposalItem to AssistProposalItem
      - Merge {IGenericProposal,BasicProposalItemList}Model to GenericProposalModel
      
      Change-Id: I54ee7b095427383d67a00fc1d87c3808c21d812d
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      0edefc4c
  28. 08 Sep, 2014 1 commit
  29. 04 Sep, 2014 1 commit
  30. 29 Aug, 2014 1 commit
    • Christian Kandeler's avatar
      Do not use deprecated Qt functionality. · 1d5091e4
      Christian Kandeler authored
      Replace all* remaining deprecated Qt 4 functions with
      their Qt 5 counterparts. This means we no longer need to
      define the QT_DISABLE_DEPRECATED_BEFORE macro.
      This patch is relatively small because most source-compatible
      changes of this kind have been done before.
      
      * The one exception is the QmlDesigner, which uses QWeakPointer
      in a deprecated way all over the place.
      
      Change-Id: Id4b839c6685f3b5bdf2b89137f95231758ec53c7
      Reviewed-by: default avatarEike Ziller <eike.ziller@digia.com>
      Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
      1d5091e4
  31. 27 Aug, 2014 1 commit
  32. 25 Aug, 2014 1 commit
    • Nikolai Kosjar's avatar
      C++: Base parsing on editor document instead of widget · 89bd4ee3
      Nikolai Kosjar authored
      This mainly takes CppEditorSupport apart.
      
      * Parsing is now invoked by CPPEditorDocument itself by listening to
        QTextDocument::contentsChanged().
      
      * Upon construction and destruction CPPEditorDocument creates and
        deletes an EditorDocumentHandle for (un)registration in the model
        manager. This handle provides everything to generate the working copy
        and to access the editor document processor.
      
      * A CPPEditorDocument owns a BaseEditorDocumentProcessor instance that
        controls parsing, semantic info recalculation and the semantic
        highlighting for the document. This is more or less what is left from
        CppEditorSupport and can be considered as the backend of a
        CPPEditorDocument. CPPEditorDocument itself is quite small.
      
          * BuiltinEditorDocumentProcessor and ClangEditorDocumentProcessor
            derive from BaseEditorDocumentProcessor and implement the gaps.
      
          * Since the semantic info calculation was bound to the widget, it
            also calculated the local uses, which depend on the cursor
            position. This calculation got moved into the extracted class
            UseSeletionsUpdater in the cppeditor plugin, which is run once the
            cursor position changes or the semantic info document is updated.
      
          * Some more logic got extracted:
      	- SemanticInfoUpdater (logic was in CppEditorSupport)
      	- SemanticHighlighter (logic was in CppEditorSupport)
      
          * The *Parser and *Processor classes can be easily accessed by the
            static function get().
      
      * CppHighlightingSupport is gone since it turned out to be useless.
      
      * The editor dependency in CompletionAssistProviders is gone since we
        actually only need the file path now.
      
      Change-Id: I49d3a7bd138c5ed9620123e34480772535156508
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      89bd4ee3
  33. 20 Aug, 2014 2 commits
  34. 25 Jul, 2014 1 commit