From fc01a703dea4fe4f2eff73480958ee6c75aa8c30 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Fri, 3 Dec 2021 20:39:04 +0100
Subject: [PATCH] fftools/ffmpeg: Avoid creating unnecessary reference
The only caller of do_video_out() doesn't need the frame afterwards,
ergo one can replace an av_frame_ref() by av_frame_move_ref().
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
fftools/ffmpeg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index b0b32a69f2e..855db934bfb 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1138,6 +1138,7 @@ static void do_subtitle_out(OutputFile *of,
}
}
+/* May modify/reset next_picture */
static void do_video_out(OutputFile *of,
OutputStream *ost,
AVFrame *next_picture)
@@ -1421,8 +1422,7 @@ static void do_video_out(OutputFile *of,
av_frame_unref(ost->last_frame);
if (next_picture)
- if (av_frame_ref(ost->last_frame, next_picture) < 0)
- goto error;
+ av_frame_move_ref(ost->last_frame, next_picture);
return;
error:
--
GitLab