From 68ddefe00202f4e2abc0b5745ffdf9e1097f49af Mon Sep 17 00:00:00 2001
From: Vitaly Fanaskov <vitaly.fanaskov@qt.io>
Date: Fri, 14 Jun 2019 11:15:48 +0200
Subject: [PATCH] Code cleanups
---
ui/encouragementwidget.h | 1 -
usagestatisticplugin.cpp | 16 ++++------------
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/ui/encouragementwidget.h b/ui/encouragementwidget.h
index 04ec939..ff6c481 100644
--- a/ui/encouragementwidget.h
+++ b/ui/encouragementwidget.h
@@ -49,7 +49,6 @@ public:
std::shared_ptr<KUserFeedback::Provider> provider() const;
void setProvider(std::shared_ptr<KUserFeedback::Provider> provider);
-
protected: // QWidget interface
void showEvent(QShowEvent *event) override;
diff --git a/usagestatisticplugin.cpp b/usagestatisticplugin.cpp
index e8536c3..779d95b 100644
--- a/usagestatisticplugin.cpp
+++ b/usagestatisticplugin.cpp
@@ -8,11 +8,6 @@
#include <coreplugin/actionmanager/actioncontainer.h>
#include <coreplugin/coreconstants.h>
-#include <QAction>
-#include <QMessageBox>
-#include <QMainWindow>
-#include <QMenu>
-
#include <KUserFeedback/Provider>
#include <KUserFeedback/ApplicationVersionSource>
#include <KUserFeedback/CompilerInfoSource>
@@ -60,6 +55,10 @@ bool UsageStatisticPlugin::initialize(const QStringList &arguments, QString *err
return true;
}
+void UsageStatisticPlugin::extensionsInitialized()
+{
+}
+
static void addDefaultDataSources(KUserFeedback::Provider &provider)
{
provider.addDataSource(new KUserFeedback::ApplicationVersionSource);
@@ -105,13 +104,6 @@ bool UsageStatisticPlugin::delayedInitialize()
return true;
}
-void UsageStatisticPlugin::extensionsInitialized()
-{
- // Retrieve objects from the plugin manager's object pool
- // In the extensionsInitialized function, a plugin can be sure that all
- // plugins that depend on it are completely initialized.
-}
-
ExtensionSystem::IPlugin::ShutdownFlag UsageStatisticPlugin::aboutToShutdown()
{
storeSettings();
--
GitLab