cppquickfixes.cpp 77 KB
Newer Older
hjk's avatar
hjk committed
1
/****************************************************************************
2
**
hjk's avatar
hjk committed
3
4
** Copyright (C) 2012 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
5
**
hjk's avatar
hjk committed
6
** This file is part of Qt Creator.
7
**
hjk's avatar
hjk committed
8
9
10
11
12
13
14
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.  For licensing terms and
** conditions see http://qt.digia.com/licensing.  For further information
** use the contact form at http://qt.digia.com/contact-us.
15
16
**
** GNU Lesser General Public License Usage
hjk's avatar
hjk committed
17
18
19
20
21
22
23
24
25
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights.  These rights are described in the Digia Qt LGPL Exception
con's avatar
con committed
26
27
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
hjk's avatar
hjk committed
28
****************************************************************************/
29

30
#include "cppcompleteswitch.h"
31
32
#include "cppeditor.h"
#include "cppquickfix.h"
33
#include "cppinsertdecldef.h"
34
#include "cppinsertqtpropertymembers.h"
Leandro Melo's avatar
Leandro Melo committed
35
36
#include "cppquickfixassistant.h"
#include "cppcompleteswitch.h"
37
#include "cppfunctiondecldeflink.h"
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55

#include <ASTVisitor.h>
#include <AST.h>
#include <ASTMatcher.h>
#include <ASTPatternBuilder.h>
#include <CoreTypes.h>
#include <Literals.h>
#include <Name.h>
#include <Names.h>
#include <Symbol.h>
#include <Symbols.h>
#include <Token.h>
#include <TranslationUnit.h>
#include <Type.h>

#include <cplusplus/DependencyTable.h>
#include <cplusplus/Overview.h>
#include <cplusplus/TypeOfExpression.h>
56
#include <cpptools/ModelManagerInterface.h>
57
58
#include <cplusplus/CppRewriter.h>
#include <cpptools/cpptoolsconstants.h>
59
#include <cpptools/cpprefactoringchanges.h>
60
#include <cpptools/insertionpointlocator.h>
61
#include <cpptools/cpptoolsreuse.h>
62
63
#include <cpptools/cppclassesfilter.h>
#include <cpptools/searchsymbols.h>
64
#include <cpptools/symbolfinder.h>
65
#include <extensionsystem/iplugin.h>
66
#include <extensionsystem/pluginmanager.h>
67

68
69
#include <utils/qtcassert.h>

70
71
72
73
#include <QFileInfo>
#include <QApplication>
#include <QTextBlock>
#include <QTextCursor>
74
75
#include <cctype>

76
77
using namespace CppEditor;
using namespace CppEditor::Internal;
78
using namespace CppTools;
79
80
81
82
using namespace TextEditor;
using namespace CPlusPlus;
using namespace Utils;

83
84
85
86
87
static inline bool isQtStringLiteral(const QByteArray &id)
{
    return id == "QLatin1String" || id == "QLatin1Literal" || id == "QStringLiteral";
}

88
89
90
91
92
static inline bool isQtStringTranslation(const QByteArray &id)
{
    return id == "tr" || id == "trUtf8" || id == "translate" || id == "QT_TRANSLATE_NOOP";
}

93
94
95
96
97
98
99
namespace {

/*
    Rewrite
    a op b -> !(a invop b)
    (a op b) -> !(a invop b)
    !(a op b) -> (a invob b)
100
101

    Activates on: <= < > >= == !=
102
103
104
105
*/
class UseInverseOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
106
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
107
108
    {
        QList<CppQuickFixOperation::Ptr> result;
109
        CppRefactoringFilePtr file = interface->currentFile();
110

Leandro Melo's avatar
Leandro Melo committed
111
        const QList<AST *> &path = interface->path();
112
113
114
115
        int index = path.size() - 1;
        BinaryExpressionAST *binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return result;
Leandro Melo's avatar
Leandro Melo committed
116
        if (! interface->isCursorOn(binary->binary_op_token))
117
118
119
            return result;

        Kind invertToken;
120
        switch (file->tokenAt(binary->binary_op_token).kind()) {
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
        case T_LESS_EQUAL:
            invertToken = T_GREATER;
            break;
        case T_LESS:
            invertToken = T_GREATER_EQUAL;
            break;
        case T_GREATER:
            invertToken = T_LESS_EQUAL;
            break;
        case T_GREATER_EQUAL:
            invertToken = T_LESS;
            break;
        case T_EQUAL_EQUAL:
            invertToken = T_EXCLAIM_EQUAL;
            break;
        case T_EXCLAIM_EQUAL:
            invertToken = T_EQUAL_EQUAL;
            break;
        default:
            return result;
        }

Leandro Melo's avatar
Leandro Melo committed
143
        result.append(CppQuickFixOperation::Ptr(new Operation(interface, index, binary, invertToken)));
144
145
146
147
148
149
150
151
152
153
154
155
156
        return result;
    }

private:
    class Operation: public CppQuickFixOperation
    {
        BinaryExpressionAST *binary;
        NestedExpressionAST *nested;
        UnaryExpressionAST *negation;

        QString replacement;

    public:
Leandro Melo's avatar
Leandro Melo committed
157
158
159
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface,
            int priority, BinaryExpressionAST *binary, Kind invertToken)
            : CppQuickFixOperation(interface, priority)
160
            , binary(binary), nested(0), negation(0)
161
162
163
164
165
166
167
        {
            Token tok;
            tok.f.kind = invertToken;
            replacement = QLatin1String(tok.spell());

            // check for enclosing nested expression
            if (priority - 1 >= 0)
Leandro Melo's avatar
Leandro Melo committed
168
                nested = interface->path()[priority - 1]->asNestedExpression();
169
170
171

            // check for ! before parentheses
            if (nested && priority - 2 >= 0) {
Leandro Melo's avatar
Leandro Melo committed
172
                negation = interface->path()[priority - 2]->asUnaryExpression();
173
                if (negation && ! interface->currentFile()->tokenAt(negation->unary_op_token).is(T_EXCLAIM))
174
175
176
177
178
179
180
181
182
                    negation = 0;
            }
        }

        virtual QString description() const
        {
            return QApplication::translate("CppTools::QuickFix", "Rewrite Using %1").arg(replacement);
        }

183
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
184
185
186
187
        {
            ChangeSet changes;
            if (negation) {
                // can't remove parentheses since that might break precedence
188
                changes.remove(currentFile->range(negation->unary_op_token));
189
            } else if (nested) {
190
                changes.insert(currentFile->startOf(nested), QLatin1String("!"));
191
            } else {
192
193
                changes.insert(currentFile->startOf(binary), QLatin1String("!("));
                changes.insert(currentFile->endOf(binary), QLatin1String(")"));
194
            }
195
            changes.replace(currentFile->range(binary->binary_op_token), replacement);
196
197
            currentFile->setChangeSet(changes);
            currentFile->apply();
198
199
200
201
202
203
204
205
206
207
        }
    };
};

/*
    Rewrite
    a op b

    As
    b flipop a
208
209

    Activates on: <= < > >= == != && ||
210
211
212
213
*/
class FlipBinaryOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
214
    virtual QList<QuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
215
216
    {
        QList<QuickFixOperation::Ptr> result;
Leandro Melo's avatar
Leandro Melo committed
217
        const QList<AST *> &path = interface->path();
218
        CppRefactoringFilePtr file = interface->currentFile();
219
220
221
222
223

        int index = path.size() - 1;
        BinaryExpressionAST *binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return result;
Leandro Melo's avatar
Leandro Melo committed
224
        if (! interface->isCursorOn(binary->binary_op_token))
225
226
227
            return result;

        Kind flipToken;
228
        switch (file->tokenAt(binary->binary_op_token).kind()) {
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
        case T_LESS_EQUAL:
            flipToken = T_GREATER_EQUAL;
            break;
        case T_LESS:
            flipToken = T_GREATER;
            break;
        case T_GREATER:
            flipToken = T_LESS;
            break;
        case T_GREATER_EQUAL:
            flipToken = T_LESS_EQUAL;
            break;
        case T_EQUAL_EQUAL:
        case T_EXCLAIM_EQUAL:
        case T_AMPER_AMPER:
        case T_PIPE_PIPE:
            flipToken = T_EOF_SYMBOL;
            break;
        default:
            return result;
        }

        QString replacement;
        if (flipToken != T_EOF_SYMBOL) {
            Token tok;
            tok.f.kind = flipToken;
            replacement = QLatin1String(tok.spell());
        }

Leandro Melo's avatar
Leandro Melo committed
258
        result.append(QuickFixOperation::Ptr(new Operation(interface, index, binary, replacement)));
259
260
261
262
263
264
265
        return result;
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
266
267
268
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface,
                  int priority, BinaryExpressionAST *binary, QString replacement)
            : CppQuickFixOperation(interface)
269
270
271
272
273
274
275
276
277
278
279
280
281
282
            , binary(binary)
            , replacement(replacement)
        {
            setPriority(priority);
        }

        virtual QString description() const
        {
            if (replacement.isEmpty())
                return QApplication::translate("CppTools::QuickFix", "Swap Operands");
            else
                return QApplication::translate("CppTools::QuickFix", "Rewrite Using %1").arg(replacement);
        }

283
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
284
285
286
        {
            ChangeSet changes;

287
            changes.flip(currentFile->range(binary->left_expression), currentFile->range(binary->right_expression));
288
            if (! replacement.isEmpty())
289
                changes.replace(currentFile->range(binary->binary_op_token), replacement);
290

291
292
            currentFile->setChangeSet(changes);
            currentFile->apply();
293
294
295
296
297
298
299
300
301
302
303
304
305
306
        }

    private:
        BinaryExpressionAST *binary;
        QString replacement;
    };
};

/*
    Rewrite
    !a && !b

    As
    !(a || b)
307
308

    Activates on: &&
309
310
311
312
*/
class RewriteLogicalAndOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
313
    virtual QList<QuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
314
315
316
    {
        QList<QuickFixOperation::Ptr> result;
        BinaryExpressionAST *expression = 0;
Leandro Melo's avatar
Leandro Melo committed
317
        const QList<AST *> &path = interface->path();
318
        CppRefactoringFilePtr file = interface->currentFile();
319
320
321
322
323
324
325
326
327
328
329

        int index = path.size() - 1;
        for (; index != -1; --index) {
            expression = path.at(index)->asBinaryExpression();
            if (expression)
                break;
        }

        if (! expression)
            return result;

Leandro Melo's avatar
Leandro Melo committed
330
        if (! interface->isCursorOn(expression->binary_op_token))
331
332
            return result;

Leandro Melo's avatar
Leandro Melo committed
333
        QSharedPointer<Operation> op(new Operation(interface));
334
335

        if (expression->match(op->pattern, &matcher) &&
336
337
338
                file->tokenAt(op->pattern->binary_op_token).is(T_AMPER_AMPER) &&
                file->tokenAt(op->left->unary_op_token).is(T_EXCLAIM) &&
                file->tokenAt(op->right->unary_op_token).is(T_EXCLAIM)) {
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
            op->setDescription(QApplication::translate("CppTools::QuickFix", "Rewrite Condition Using ||"));
            op->setPriority(index);
            result.append(op);
        }

        return result;
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
        QSharedPointer<ASTPatternBuilder> mk;
        UnaryExpressionAST *left;
        UnaryExpressionAST *right;
        BinaryExpressionAST *pattern;

Leandro Melo's avatar
Leandro Melo committed
356
357
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
            : CppQuickFixOperation(interface)
358
359
360
361
362
363
364
            , mk(new ASTPatternBuilder)
        {
            left = mk->UnaryExpression();
            right = mk->UnaryExpression();
            pattern = mk->BinaryExpression(left, right);
        }

365
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
366
367
        {
            ChangeSet changes;
368
369
370
371
372
            changes.replace(currentFile->range(pattern->binary_op_token), QLatin1String("||"));
            changes.remove(currentFile->range(left->unary_op_token));
            changes.remove(currentFile->range(right->unary_op_token));
            const int start = currentFile->startOf(pattern);
            const int end = currentFile->endOf(pattern);
373
374
375
            changes.insert(start, QLatin1String("!("));
            changes.insert(end, QLatin1String(")"));

376
377
378
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(pattern));
            currentFile->apply();
379
380
381
382
383
384
385
        }
    };

private:
    ASTMatcher matcher;
};

386
387
388
389
390
391
392
/*
    Rewrite
    int *a, b;

    As
    int *a;
    int b;
393
394

    Activates on: the type or the variable names.
395
*/
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
class SplitSimpleDeclarationOp: public CppQuickFixFactory
{
    static bool checkDeclaration(SimpleDeclarationAST *declaration)
    {
        if (! declaration->semicolon_token)
            return false;

        if (! declaration->decl_specifier_list)
            return false;

        for (SpecifierListAST *it = declaration->decl_specifier_list; it; it = it->next) {
            SpecifierAST *specifier = it->value;

            if (specifier->asEnumSpecifier() != 0)
                return false;

            else if (specifier->asClassSpecifier() != 0)
                return false;
        }

        if (! declaration->declarator_list)
            return false;

        else if (! declaration->declarator_list->next)
            return false;

        return true;
    }

public:
Leandro Melo's avatar
Leandro Melo committed
426
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
427
428
429
    {
        QList<CppQuickFixOperation::Ptr> result;
        CoreDeclaratorAST *core_declarator = 0;
Leandro Melo's avatar
Leandro Melo committed
430
        const QList<AST *> &path = interface->path();
431
        CppRefactoringFilePtr file = interface->currentFile();
432
433
434
435
436
437
438
439
440
441
442

        for (int index = path.size() - 1; index != -1; --index) {
            AST *node = path.at(index);

            if (CoreDeclaratorAST *coreDecl = node->asCoreDeclarator())
                core_declarator = coreDecl;

            else if (SimpleDeclarationAST *simpleDecl = node->asSimpleDeclaration()) {
                if (checkDeclaration(simpleDecl)) {
                    SimpleDeclarationAST *declaration = simpleDecl;

443
                    const int cursorPosition = file->cursor().selectionStart();
444

445
446
                    const int startOfDeclSpecifier = file->startOf(declaration->decl_specifier_list->firstToken());
                    const int endOfDeclSpecifier = file->endOf(declaration->decl_specifier_list->lastToken() - 1);
447
448
449

                    if (cursorPosition >= startOfDeclSpecifier && cursorPosition <= endOfDeclSpecifier) {
                        // the AST node under cursor is a specifier.
Leandro Melo's avatar
Leandro Melo committed
450
                        return singleResult(new Operation(interface, index, declaration));
451
452
                    }

Leandro Melo's avatar
Leandro Melo committed
453
                    if (core_declarator && interface->isCursorOn(core_declarator)) {
454
                        // got a core-declarator under the text cursor.
Leandro Melo's avatar
Leandro Melo committed
455
                        return singleResult(new Operation(interface, index, declaration));
456
457
458
459
460
461
462
463
464
465
466
467
468
469
                    }
                }

                break;
            }
        }

        return result;
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
470
471
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface, int priority, SimpleDeclarationAST *decl)
            : CppQuickFixOperation(interface, priority)
472
473
474
475
476
477
            , declaration(decl)
        {
            setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Split Declaration"));
        }

478
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
479
480
481
482
        {
            ChangeSet changes;

            SpecifierListAST *specifiers = declaration->decl_specifier_list;
483
484
485
            int declSpecifiersStart = currentFile->startOf(specifiers->firstToken());
            int declSpecifiersEnd = currentFile->endOf(specifiers->lastToken() - 1);
            int insertPos = currentFile->endOf(declaration->semicolon_token);
486
487
488
489
490
491
492
493
494

            DeclaratorAST *prevDeclarator = declaration->declarator_list->value;

            for (DeclaratorListAST *it = declaration->declarator_list->next; it; it = it->next) {
                DeclaratorAST *declarator = it->value;

                changes.insert(insertPos, QLatin1String("\n"));
                changes.copy(declSpecifiersStart, declSpecifiersEnd, insertPos);
                changes.insert(insertPos, QLatin1String(" "));
495
                changes.move(currentFile->range(declarator), insertPos);
496
497
                changes.insert(insertPos, QLatin1String(";"));

498
499
                const int prevDeclEnd = currentFile->endOf(prevDeclarator);
                changes.remove(prevDeclEnd, currentFile->startOf(declarator));
500
501
502
503

                prevDeclarator = declarator;
            }

504
505
506
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(declaration));
            currentFile->apply();
507
508
509
510
511
512
513
514
515
        }

    private:
        SimpleDeclarationAST *declaration;
    };
};

/*
    Add curly braces to a if statement that doesn't already contain a
516
517
518
519
520
521
522
523
    compound statement. I.e.

    if (a)
        b;
    becomes
    if (a) {
        b;
    }
524
525

    Activates on: the if
526
527
528
529
*/
class AddBracesToIfOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
530
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
531
    {
Leandro Melo's avatar
Leandro Melo committed
532
        const QList<AST *> &path = interface->path();
533
534
535
536

        // show when we're on the 'if' of an if statement
        int index = path.size() - 1;
        IfStatementAST *ifStatement = path.at(index)->asIfStatement();
Leandro Melo's avatar
Leandro Melo committed
537
        if (ifStatement && interface->isCursorOn(ifStatement->if_token) && ifStatement->statement
538
            && ! ifStatement->statement->asCompoundStatement()) {
Leandro Melo's avatar
Leandro Melo committed
539
            return singleResult(new Operation(interface, index, ifStatement->statement));
540
541
542
543
544
545
546
        }

        // or if we're on the statement contained in the if
        // ### This may not be such a good idea, consider nested ifs...
        for (; index != -1; --index) {
            IfStatementAST *ifStatement = path.at(index)->asIfStatement();
            if (ifStatement && ifStatement->statement
Leandro Melo's avatar
Leandro Melo committed
547
                && interface->isCursorOn(ifStatement->statement)
548
                && ! ifStatement->statement->asCompoundStatement()) {
Leandro Melo's avatar
Leandro Melo committed
549
                return singleResult(new Operation(interface, index, ifStatement->statement));
550
551
552
553
554
555
556
557
558
559
560
561
562
            }
        }

        // ### This could very well be extended to the else branch
        // and other nodes entirely.

        return noResult();
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
563
564
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface, int priority, StatementAST *statement)
            : CppQuickFixOperation(interface, priority)
565
566
567
568
569
570
            , _statement(statement)
        {
            setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Add Curly Braces"));
        }

571
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
572
573
574
        {
            ChangeSet changes;

575
            const int start = currentFile->endOf(_statement->firstToken() - 1);
576
577
            changes.insert(start, QLatin1String(" {"));

578
            const int end = currentFile->endOf(_statement->lastToken() - 1);
579
            changes.insert(end, QLatin1String("\n}"));
580

581
582
583
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(Utils::ChangeSet::Range(start, end));
            currentFile->apply();
584
585
586
587
588
589
590
591
592
593
594
595
596
597
        }

    private:
        StatementAST *_statement;
    };
};

/*
    Replace
    if (Type name = foo()) {...}

    With
    Type name = foo;
    if (name) {...}
598
599

    Activates on: the name of the introduced variable
600
601
602
603
*/
class MoveDeclarationOutOfIfOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
604
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
605
    {
Leandro Melo's avatar
Leandro Melo committed
606
607
        const QList<AST *> &path = interface->path();
        QSharedPointer<Operation> op(new Operation(interface));
608
609
610
611
612
613
614
615
616
617

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (IfStatementAST *statement = path.at(index)->asIfStatement()) {
                if (statement->match(op->pattern, &op->matcher) && op->condition->declarator) {
                    DeclaratorAST *declarator = op->condition->declarator;
                    op->core = declarator->core_declarator;
                    if (! op->core)
                        return noResult();

Leandro Melo's avatar
Leandro Melo committed
618
                    if (interface->isCursorOn(op->core)) {
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
                        QList<CppQuickFixOperation::Ptr> result;
                        op->setPriority(index);
                        result.append(op);
                        return result;
                    }
                }
            }
        }

        return noResult();
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
635
636
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
            : CppQuickFixOperation(interface)
637
638
639
640
641
642
643
644
        {
            setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Move Declaration out of Condition"));

            condition = mk.Condition();
            pattern = mk.IfStatement(condition);
        }

645
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
646
647
648
        {
            ChangeSet changes;

649
            changes.copy(currentFile->range(core), currentFile->startOf(condition));
650

651
652
            int insertPos = currentFile->startOf(pattern);
            changes.move(currentFile->range(condition), insertPos);
653
654
            changes.insert(insertPos, QLatin1String(";\n"));

655
656
657
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(pattern));
            currentFile->apply();
658
659
660
661
        }

        ASTMatcher matcher;
        ASTPatternBuilder mk;
662
        CPPEditorWidget *editor;
663
664
665
666
667
668
669
670
671
672
673
674
675
        ConditionAST *condition;
        IfStatementAST *pattern;
        CoreDeclaratorAST *core;
    };
};

/*
    Replace
    while (Type name = foo()) {...}

    With
    Type name;
    while ((name = foo()) != 0) {...}
676
677

    Activates on: the name of the introduced variable
678
679
680
681
*/
class MoveDeclarationOutOfWhileOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
682
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
683
    {
Leandro Melo's avatar
Leandro Melo committed
684
685
        const QList<AST *> &path = interface->path();
        QSharedPointer<Operation> op(new Operation(interface));
686
687
688
689
690
691
692
693
694
695
696

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (WhileStatementAST *statement = path.at(index)->asWhileStatement()) {
                if (statement->match(op->pattern, &op->matcher) && op->condition->declarator) {
                    DeclaratorAST *declarator = op->condition->declarator;
                    op->core = declarator->core_declarator;

                    if (! op->core)
                        return noResult();

697
                    else if (! declarator->equal_token)
698
699
700
701
702
                        return noResult();

                    else if (! declarator->initializer)
                        return noResult();

Leandro Melo's avatar
Leandro Melo committed
703
                    if (interface->isCursorOn(op->core)) {
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
                        QList<CppQuickFixOperation::Ptr> result;
                        op->setPriority(index);
                        result.append(op);
                        return result;
                    }
                }
            }
        }

        return noResult();
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
720
721
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
            : CppQuickFixOperation(interface)
722
723
724
725
726
727
728
729
        {
            setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Move Declaration out of Condition"));

            condition = mk.Condition();
            pattern = mk.WhileStatement(condition);
        }

730
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
731
732
733
        {
            ChangeSet changes;

734
735
            changes.insert(currentFile->startOf(condition), QLatin1String("("));
            changes.insert(currentFile->endOf(condition), QLatin1String(") != 0"));
736

737
738
739
740
            int insertPos = currentFile->startOf(pattern);
            const int conditionStart = currentFile->startOf(condition);
            changes.move(conditionStart, currentFile->startOf(core), insertPos);
            changes.copy(currentFile->range(core), insertPos);
741
742
            changes.insert(insertPos, QLatin1String(";\n"));

743
744
745
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(pattern));
            currentFile->apply();
746
747
748
749
        }

        ASTMatcher matcher;
        ASTPatternBuilder mk;
750
        CPPEditorWidget *editor;
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
        ConditionAST *condition;
        WhileStatementAST *pattern;
        CoreDeclaratorAST *core;
    };
};

/*
  Replace
     if (something && something_else) {
     }

  with
     if (something) {
        if (something_else) {
        }
     }

  and
    if (something || something_else)
      x;

  with
    if (something)
      x;
    else if (something_else)
      x;
777
778

    Activates on: && or ||
779
780
781
782
*/
class SplitIfStatementOp: public CppQuickFixFactory
{
public:
Leandro Melo's avatar
Leandro Melo committed
783
    virtual QList<CppQuickFixOperation::Ptr> match(const QSharedPointer<const CppQuickFixAssistInterface> &interface)
784
785
    {
        IfStatementAST *pattern = 0;
Leandro Melo's avatar
Leandro Melo committed
786
        const QList<AST *> &path = interface->path();
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806

        int index = path.size() - 1;
        for (; index != -1; --index) {
            AST *node = path.at(index);
            if (IfStatementAST *stmt = node->asIfStatement()) {
                pattern = stmt;
                break;
            }
        }

        if (! pattern || ! pattern->statement)
            return noResult();

        unsigned splitKind = 0;
        for (++index; index < path.size(); ++index) {
            AST *node = path.at(index);
            BinaryExpressionAST *condition = node->asBinaryExpression();
            if (! condition)
                return noResult();

807
            Token binaryToken = interface->currentFile()->tokenAt(condition->binary_op_token);
808
809
810
811
812
813
814
815
816
817
818
819
820

            // only accept a chain of ||s or &&s - no mixing
            if (! splitKind) {
                splitKind = binaryToken.kind();
                if (splitKind != T_AMPER_AMPER && splitKind != T_PIPE_PIPE)
                    return noResult();
                // we can't reliably split &&s in ifs with an else branch
                if (splitKind == T_AMPER_AMPER && pattern->else_statement)
                    return noResult();
            } else if (splitKind != binaryToken.kind()) {
                return noResult();
            }

Leandro Melo's avatar
Leandro Melo committed
821
822
            if (interface->isCursorOn(condition->binary_op_token))
                return singleResult(new Operation(interface, index, pattern, condition));
823
824
825
826
827
828
829
830
831
        }

        return noResult();
    }

private:
    class Operation: public CppQuickFixOperation
    {
    public:
Leandro Melo's avatar
Leandro Melo committed
832
        Operation(const QSharedPointer<const CppQuickFixAssistInterface> &interface, int priority,
833
                  IfStatementAST *pattern, BinaryExpressionAST *condition)
Leandro Melo's avatar
Leandro Melo committed
834
            : CppQuickFixOperation(interface, priority)
835
836
837
838
839
840
841
            , pattern(pattern)
            , condition(condition)
        {
            setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Split if Statement"));
        }

842
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &)
843
        {
844
            const Token binaryToken = currentFile->tokenAt(condition->binary_op_token);
845
846

            if (binaryToken.is(T_AMPER_AMPER))
847
                splitAndCondition(currentFile);
848
            else
849
                splitOrCondition(currentFile);
850
851
        }

852
        void splitAndCondition(CppRefactoringFilePtr currentFile)
853
854
855
        {
            ChangeSet changes;

856
            int startPos = currentFile->startOf(pattern);
857
            changes.insert(startPos, QLatin1String("if ("));
858
            changes.move(currentFile->range(condition->left_expression), startPos);
859
860
            changes.insert(startPos, QLatin1String(") {\n"));

861
862
863
            const int lExprEnd = currentFile->endOf(condition->left_expression);
            changes.remove(lExprEnd, currentFile->startOf(condition->right_expression));
            changes.insert(currentFile->endOf(pattern), QLatin1String("\n}"));
864

865
866
867
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(pattern));
            currentFile->apply();
868
869
        }

870
        void splitOrCondition(CppRefactoringFilePtr currentFile)
871
872
873
874
875
876
        {
            ChangeSet changes;

            StatementAST *ifTrueStatement = pattern->statement;
            CompoundStatementAST *compoundStatement = ifTrueStatement->asCompoundStatement();

877
            int insertPos = currentFile->endOf(ifTrueStatement);
878
879
880
881
882
883
            if (compoundStatement)
                changes.insert(insertPos, QLatin1String(" "));
            else
                changes.insert(insertPos, QLatin1String("\n"));
            changes.insert(insertPos, QLatin1String("else if ("));

884
885
            const int rExprStart = currentFile->startOf(condition->right_expression);
            changes.move(rExprStart, currentFile->startOf(pattern->rparen_token), insertPos);
886
887
            changes.insert(insertPos, QLatin1String(")"));

888
889
            const int rParenEnd = currentFile->endOf(pattern->rparen_token);
            changes.copy(rParenEnd, currentFile->endOf(pattern->statement), insertPos);
890

891
892
            const int lExprEnd = currentFile->endOf(condition->left_expression);
            changes.remove(lExprEnd, currentFile->startOf(condition->right_expression));
893

894
895
896
            currentFile->setChangeSet(changes);
            currentFile->appendIndentRange(currentFile->range(pattern));
            currentFile->apply();
897
898
899
900
901
902
903
904
905
906
        }

    private:
        IfStatementAST *pattern;
        BinaryExpressionAST *condition;
    };
};

/*
  Replace
907
908
909
910
911
912
    "abcd"  -> QLatin1String("abcd")
    @"abcd" -> QLatin1String("abcd") (Objective C)
    'a'     -> QLatin1Char('a')
    'a'     -> "a"
    "a"     -> 'a' or QLatin1Char('a') (Single character string constants)
    "\n"    -> '\n', QLatin1Char('\n')
913
914
915
  Except if they are already enclosed in
    QLatin1Char, QT_TRANSLATE_NOOP, tr,
    trUtf8, QLatin1Literal, QLatin1String
916

917
    Activates on: the string or character literal
918
*/
919
920
921
922
923
924
925

static inline QString msgQtStringLiteralDescription(const QString &replacement, int qtVersion)
{
    return QApplication::translate("CppTools::QuickFix", "Enclose in %1(...) (Qt %2)")
           .arg(replacement).arg(qtVersion);
}

926
927
928
929
930
static inline QString msgQtStringLiteralDescription(const QString &replacement)
{
    return QApplication::translate("CppTools::QuickFix", "Enclose in %1(...)").arg(replacement);
}

931
932
933
class WrapStringLiteral: public CppQuickFixFactory
{
public:
934
935
936
937
938
939
940
941
942
943
944
945
946
    typedef const QSharedPointer<const CppQuickFixAssistInterface> AssistInterfacePtr;

    enum ActionFlags
    {
        EncloseInQLatin1CharAction = 0x1, EncloseInQLatin1StringAction = 0x2, EncloseInQStringLiteralAction = 0x4,
        EncloseActionMask = EncloseInQLatin1CharAction | EncloseInQLatin1StringAction | EncloseInQStringLiteralAction,
        TranslateTrAction = 0x8, TranslateQCoreApplicationAction = 0x10, TranslateNoopAction = 0x20,
        TranslationMask = TranslateTrAction | TranslateQCoreApplicationAction | TranslateNoopAction,
        RemoveObjectiveCAction = 0x40,
        ConvertEscapeSequencesToCharAction = 0x100, ConvertEscapeSequencesToStringAction = 0x200,
        SingleQuoteAction = 0x400, DoubleQuoteAction = 0x800
    };

947
948
    enum Type { TypeString, TypeObjCString, TypeChar, TypeNone };

949
950
951
952
953
954
955
956
957
958
959
960
    virtual QList<CppQuickFixOperation::Ptr> match(const AssistInterfacePtr &interface);
    static QString replacement(unsigned actions);
    static QByteArray stringToCharEscapeSequences(const QByteArray &content);
    static QByteArray charToStringEscapeSequences(const QByteArray &content);

    static ExpressionAST *analyze(const QList<AST *> &path, const CppRefactoringFilePtr &file,
                                  Type *type,
                                  QByteArray *enclosingFunction = 0,
                                  CallAST **enclosingFunctionCall = 0);

    // Operations performs the operations of type ActionFlags passed in as actions.
    class Operation : public CppQuickFixOperation
961
    {
962
963
964
965
    public:
        Operation(const AssistInterfacePtr &interface, int priority,
                  unsigned actions, const QString &description, ExpressionAST *literal,
                  const QString &translationContext = QString());
966

967
968
969
970
971
972
973
        virtual void performChanges(const CppRefactoringFilePtr &currentFile, const CppRefactoringChanges &);
    private:
        const unsigned m_actions;
        ExpressionAST *m_literal;
        const QString m_translationContext;
    };
};
974

975
976
977
/* Analze a string/character literal like "x", QLatin1String("x") and return the literal
 * (StringLiteral or NumericLiteral for characters) and its type
 * and the enclosing function (QLatin1String, tr...) */
978

979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
ExpressionAST *WrapStringLiteral::analyze(const QList<AST *> &path,
                                          const CppRefactoringFilePtr &file,
                                          Type *type,
                                          QByteArray *enclosingFunction /* = 0 */,
                                          CallAST **enclosingFunctionCall /* = 0 */)
{
    *type = TypeNone;
    if (enclosingFunction)
        enclosingFunction->clear();
    if (enclosingFunctionCall)
        *enclosingFunctionCall = 0;

    if (path.isEmpty())
        return 0;

    ExpressionAST *literal = path.last()->asExpression();
    if (literal) {
        if (literal->asStringLiteral()) {
            // Check for Objective C string (@"bla")
            const QChar firstChar = file->charAt(file->startOf(literal));
            *type = firstChar == QLatin1Char('@') ? TypeObjCString : TypeString;
        } else if (NumericLiteralAST *numericLiteral = literal->asNumericLiteral()) {
For faster browsing, not all history is shown. View entire blame