cppquickfixes.cpp 192 KB
Newer Older
hjk's avatar
hjk committed
1
/****************************************************************************
2
**
3
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
hjk's avatar
hjk committed
4
** Contact: http://www.qt-project.org/legal
5
**
hjk's avatar
hjk committed
6
** This file is part of Qt Creator.
7
**
hjk's avatar
hjk committed
8 9 10 11 12 13 14
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.  For licensing terms and
** conditions see http://qt.digia.com/licensing.  For further information
** use the contact form at http://qt.digia.com/contact-us.
15 16
**
** GNU Lesser General Public License Usage
hjk's avatar
hjk committed
17 18 19 20 21 22 23 24 25
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights.  These rights are described in the Digia Qt LGPL Exception
con's avatar
con committed
26 27
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
hjk's avatar
hjk committed
28
****************************************************************************/
29

Nikolai Kosjar's avatar
Nikolai Kosjar committed
30 31
#include "cppquickfixes.h"

32
#include "cppeditor.h"
33
#include "cppfunctiondecldeflink.h"
Leandro Melo's avatar
Leandro Melo committed
34
#include "cppquickfixassistant.h"
35
#include "cppvirtualfunctionassistprovider.h"
36
#include "cppinsertvirtualmethods.h"
37

38 39
#include <coreplugin/icore.h>

40
#include <cpptools/cppclassesfilter.h>
41
#include <cpptools/cppcodestylesettings.h>
42 43
#include <cpptools/cpppointerdeclarationformatter.h>
#include <cpptools/cpptoolsconstants.h>
44
#include <cpptools/cpptoolsreuse.h>
45
#include <cpptools/includeutils.h>
46
#include <cpptools/insertionpointlocator.h>
47
#include <cpptools/symbolfinder.h>
48

49
#include <cplusplus/ASTPath.h>
50
#include <cplusplus/CPlusPlusForwardDeclarations.h>
51 52 53 54
#include <cplusplus/CppRewriter.h>
#include <cplusplus/DependencyTable.h>
#include <cplusplus/TypeOfExpression.h>

55
#include <extensionsystem/pluginmanager.h>
56

57 58
#include <utils/qtcassert.h>

59
#include <QApplication>
60
#include <QDir>
61
#include <QFileInfo>
62 63
#include <QInputDialog>
#include <QMessageBox>
Nikolai Kosjar's avatar
Nikolai Kosjar committed
64
#include <QSharedPointer>
65
#include <QTextCursor>
66
#include <QTextCodec>
67

Nikolai Kosjar's avatar
Nikolai Kosjar committed
68 69
#include <cctype>

70
using namespace CPlusPlus;
71 72
using namespace CppEditor;
using namespace CppEditor::Internal;
73 74
using namespace CppTools;
using namespace TextEditor;
Orgad Shaneh's avatar
Orgad Shaneh committed
75
using Utils::ChangeSet;
Nikolai Kosjar's avatar
Nikolai Kosjar committed
76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

void CppEditor::Internal::registerQuickFixes(ExtensionSystem::IPlugin *plugIn)
{
    plugIn->addAutoReleasedObject(new AddIncludeForUndefinedIdentifier);
    plugIn->addAutoReleasedObject(new AddIncludeForForwardDeclaration);

    plugIn->addAutoReleasedObject(new FlipLogicalOperands);
    plugIn->addAutoReleasedObject(new InverseLogicalComparison);
    plugIn->addAutoReleasedObject(new RewriteLogicalAnd);

    plugIn->addAutoReleasedObject(new ConvertToCamelCase);

    plugIn->addAutoReleasedObject(new ConvertCStringToNSString);
    plugIn->addAutoReleasedObject(new ConvertNumericLiteral);
    plugIn->addAutoReleasedObject(new TranslateStringLiteral);
    plugIn->addAutoReleasedObject(new WrapStringLiteral);

    plugIn->addAutoReleasedObject(new MoveDeclarationOutOfIf);
    plugIn->addAutoReleasedObject(new MoveDeclarationOutOfWhile);

    plugIn->addAutoReleasedObject(new SplitIfStatement);
    plugIn->addAutoReleasedObject(new SplitSimpleDeclaration);

    plugIn->addAutoReleasedObject(new AddLocalDeclaration);
    plugIn->addAutoReleasedObject(new AddBracesToIf);
    plugIn->addAutoReleasedObject(new RearrangeParamDeclarationList);
    plugIn->addAutoReleasedObject(new ReformatPointerDeclaration);

    plugIn->addAutoReleasedObject(new CompleteSwitchCaseStatement);
    plugIn->addAutoReleasedObject(new InsertQtPropertyMembers);

    plugIn->addAutoReleasedObject(new ApplyDeclDefLinkChanges);
    plugIn->addAutoReleasedObject(new ExtractFunction);
109
    plugIn->addAutoReleasedObject(new ExtractLiteralAsParameter);
Nikolai Kosjar's avatar
Nikolai Kosjar committed
110 111 112
    plugIn->addAutoReleasedObject(new GenerateGetterSetter);
    plugIn->addAutoReleasedObject(new InsertDeclFromDef);
    plugIn->addAutoReleasedObject(new InsertDefFromDecl);
113 114 115

    plugIn->addAutoReleasedObject(new MoveFuncDefOutside);
    plugIn->addAutoReleasedObject(new MoveFuncDefToDecl);
116 117

    plugIn->addAutoReleasedObject(new AssignToLocalVariable);
118 119

    plugIn->addAutoReleasedObject(new InsertVirtualMethods);
120 121

    plugIn->addAutoReleasedObject(new OptimizeForLoop);
122 123

    plugIn->addAutoReleasedObject(new EscapeStringLiteral);
Nikolai Kosjar's avatar
Nikolai Kosjar committed
124
}
125

126 127 128 129
// In the following anonymous namespace all functions are collected, which could be of interest for
// different quick fixes.
namespace {

130 131 132 133 134 135
enum DefPos {
    DefPosInsideClass,
    DefPosOutsideClass,
    DefPosImplementationFile
};

136
InsertionLocation insertLocationForMethodDefinition(Symbol *symbol, const bool useSymbolFinder,
137 138 139 140 141 142 143
                                                    CppRefactoringChanges& refactoring,
                                                    const QString& fileName)
{
    QTC_ASSERT(symbol, return InsertionLocation());

    // Try to find optimal location
    const InsertionPointLocator locator(refactoring);
144 145
    const QList<InsertionLocation> list
            = locator.methodDefinition(symbol, useSymbolFinder, fileName);
146 147
    for (int i = 0; i < list.count(); ++i) {
        InsertionLocation location = list.at(i);
Orgad Shaneh's avatar
Orgad Shaneh committed
148
        if (location.isValid() && location.fileName() == fileName)
149 150 151
            return location;
    }

152 153
    // ...failed,
    // if class member try to get position right after class
154
    CppRefactoringFilePtr file = refactoring.file(fileName);
155 156 157 158 159 160 161 162 163 164 165 166 167
    unsigned line = 0, column = 0;
    if (Class *clazz = symbol->enclosingClass()) {
        if (symbol->fileName() == fileName.toUtf8()) {
            file->cppDocument()->translationUnit()->getPosition(clazz->endOffset(), &line, &column);
            if (line != 0) {
                ++column; // Skipping the ";"
                return InsertionLocation(fileName, QLatin1String("\n\n"), QLatin1String(""),
                                         line, column);
            }
        }
    }

    // fall through: position at end of file
168 169 170 171 172 173 174 175 176 177
    const QTextDocument *doc = file->document();
    int pos = qMax(0, doc->characterCount() - 1);

    //TODO watch for matching namespace
    //TODO watch for moc-includes

    file->lineAndColumn(pos, &line, &column);
    return InsertionLocation(fileName, QLatin1String("\n\n"), QLatin1String("\n"), line, column);
}

178
inline bool isQtStringLiteral(const QByteArray &id)
179 180 181 182
{
    return id == "QLatin1String" || id == "QLatin1Literal" || id == "QStringLiteral";
}

183
inline bool isQtStringTranslation(const QByteArray &id)
184 185 186 187
{
    return id == "tr" || id == "trUtf8" || id == "translate" || id == "QT_TRANSLATE_NOOP";
}

188 189 190 191 192
Class *isMemberFunction(const LookupContext &context, Function *function)
{
    QTC_ASSERT(function, return 0);

    Scope *enclosingScope = function->enclosingScope();
193
    while (!(enclosingScope->isNamespace() || enclosingScope->isClass()))
194 195 196 197
        enclosingScope = enclosingScope->enclosingScope();
    QTC_ASSERT(enclosingScope != 0, return 0);

    const Name *functionName = function->name();
198
    if (!functionName)
199
        return 0;
200

201
    if (!functionName->isQualifiedNameId())
202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217
        return 0; // trying to add a declaration for a global function

    const QualifiedNameId *q = functionName->asQualifiedNameId();
    if (!q->base())
        return 0;

    if (ClassOrNamespace *binding = context.lookupType(q->base(), enclosingScope)) {
        foreach (Symbol *s, binding->symbols()) {
            if (Class *matchingClass = s->asClass())
                return matchingClass;
        }
    }

    return 0;
}

218 219 220 221 222 223 224 225 226 227 228 229 230
Namespace *isNamespaceFunction(const LookupContext &context, Function *function)
{
    QTC_ASSERT(function, return 0);
    if (isMemberFunction(context, function))
        return 0;

    Scope *enclosingScope = function->enclosingScope();
    while (!(enclosingScope->isNamespace() || enclosingScope->isClass()))
        enclosingScope = enclosingScope->enclosingScope();
    QTC_ASSERT(enclosingScope != 0, return 0);

    const Name *functionName = function->name();
    if (!functionName)
231
        return 0;
232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255

    // global namespace
    if (!functionName->isQualifiedNameId()) {
        foreach (Symbol *s, context.globalNamespace()->symbols()) {
            if (Namespace *matchingNamespace = s->asNamespace())
                return matchingNamespace;
        }
        return 0;
    }

    const QualifiedNameId *q = functionName->asQualifiedNameId();
    if (!q->base())
        return 0;

    if (ClassOrNamespace *binding = context.lookupType(q->base(), enclosingScope)) {
        foreach (Symbol *s, binding->symbols()) {
            if (Namespace *matchingNamespace = s->asNamespace())
                return matchingNamespace;
        }
    }

    return 0;
}

256 257 258 259 260
// Given include is e.g. "afile.h" or <afile.h> (quotes/angle brackets included!).
void insertNewIncludeDirective(const QString &include, CppRefactoringFilePtr file)
{
    // Find optimal position
    using namespace IncludeUtils;
261
    LineForNewIncludeDirective finder(file->document(), file->cppDocument()->resolvedIncludes(),
262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286
                                      LineForNewIncludeDirective::IgnoreMocIncludes,
                                      LineForNewIncludeDirective::AutoDetect);
    unsigned newLinesToPrepend = 0;
    unsigned newLinesToAppend = 0;
    const int insertLine = finder(include, &newLinesToPrepend, &newLinesToAppend);
    QTC_ASSERT(insertLine >= 1, return);
    const int insertPosition = file->position(insertLine, 1);
    QTC_ASSERT(insertPosition >= 0, return);

    // Construct text to insert
    const QString includeLine = QLatin1String("#include ") + include + QLatin1Char('\n');
    QString prependedNewLines, appendedNewLines;
    while (newLinesToAppend--)
        appendedNewLines += QLatin1String("\n");
    while (newLinesToPrepend--)
        prependedNewLines += QLatin1String("\n");
    const QString textToInsert = prependedNewLines + includeLine + appendedNewLines;

    // Insert
    ChangeSet changes;
    changes.insert(insertPosition, textToInsert);
    file->setChangeSet(changes);
    file->apply();
}

287 288 289 290 291 292
bool nameIncludesOperatorName(const Name *name)
{
    return name->isOperatorNameId()
        || (name->isQualifiedNameId() && name->asQualifiedNameId()->name()->isOperatorNameId());
}

293 294 295 296
} // anonymous namespace

namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
297
class InverseLogicalComparisonOp: public CppQuickFixOperation
298 299
{
public:
Nikolai Kosjar's avatar
Nikolai Kosjar committed
300 301 302 303
    InverseLogicalComparisonOp(const CppQuickFixInterface &interface, int priority,
                               BinaryExpressionAST *binary, Kind invertToken)
        : CppQuickFixOperation(interface, priority)
        , binary(binary), nested(0), negation(0)
304
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
305 306 307
        Token tok;
        tok.f.kind = invertToken;
        replacement = QLatin1String(tok.spell());
308

Nikolai Kosjar's avatar
Nikolai Kosjar committed
309 310 311
        // check for enclosing nested expression
        if (priority - 1 >= 0)
            nested = interface->path()[priority - 1]->asNestedExpression();
312

Nikolai Kosjar's avatar
Nikolai Kosjar committed
313 314 315
        // check for ! before parentheses
        if (nested && priority - 2 >= 0) {
            negation = interface->path()[priority - 2]->asUnaryExpression();
316 317
            if (negation
                    && !interface->currentFile()->tokenAt(negation->unary_op_token).is(T_EXCLAIM)) {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
318
                negation = 0;
319
            }
320 321 322
        }
    }

Nikolai Kosjar's avatar
Nikolai Kosjar committed
323
    QString description() const
324
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
325 326
        return QApplication::translate("CppTools::QuickFix", "Rewrite Using %1").arg(replacement);
    }
327

Nikolai Kosjar's avatar
Nikolai Kosjar committed
328 329 330 331 332 333 334 335 336 337 338 339 340 341
    void perform()
    {
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());

        ChangeSet changes;
        if (negation) {
            // can't remove parentheses since that might break precedence
            changes.remove(currentFile->range(negation->unary_op_token));
        } else if (nested) {
            changes.insert(currentFile->startOf(nested), QLatin1String("!"));
        } else {
            changes.insert(currentFile->startOf(binary), QLatin1String("!("));
            changes.insert(currentFile->endOf(binary), QLatin1String(")"));
342
        }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
343 344 345 346
        changes.replace(currentFile->range(binary->binary_op_token), replacement);
        currentFile->setChangeSet(changes);
        currentFile->apply();
    }
347

Nikolai Kosjar's avatar
Nikolai Kosjar committed
348 349 350 351
private:
    BinaryExpressionAST *binary;
    NestedExpressionAST *nested;
    UnaryExpressionAST *negation;
352

Nikolai Kosjar's avatar
Nikolai Kosjar committed
353
    QString replacement;
354 355
};

356 357
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
358 359 360 361 362 363 364 365
void InverseLogicalComparison::match(const CppQuickFixInterface &interface,
                                     QuickFixOperations &result)
{
    CppRefactoringFilePtr file = interface->currentFile();

    const QList<AST *> &path = interface->path();
    int index = path.size() - 1;
    BinaryExpressionAST *binary = path.at(index)->asBinaryExpression();
366
    if (!binary)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
367
        return;
368
    if (!interface->isCursorOn(binary->binary_op_token))
Nikolai Kosjar's avatar
Nikolai Kosjar committed
369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
        return;

    Kind invertToken;
    switch (file->tokenAt(binary->binary_op_token).kind()) {
    case T_LESS_EQUAL:
        invertToken = T_GREATER;
        break;
    case T_LESS:
        invertToken = T_GREATER_EQUAL;
        break;
    case T_GREATER:
        invertToken = T_LESS_EQUAL;
        break;
    case T_GREATER_EQUAL:
        invertToken = T_LESS;
        break;
    case T_EQUAL_EQUAL:
        invertToken = T_EXCLAIM_EQUAL;
        break;
    case T_EXCLAIM_EQUAL:
        invertToken = T_EQUAL_EQUAL;
        break;
    default:
        return;
    }
394

Nikolai Kosjar's avatar
Nikolai Kosjar committed
395 396 397
    result.append(CppQuickFixOperation::Ptr(
        new InverseLogicalComparisonOp(interface, index, binary, invertToken)));
}
398

399 400
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
401
class FlipLogicalOperandsOp: public CppQuickFixOperation
402 403
{
public:
Nikolai Kosjar's avatar
Nikolai Kosjar committed
404 405 406 407 408
    FlipLogicalOperandsOp(const CppQuickFixInterface &interface, int priority,
                          BinaryExpressionAST *binary, QString replacement)
        : CppQuickFixOperation(interface)
        , binary(binary)
        , replacement(replacement)
409
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
410 411
        setPriority(priority);
    }
412

Nikolai Kosjar's avatar
Nikolai Kosjar committed
413 414 415 416 417 418 419
    QString description() const
    {
        if (replacement.isEmpty())
            return QApplication::translate("CppTools::QuickFix", "Swap Operands");
        else
            return QApplication::translate("CppTools::QuickFix", "Rewrite Using %1").arg(replacement);
    }
420

Nikolai Kosjar's avatar
Nikolai Kosjar committed
421 422 423 424
    void perform()
    {
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());
425

Nikolai Kosjar's avatar
Nikolai Kosjar committed
426
        ChangeSet changes;
427 428
        changes.flip(currentFile->range(binary->left_expression),
                     currentFile->range(binary->right_expression));
429
        if (!replacement.isEmpty())
Nikolai Kosjar's avatar
Nikolai Kosjar committed
430
            changes.replace(currentFile->range(binary->binary_op_token), replacement);
431

Nikolai Kosjar's avatar
Nikolai Kosjar committed
432 433
        currentFile->setChangeSet(changes);
        currentFile->apply();
434 435 436
    }

private:
Nikolai Kosjar's avatar
Nikolai Kosjar committed
437 438 439
    BinaryExpressionAST *binary;
    QString replacement;
};
440

441 442
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
443 444 445 446
void FlipLogicalOperands::match(const CppQuickFixInterface &interface, QuickFixOperations &result)
{
    const QList<AST *> &path = interface->path();
    CppRefactoringFilePtr file = interface->currentFile();
447

Nikolai Kosjar's avatar
Nikolai Kosjar committed
448 449
    int index = path.size() - 1;
    BinaryExpressionAST *binary = path.at(index)->asBinaryExpression();
450
    if (!binary)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
451
        return;
452
    if (!interface->isCursorOn(binary->binary_op_token))
Nikolai Kosjar's avatar
Nikolai Kosjar committed
453
        return;
454

Nikolai Kosjar's avatar
Nikolai Kosjar committed
455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
    Kind flipToken;
    switch (file->tokenAt(binary->binary_op_token).kind()) {
    case T_LESS_EQUAL:
        flipToken = T_GREATER_EQUAL;
        break;
    case T_LESS:
        flipToken = T_GREATER;
        break;
    case T_GREATER:
        flipToken = T_LESS;
        break;
    case T_GREATER_EQUAL:
        flipToken = T_LESS_EQUAL;
        break;
    case T_EQUAL_EQUAL:
    case T_EXCLAIM_EQUAL:
    case T_AMPER_AMPER:
    case T_PIPE_PIPE:
        flipToken = T_EOF_SYMBOL;
        break;
    default:
        return;
    }
478

Nikolai Kosjar's avatar
Nikolai Kosjar committed
479 480 481 482 483 484
    QString replacement;
    if (flipToken != T_EOF_SYMBOL) {
        Token tok;
        tok.f.kind = flipToken;
        replacement = QLatin1String(tok.spell());
    }
485

Nikolai Kosjar's avatar
Nikolai Kosjar committed
486 487 488
    result.append(QuickFixOperation::Ptr(
        new FlipLogicalOperandsOp(interface, index, binary, replacement)));
}
489

490 491
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
492
class RewriteLogicalAndOp: public CppQuickFixOperation
493 494
{
public:
Nikolai Kosjar's avatar
Nikolai Kosjar committed
495 496 497 498 499 500 501 502
    QSharedPointer<ASTPatternBuilder> mk;
    UnaryExpressionAST *left;
    UnaryExpressionAST *right;
    BinaryExpressionAST *pattern;

    RewriteLogicalAndOp(const CppQuickFixInterface &interface)
        : CppQuickFixOperation(interface)
        , mk(new ASTPatternBuilder)
503
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
504 505 506 507
        left = mk->UnaryExpression();
        right = mk->UnaryExpression();
        pattern = mk->BinaryExpression(left, right);
    }
508

Nikolai Kosjar's avatar
Nikolai Kosjar committed
509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527
    void perform()
    {
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());

        ChangeSet changes;
        changes.replace(currentFile->range(pattern->binary_op_token), QLatin1String("||"));
        changes.remove(currentFile->range(left->unary_op_token));
        changes.remove(currentFile->range(right->unary_op_token));
        const int start = currentFile->startOf(pattern);
        const int end = currentFile->endOf(pattern);
        changes.insert(start, QLatin1String("!("));
        changes.insert(end, QLatin1String(")"));

        currentFile->setChangeSet(changes);
        currentFile->appendIndentRange(currentFile->range(pattern));
        currentFile->apply();
    }
};
528

529 530
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
531 532 533 534 535
void RewriteLogicalAnd::match(const CppQuickFixInterface &interface, QuickFixOperations &result)
{
    BinaryExpressionAST *expression = 0;
    const QList<AST *> &path = interface->path();
    CppRefactoringFilePtr file = interface->currentFile();
536

Nikolai Kosjar's avatar
Nikolai Kosjar committed
537 538 539 540 541
    int index = path.size() - 1;
    for (; index != -1; --index) {
        expression = path.at(index)->asBinaryExpression();
        if (expression)
            break;
542 543
    }

544
    if (!expression)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
545
        return;
546

547
    if (!interface->isCursorOn(expression->binary_op_token))
Nikolai Kosjar's avatar
Nikolai Kosjar committed
548
        return;
549

Nikolai Kosjar's avatar
Nikolai Kosjar committed
550
    QSharedPointer<RewriteLogicalAndOp> op(new RewriteLogicalAndOp(interface));
551

Nikolai Kosjar's avatar
Nikolai Kosjar committed
552 553 554 555
    if (expression->match(op->pattern, &matcher) &&
            file->tokenAt(op->pattern->binary_op_token).is(T_AMPER_AMPER) &&
            file->tokenAt(op->left->unary_op_token).is(T_EXCLAIM) &&
            file->tokenAt(op->right->unary_op_token).is(T_EXCLAIM)) {
556 557
        op->setDescription(QApplication::translate("CppTools::QuickFix",
                                                   "Rewrite Condition Using ||"));
Nikolai Kosjar's avatar
Nikolai Kosjar committed
558 559 560 561
        op->setPriority(index);
        result.append(op);
    }
}
562

Nikolai Kosjar's avatar
Nikolai Kosjar committed
563 564
bool SplitSimpleDeclaration::checkDeclaration(SimpleDeclarationAST *declaration)
{
565
    if (!declaration->semicolon_token)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
566
        return false;
567

568
    if (!declaration->decl_specifier_list)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
569
        return false;
570

Nikolai Kosjar's avatar
Nikolai Kosjar committed
571 572
    for (SpecifierListAST *it = declaration->decl_specifier_list; it; it = it->next) {
        SpecifierAST *specifier = it->value;
573

Nikolai Kosjar's avatar
Nikolai Kosjar committed
574
        if (specifier->asEnumSpecifier() != 0)
575 576
            return false;

Nikolai Kosjar's avatar
Nikolai Kosjar committed
577
        else if (specifier->asClassSpecifier() != 0)
578
            return false;
Nikolai Kosjar's avatar
Nikolai Kosjar committed
579
    }
580

581
    if (!declaration->declarator_list)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
582
        return false;
583

584
    else if (!declaration->declarator_list->next)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
585
        return false;
586

Nikolai Kosjar's avatar
Nikolai Kosjar committed
587 588
    return true;
}
589

590 591
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
592 593 594 595 596 597 598 599 600 601
class SplitSimpleDeclarationOp: public CppQuickFixOperation
{
public:
    SplitSimpleDeclarationOp(const CppQuickFixInterface &interface, int priority,
                             SimpleDeclarationAST *decl)
        : CppQuickFixOperation(interface, priority)
        , declaration(decl)
    {
        setDescription(QApplication::translate("CppTools::QuickFix",
                                               "Split Declaration"));
602 603
    }

Nikolai Kosjar's avatar
Nikolai Kosjar committed
604
    void perform()
605
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
606 607
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());
608

Nikolai Kosjar's avatar
Nikolai Kosjar committed
609
        ChangeSet changes;
610

Nikolai Kosjar's avatar
Nikolai Kosjar committed
611 612 613 614
        SpecifierListAST *specifiers = declaration->decl_specifier_list;
        int declSpecifiersStart = currentFile->startOf(specifiers->firstToken());
        int declSpecifiersEnd = currentFile->endOf(specifiers->lastToken() - 1);
        int insertPos = currentFile->endOf(declaration->semicolon_token);
615

Nikolai Kosjar's avatar
Nikolai Kosjar committed
616
        DeclaratorAST *prevDeclarator = declaration->declarator_list->value;
617

Nikolai Kosjar's avatar
Nikolai Kosjar committed
618 619
        for (DeclaratorListAST *it = declaration->declarator_list->next; it; it = it->next) {
            DeclaratorAST *declarator = it->value;
620

Nikolai Kosjar's avatar
Nikolai Kosjar committed
621 622 623 624 625
            changes.insert(insertPos, QLatin1String("\n"));
            changes.copy(declSpecifiersStart, declSpecifiersEnd, insertPos);
            changes.insert(insertPos, QLatin1String(" "));
            changes.move(currentFile->range(declarator), insertPos);
            changes.insert(insertPos, QLatin1String(";"));
626

Nikolai Kosjar's avatar
Nikolai Kosjar committed
627 628
            const int prevDeclEnd = currentFile->endOf(prevDeclarator);
            changes.remove(prevDeclEnd, currentFile->startOf(declarator));
629

Nikolai Kosjar's avatar
Nikolai Kosjar committed
630
            prevDeclarator = declarator;
631
        }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
632 633 634 635

        currentFile->setChangeSet(changes);
        currentFile->appendIndentRange(currentFile->range(declaration));
        currentFile->apply();
636 637 638
    }

private:
Nikolai Kosjar's avatar
Nikolai Kosjar committed
639 640
    SimpleDeclarationAST *declaration;
};
641

642 643
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
644 645 646 647 648 649 650
void SplitSimpleDeclaration::match(const CppQuickFixInterface &interface,
                                   QuickFixOperations &result)
{
    CoreDeclaratorAST *core_declarator = 0;
    const QList<AST *> &path = interface->path();
    CppRefactoringFilePtr file = interface->currentFile();
    const int cursorPosition = file->cursor().selectionStart();
651

Nikolai Kosjar's avatar
Nikolai Kosjar committed
652 653
    for (int index = path.size() - 1; index != -1; --index) {
        AST *node = path.at(index);
654

655
        if (CoreDeclaratorAST *coreDecl = node->asCoreDeclarator()) {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
656
            core_declarator = coreDecl;
657
        } else if (SimpleDeclarationAST *simpleDecl = node->asSimpleDeclaration()) {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
658 659
            if (checkDeclaration(simpleDecl)) {
                SimpleDeclarationAST *declaration = simpleDecl;
660

Nikolai Kosjar's avatar
Nikolai Kosjar committed
661 662
                const int startOfDeclSpecifier = file->startOf(declaration->decl_specifier_list->firstToken());
                const int endOfDeclSpecifier = file->endOf(declaration->decl_specifier_list->lastToken() - 1);
663

Nikolai Kosjar's avatar
Nikolai Kosjar committed
664 665 666 667 668 669
                if (cursorPosition >= startOfDeclSpecifier && cursorPosition <= endOfDeclSpecifier) {
                    // the AST node under cursor is a specifier.
                    result.append(QuickFixOperation::Ptr(
                        new SplitSimpleDeclarationOp(interface, index, declaration)));
                    return;
                }
670

Nikolai Kosjar's avatar
Nikolai Kosjar committed
671 672 673 674 675 676
                if (core_declarator && interface->isCursorOn(core_declarator)) {
                    // got a core-declarator under the text cursor.
                    result.append(QuickFixOperation::Ptr(
                        new SplitSimpleDeclarationOp(interface, index, declaration)));
                    return;
                }
677 678
            }

Nikolai Kosjar's avatar
Nikolai Kosjar committed
679
            return;
680
        }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
681 682
    }
}
683

684 685
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
686 687 688 689 690 691 692
class AddBracesToIfOp: public CppQuickFixOperation
{
public:
    AddBracesToIfOp(const CppQuickFixInterface &interface, int priority, StatementAST *statement)
        : CppQuickFixOperation(interface, priority)
        , _statement(statement)
    {
693
        setDescription(QApplication::translate("CppTools::QuickFix", "Add Curly Braces"));
Nikolai Kosjar's avatar
Nikolai Kosjar committed
694 695 696 697 698 699 700 701
    }

    void perform()
    {
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());

        ChangeSet changes;
702

Nikolai Kosjar's avatar
Nikolai Kosjar committed
703 704
        const int start = currentFile->endOf(_statement->firstToken() - 1);
        changes.insert(start, QLatin1String(" {"));
705

Nikolai Kosjar's avatar
Nikolai Kosjar committed
706 707
        const int end = currentFile->endOf(_statement->lastToken() - 1);
        changes.insert(end, QLatin1String("\n}"));
708

Nikolai Kosjar's avatar
Nikolai Kosjar committed
709
        currentFile->setChangeSet(changes);
710
        currentFile->appendIndentRange(ChangeSet::Range(start, end));
Nikolai Kosjar's avatar
Nikolai Kosjar committed
711 712 713 714 715 716 717
        currentFile->apply();
    }

private:
    StatementAST *_statement;
};

718 719
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
720
void AddBracesToIf::match(const CppQuickFixInterface &interface, QuickFixOperations &result)
721
{
Nikolai Kosjar's avatar
Nikolai Kosjar committed
722
    const QList<AST *> &path = interface->path();
723

Nikolai Kosjar's avatar
Nikolai Kosjar committed
724 725 726 727
    // show when we're on the 'if' of an if statement
    int index = path.size() - 1;
    IfStatementAST *ifStatement = path.at(index)->asIfStatement();
    if (ifStatement && interface->isCursorOn(ifStatement->if_token) && ifStatement->statement
728
        && !ifStatement->statement->asCompoundStatement()) {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
729 730 731 732 733 734 735 736
        result.append(QuickFixOperation::Ptr(
            new AddBracesToIfOp(interface, index, ifStatement->statement)));
        return;
    }

    // or if we're on the statement contained in the if
    // ### This may not be such a good idea, consider nested ifs...
    for (; index != -1; --index) {
737
        IfStatementAST *ifStatement = path.at(index)->asIfStatement();
Nikolai Kosjar's avatar
Nikolai Kosjar committed
738 739
        if (ifStatement && ifStatement->statement
            && interface->isCursorOn(ifStatement->statement)
740
            && !ifStatement->statement->asCompoundStatement()) {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
741 742
            result.append(QuickFixOperation::Ptr(
                new AddBracesToIfOp(interface, index, ifStatement->statement)));
743
            return;
744
        }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
745
    }
746

Nikolai Kosjar's avatar
Nikolai Kosjar committed
747 748 749
    // ### This could very well be extended to the else branch
    // and other nodes entirely.
}
750

751 752
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
753 754 755 756 757 758 759 760 761
class MoveDeclarationOutOfIfOp: public CppQuickFixOperation
{
public:
    MoveDeclarationOutOfIfOp(const CppQuickFixInterface &interface)
        : CppQuickFixOperation(interface)
    {
        setDescription(QApplication::translate("CppTools::QuickFix",
                                               "Move Declaration out of Condition"));

762 763 764 765 766
        reset();
    }

    void reset()
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
767 768
        condition = mk.Condition();
        pattern = mk.IfStatement(condition);
769 770
    }

Nikolai Kosjar's avatar
Nikolai Kosjar committed
771
    void perform()
772
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
773 774
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());
775

Nikolai Kosjar's avatar
Nikolai Kosjar committed
776
        ChangeSet changes;
777

Nikolai Kosjar's avatar
Nikolai Kosjar committed
778
        changes.copy(currentFile->range(core), currentFile->startOf(condition));
779

Nikolai Kosjar's avatar
Nikolai Kosjar committed
780 781 782
        int insertPos = currentFile->startOf(pattern);
        changes.move(currentFile->range(condition), insertPos);
        changes.insert(insertPos, QLatin1String(";\n"));
783

Nikolai Kosjar's avatar
Nikolai Kosjar committed
784 785 786 787
        currentFile->setChangeSet(changes);
        currentFile->appendIndentRange(currentFile->range(pattern));
        currentFile->apply();
    }
788

Nikolai Kosjar's avatar
Nikolai Kosjar committed
789 790 791 792 793
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    ConditionAST *condition;
    IfStatementAST *pattern;
    CoreDeclaratorAST *core;
794 795
};

796 797
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
798 799
void MoveDeclarationOutOfIf::match(const CppQuickFixInterface &interface,
                                   QuickFixOperations &result)
800
{
Nikolai Kosjar's avatar
Nikolai Kosjar committed
801 802 803 804 805 806 807 808 809 810
    const QList<AST *> &path = interface->path();
    typedef QSharedPointer<MoveDeclarationOutOfIfOp> Ptr;
    Ptr op(new MoveDeclarationOutOfIfOp(interface));

    int index = path.size() - 1;
    for (; index != -1; --index) {
        if (IfStatementAST *statement = path.at(index)->asIfStatement()) {
            if (statement->match(op->pattern, &op->matcher) && op->condition->declarator) {
                DeclaratorAST *declarator = op->condition->declarator;
                op->core = declarator->core_declarator;
811
                if (!op->core)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
812
                    return;
813

Nikolai Kosjar's avatar
Nikolai Kosjar committed
814 815 816 817
                if (interface->isCursorOn(op->core)) {
                    op->setPriority(index);
                    result.append(op);
                    return;
818
                }
819 820

                op->reset();
821 822 823
            }
        }
    }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
824
}
825

826 827
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
828 829 830 831 832
class MoveDeclarationOutOfWhileOp: public CppQuickFixOperation
{
public:
    MoveDeclarationOutOfWhileOp(const CppQuickFixInterface &interface)
        : CppQuickFixOperation(interface)
833
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
834 835
        setDescription(QApplication::translate("CppTools::QuickFix",
                                               "Move Declaration out of Condition"));
836 837
        reset();
    }
838

839 840
    void reset()
    {
Nikolai Kosjar's avatar
Nikolai Kosjar committed
841 842 843
        condition = mk.Condition();
        pattern = mk.WhileStatement(condition);
    }
844

Nikolai Kosjar's avatar
Nikolai Kosjar committed
845 846 847 848
    void perform()
    {
        CppRefactoringChanges refactoring(snapshot());
        CppRefactoringFilePtr currentFile = refactoring.file(fileName());
849

Nikolai Kosjar's avatar
Nikolai Kosjar committed
850
        ChangeSet changes;
851

Nikolai Kosjar's avatar
Nikolai Kosjar committed
852 853
        changes.insert(currentFile->startOf(condition), QLatin1String("("));
        changes.insert(currentFile->endOf(condition), QLatin1String(") != 0"));
854

Nikolai Kosjar's avatar
Nikolai Kosjar committed
855 856 857 858 859
        int insertPos = currentFile->startOf(pattern);
        const int conditionStart = currentFile->startOf(condition);
        changes.move(conditionStart, currentFile->startOf(core), insertPos);
        changes.copy(currentFile->range(core), insertPos);
        changes.insert(insertPos, QLatin1String(";\n"));
860

Nikolai Kosjar's avatar
Nikolai Kosjar committed
861 862 863 864
        currentFile->setChangeSet(changes);
        currentFile->appendIndentRange(currentFile->range(pattern));
        currentFile->apply();
    }
865

Nikolai Kosjar's avatar
Nikolai Kosjar committed
866 867 868 869 870 871
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    ConditionAST *condition;
    WhileStatementAST *pattern;
    CoreDeclaratorAST *core;
};
872

873 874
} // anonymous namespace

Nikolai Kosjar's avatar
Nikolai Kosjar committed
875 876
void MoveDeclarationOutOfWhile::match(const CppQuickFixInterface &interface,
                                      QuickFixOperations &result)
877
{
Nikolai Kosjar's avatar
Nikolai Kosjar committed
878 879
    const QList<AST *> &path = interface->path();
    QSharedPointer<MoveDeclarationOutOfWhileOp> op(new MoveDeclarationOutOfWhileOp(interface));
880

Nikolai Kosjar's avatar
Nikolai Kosjar committed
881 882 883 884 885 886
    int index = path.size() - 1;
    for (; index != -1; --index) {
        if (WhileStatementAST *statement = path.at(index)->asWhileStatement()) {
            if (statement->match(op->pattern, &op->matcher) && op->condition->declarator) {
                DeclaratorAST *declarator = op->condition->declarator;
                op->core = declarator->core_declarator;
887

888
                if (!op->core)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
889
                    return;
890

891
                if (!declarator->equal_token)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
892
                    return;
893

894
                if (!declarator->initializer)
Nikolai Kosjar's avatar
Nikolai Kosjar committed
895
                    return;
896

Nikolai Kosjar's avatar
Nikolai Kosjar committed
897 898 899 900
                if (interface->isCursorOn(op->core)) {
                    op->setPriority(index);
                    result.append(op);
                    return;
901
                }
902 903

                op->reset();
904 905 906
            }
        }
    }
Nikolai Kosjar's avatar
Nikolai Kosjar committed
907
}
908

909 910
namespace {

Nikolai Kosjar's avatar
Nikolai Kosjar committed
911 912 913 914 915 916 917 918
class SplitIfStatementOp: public CppQuickFixOperation
{
public:
    SplitIfStatementOp(const CppQuickFixInterface &interface, int priority,
                       IfStatementAST *pattern, BinaryExpressionAST *condition)
        : CppQuickFixOperation(interface, priority)
        , pattern(pattern)
        , condition(condition)