Skip to content
  • Nikolai Kosjar's avatar
    Clang: Correct member access operator if possible · 8d6549fa
    Nikolai Kosjar authored
    
    
     1 struct Foo { int member; };
     2 void f(Foo *foo)
     3 {
     4     foo.<REQUEST COMPLETION> // correct '.' to '->' and provide results
     5 }
    
    The preferred approach would be to check if "foo" in line 4 is of
    pointer type, but there is no suitable cursor (only CompoundStmt) at
    that position since the code is usually not yet parsed and thus invalid.
    
    Thus, just run the completion as is. If there are not any results for a
    dot completion, re-run the completion with "." exchanged by "->". This
    approach is inherently slower than the preferred approach implemented in
    the built-in code model.
    
    The following rare cases are not handled:
    
     1) Requesting completion after white space:
          Works: foo.<COMPLETE HERE>
          Fails: foo. <COMPLETE HERE>
    
     2) Opening a file and requesting completion (ctrl+space) without prior
        editing. No editing before triggering completion means that no
        unsaved file is generated on the backend side, which is a
        requirement for the correction.
    
    Task-number: QTCREATORBUG-11581
    Change-Id: I6bc8e8594778774ab342755fdb01a8a3e5c52ba0
    Reviewed-by: default avatarMarco Bubke <marco.bubke@theqtcompany.com>
    8d6549fa