Commit 00f84cc6 authored by Ulf Hermann's avatar Ulf Hermann

Timeline: Properly account for out-of-bounds events

If an event has to be clipped its length gets shorter ...

Change-Id: Ic59abebff3e856214bbb12eca324816b4e9e740d
Reviewed-by: default avatarJoerg Bornemann <>
parent ba02ec3b
......@@ -102,9 +102,12 @@ TimelineRenderPass::State *TimelineSelectionRenderPass::update(
top = TimelineModel::defaultRowHeight() * (row + 1) - height;
qint64 startTime = model->startTime(selectedItem);
qint64 left = qMax(startTime - parentState->start(), (qint64)0);
qint64 width = qMin(parentState->end() - startTime, model->duration(selectedItem));
qint64 startTime = qBound(parentState->start(), model->startTime(selectedItem),
qint64 endTime = qBound(parentState->start(), model->endTime(selectedItem),
qint64 left = startTime - parentState->start();
qint64 width = endTime - startTime;
// Construct from upper left and lower right for better precision. When constructing from
// left and width the error on the left border is inherited by the right border. Like this
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment