From 0468348a2520a3eed16f66a63b47b52f2ddb3345 Mon Sep 17 00:00:00 2001
From: hjk <qtc-committer@nokia.com>
Date: Fri, 17 Sep 2010 13:50:17 +0200
Subject: [PATCH] outputpanemanager: fix potential crash in case of no
 outputpanes

Reviewed-by: dt
---
 src/plugins/coreplugin/outputpanemanager.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/coreplugin/outputpanemanager.cpp b/src/plugins/coreplugin/outputpanemanager.cpp
index 8f175ddf2f7..cfe3ab2d755 100644
--- a/src/plugins/coreplugin/outputpanemanager.cpp
+++ b/src/plugins/coreplugin/outputpanemanager.cpp
@@ -238,7 +238,7 @@ void OutputPaneManager::init()
     begin = sorted.constBegin();
     it = sorted.constEnd();
     int shortcutNumber = 1;
-    do {
+    while (it != begin) {
         --it;
         IOutputPane* outPane = it.value();
         const int idx = m_outputWidgetPane->addWidget(outPane->outputWidget(this));
@@ -283,7 +283,7 @@ void OutputPaneManager::init()
         m_widgetComboBox->addItem(outPane->displayName(), idx);
 
         connect(cmd->action(), SIGNAL(triggered()), this, SLOT(shortcutTriggered()));
-    } while (it != begin);
+    }
 
     changePage();
 }
-- 
GitLab