From 055aa15fccc03c83f95d45a41e935bd7e08623c9 Mon Sep 17 00:00:00 2001
From: Christian Kamm <christian.d.kamm@nokia.com>
Date: Mon, 29 Nov 2010 08:59:54 +0100
Subject: [PATCH] QmlJS: Remove overzealous 'undefined' check for enums.
The "value might be 'undefined'" warning triggered whenever the static
expression evaluator failed to produce a value. At the moment, it does
so for almost all non-trivial expressions.
The warning is now disabled.
Task-number: QTCREATORBUG-3208
---
src/libs/qmljs/qmljscheck.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index de741da5379..52ccde81a72 100644
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -109,10 +109,8 @@ public:
if (!enumValue->keys().contains(valueName)) {
_message.message = Check::tr("unknown value for enum");
}
- } else if (_rhsValue->asUndefinedValue()) {
- _message.kind = DiagnosticMessage::Warning;
- _message.message = Check::tr("value might be 'undefined'");
- } else if (! _rhsValue->asStringValue() && ! _rhsValue->asNumberValue()) {
+ } else if (! _rhsValue->asStringValue() && ! _rhsValue->asNumberValue()
+ && ! _rhsValue->asUndefinedValue()) {
_message.message = Check::tr("enum value is not a string or number");
}
} else {
--
GitLab