diff --git a/src/plugins/projectexplorer/buildstep.cpp b/src/plugins/projectexplorer/buildstep.cpp index ee9326128bb60c667505e9513176180c7e0e16ed..710dae58219ca8c49041564e03aa7d2fa2038501 100644 --- a/src/plugins/projectexplorer/buildstep.cpp +++ b/src/plugins/projectexplorer/buildstep.cpp @@ -31,6 +31,7 @@ #include "buildconfiguration.h" #include <utils/qtcassert.h> +#include <QtGui/QLayout> using namespace ProjectExplorer; using namespace ProjectExplorer::Internal; @@ -133,6 +134,13 @@ bool BuildStep::immutable() const return false; } +void BuildConfigWidget::fixupLayout(QWidget *widget) +{ + QWidget *parent = widget; + while((parent = parent->parentWidget()) && parent && parent->layout()) + parent->layout()->activate(); +} + IBuildStepFactory::IBuildStepFactory() { diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h index 681077ede1c7f765f2973c405d769f32d028582e..ef36ddc9cad3447a9458ab84c9b05ad949d110dc 100644 --- a/src/plugins/projectexplorer/buildstep.h +++ b/src/plugins/projectexplorer/buildstep.h @@ -171,6 +171,9 @@ public: :QWidget(0) {} + // This function iterates all parents and relayouts + // This is a hack to work around flickering + void fixupLayout(QWidget *widget); virtual QString displayName() const = 0; // This is called to set up the config widget before showing it diff --git a/src/plugins/projectexplorer/buildstepspage.cpp b/src/plugins/projectexplorer/buildstepspage.cpp index baf19c2889e04da91d1fd60117e659cb03c35f31..f35ee1578c7e40dc83c3f81744872ebe2f71b6ed 100644 --- a/src/plugins/projectexplorer/buildstepspage.cpp +++ b/src/plugins/projectexplorer/buildstepspage.cpp @@ -97,10 +97,14 @@ BuildStepsPage::~BuildStepsPage() void BuildStepsPage::toggleDetails() { QToolButton *tb = qobject_cast<QToolButton *>(sender()); - if (tb) - foreach(const BuildStepsWidgetStruct &s, m_buildSteps) - if (s.detailsButton == tb) + if (tb) { + foreach(const BuildStepsWidgetStruct &s, m_buildSteps) { + if (s.detailsButton == tb) { s.widget->setVisible(!s.widget->isVisible()); + fixupLayout(s.widget); + } + } + } } void BuildStepsPage::updateSummary() diff --git a/src/plugins/projectexplorer/environmenteditmodel.cpp b/src/plugins/projectexplorer/environmenteditmodel.cpp index 57ad65b8af738afe4cc0eb7052d05c053c8692ad..3c2b5214a29babafc7b1716344acd0304d670ae7 100644 --- a/src/plugins/projectexplorer/environmenteditmodel.cpp +++ b/src/plugins/projectexplorer/environmenteditmodel.cpp @@ -520,9 +520,25 @@ EnvironmentWidget::~EnvironmentWidget() m_model = 0; } +bool EnvironmentWidget::detailsVisible() const +{ + return m_details->isVisible(); +} + +void EnvironmentWidget::setDetailsVisible(bool b) +{ + m_details->setVisible(b); +} + void EnvironmentWidget::toggleDetails() { m_details->setVisible(!m_details->isVisible()); + emit detailsVisibleChanged(m_details->isVisible()); +} + +QWidget *EnvironmentWidget::detailsWidget() const +{ + return m_details; } void EnvironmentWidget::setBaseEnvironment(const ProjectExplorer::Environment &env) diff --git a/src/plugins/projectexplorer/environmenteditmodel.h b/src/plugins/projectexplorer/environmenteditmodel.h index f897b4c85445b369c96d7dd42ef88b2a243e7be9..8cc2debad4a3f5eb0e3ab858692f015d886ae0d7 100644 --- a/src/plugins/projectexplorer/environmenteditmodel.h +++ b/src/plugins/projectexplorer/environmenteditmodel.h @@ -104,12 +104,18 @@ public: QList<EnvironmentItem> userChanges() const; void setUserChanges(QList<EnvironmentItem> list); + bool detailsVisible() const; + void setDetailsVisible(bool b); + + QWidget *detailsWidget() const; + public slots: void updateButtons(); void toggleDetails(); signals: void userChangesUpdated(); + void detailsVisibleChanged(bool visible); private slots: void editEnvironmentButtonClicked(); diff --git a/src/plugins/projectexplorer/projectwindow.cpp b/src/plugins/projectexplorer/projectwindow.cpp index 6854ea960ce48b0180c4c662de17518008a6748b..7d9cb03135f554dd32c844672d91ce4c2395ec72 100644 --- a/src/plugins/projectexplorer/projectwindow.cpp +++ b/src/plugins/projectexplorer/projectwindow.cpp @@ -76,8 +76,9 @@ PanelsWidget::PanelsWidget(QWidget *parent) topwidgetLayout->addWidget(verticalWidget); topwidgetLayout->addStretch(10); - setWidgetResizable(true); setFrameStyle(QFrame::NoFrame); + setWidgetResizable(true); + setWidget(topwidget); } diff --git a/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.cpp b/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.cpp index ddc7210fe21f14ca8f2ab4fcaab66734b733742f..6c18557da4ff943548491f2b47cf129ce2598d6d 100644 --- a/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.cpp +++ b/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.cpp @@ -54,10 +54,18 @@ Qt4BuildEnvironmentWidget::Qt4BuildEnvironmentWidget(Qt4Project *project) connect(m_buildEnvironmentWidget, SIGNAL(userChangesUpdated()), this, SLOT(environmentModelUserChangesUpdated())); + connect(m_buildEnvironmentWidget, SIGNAL(detailsVisibleChanged(bool)), + this, SLOT(layoutFixup())); + connect(m_clearSystemEnvironmentCheckBox, SIGNAL(toggled(bool)), this, SLOT(clearSystemEnvironmentCheckBoxClicked(bool))); } +void Qt4BuildEnvironmentWidget::layoutFixup() +{ + fixupLayout(m_buildEnvironmentWidget->detailsWidget()); +} + QString Qt4BuildEnvironmentWidget::displayName() const { return tr("Build Environment"); diff --git a/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.h b/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.h index f89154a11a269cf9fbe925f78c65eda3e9ccfc9b..f55051ce1ba2992c3c41514524202bfffcc6f8a4 100644 --- a/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.h +++ b/src/plugins/qt4projectmanager/qt4buildenvironmentwidget.h @@ -58,6 +58,7 @@ public: private slots: void environmentModelUserChangesUpdated(); void clearSystemEnvironmentCheckBoxClicked(bool checked); + void layoutFixup(); private: ProjectExplorer::EnvironmentWidget *m_buildEnvironmentWidget; diff --git a/src/plugins/qt4projectmanager/qt4projectconfigwidget.cpp b/src/plugins/qt4projectmanager/qt4projectconfigwidget.cpp index 454feeed30f07a40a2e8bc0230bdbd117158d5b9..8e0619af43d77154af0727e54121f8aac622fd33 100644 --- a/src/plugins/qt4projectmanager/qt4projectconfigwidget.cpp +++ b/src/plugins/qt4projectmanager/qt4projectconfigwidget.cpp @@ -120,6 +120,7 @@ Qt4ProjectConfigWidget::~Qt4ProjectConfigWidget() void Qt4ProjectConfigWidget::toggleDetails() { m_ui->detailsWidget->setVisible(!m_ui->detailsWidget->isVisible()); + fixupLayout(m_ui->detailsWidget); } void Qt4ProjectConfigWidget::updateDetails()