Clang: Add UpdateTranslationUnitsForEditorMessage

If an editor is changing all translation units independent of their project
part they must be updated too. So we introduce a new message to update all
translation units with the same file path.

Change-Id: I70d0ea2bbca9fa880111ff7219573e54f3277026
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

src/libs/clangbackendipc/clangbackendipc-lib.pri

@@ -45,7 +45,8 @@ SOURCES += $$PWD/ipcserverinterface.cpp \
     $$PWD/fixitcontainer.cpp \
     $$PWD/requestdiagnosticsmessage.cpp \
     $$PWD/registerunsavedfilesforeditormessage.cpp \
-    $$PWD/unregisterunsavedfilesforeditormessage.cpp
+    $$PWD/unregisterunsavedfilesforeditormessage.cpp \
+    $$PWD/updatetranslationunitsforeditormessage.cpp
 
 HEADERS += \
     $$PWD/ipcserverinterface.h \
@@ -85,6 +86,7 @@ HEADERS += \
     $$PWD/fixitcontainer.h \
     $$PWD/requestdiagnosticsmessage.h \
     $$PWD/registerunsavedfilesforeditormessage.h \
-    $$PWD/unregisterunsavedfilesforeditormessage.h
+    $$PWD/unregisterunsavedfilesforeditormessage.h \
+    $$PWD/updatetranslationunitsforeditormessage.h
 
 contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols

src/libs/clangbackendipc/clangbackendipc_global.h

@@ -44,7 +44,6 @@
 #endif
 
 namespace ClangBackEnd {
-CMBIPC_EXPORT void registerTypes();
 
 enum class DiagnosticSeverity // one to one mapping of the clang enum numbers
 {

src/libs/clangbackendipc/cmbmessages.cpp

@@ -48,6 +48,7 @@
 #include "sourcerangecontainer.h"
 #include "translationunitdoesnotexistmessage.h"
 #include "unregisterunsavedfilesforeditormessage.h"
+#include "updatetranslationunitsforeditormessage.h"
 
 #include <QDataStream>
 
@@ -137,6 +138,10 @@ void Messages::registerMessages()
     qRegisterMetaType<UnregisterUnsavedFilesForEditorMessage>();
     qRegisterMetaTypeStreamOperators<UnregisterUnsavedFilesForEditorMessage>();
     QMetaType::registerComparators<UnregisterUnsavedFilesForEditorMessage>();
+
+    qRegisterMetaType<UpdateTranslationUnitsForEditorMessage>();
+    qRegisterMetaTypeStreamOperators<UpdateTranslationUnitsForEditorMessage>();
+    QMetaType::registerComparators<UpdateTranslationUnitsForEditorMessage>();
 }
 
 } // namespace ClangBackEnd

src/libs/clangbackendipc/ipcclientinterface.h

@@ -37,6 +37,7 @@ namespace ClangBackEnd {
 
 class IpcServerInterface;
 class RegisterTranslationUnitForEditorMessage;
+class UpdateTranslationUnitsForEditorMessage;
 class RegisterProjectPartsForEditorMessage;
 class UnregisterTranslationUnitsForEditorMessage;
 class UnregisterProjectPartsForEditorMessage;

src/libs/clangbackendipc/ipcserverinterface.cpp

@@ -38,6 +38,7 @@
 #include "registerunsavedfilesforeditormessage.h"
 #include "requestdiagnosticsmessage.h"
 #include "unregisterunsavedfilesforeditormessage.h"
+#include "updatetranslationunitsforeditormessage.h"
 
 #include <QDebug>
 #include <QVariant>
@@ -48,6 +49,7 @@ void IpcServerInterface::dispatch(const QVariant &message)
 {
     static const int endMessageType = QMetaType::type("ClangBackEnd::EndMessage");
     static const int registerTranslationUnitsForEditorMessageType = QMetaType::type("ClangBackEnd::RegisterTranslationUnitForEditorMessage");
+    static const int updateTranslationUnitsForEditorMessageType = QMetaType::type("ClangBackEnd::UpdateTranslationUnitsForEditorMessage");
     static const int unregisterTranslationUnitsForEditorMessageType = QMetaType::type("ClangBackEnd::UnregisterTranslationUnitsForEditorMessage");
     static const int registerProjectPartsForEditorMessageType = QMetaType::type("ClangBackEnd::RegisterProjectPartsForEditorMessage");
     static const int unregisterProjectPartsForEditorMessageType = QMetaType::type("ClangBackEnd::UnregisterProjectPartsForEditorMessage");
@@ -62,6 +64,8 @@ void IpcServerInterface::dispatch(const QVariant &message)
         end();
     else if (type == registerTranslationUnitsForEditorMessageType)
         registerTranslationUnitsForEditor(message.value<RegisterTranslationUnitForEditorMessage>());
+    else if (type == updateTranslationUnitsForEditorMessageType)
+        updateTranslationUnitsForEditor(message.value<UpdateTranslationUnitsForEditorMessage>());
     else if (type == unregisterTranslationUnitsForEditorMessageType)
         unregisterTranslationUnitsForEditor(message.value<UnregisterTranslationUnitsForEditorMessage>());
     else if (type == registerProjectPartsForEditorMessageType)

src/libs/clangbackendipc/ipcserverinterface.h

@@ -46,6 +46,7 @@ public:
 
     virtual void end() = 0;
     virtual void registerTranslationUnitsForEditor(const RegisterTranslationUnitForEditorMessage &message) = 0;
+    virtual void updateTranslationUnitsForEditor(const UpdateTranslationUnitsForEditorMessage &message) = 0;
     virtual void unregisterTranslationUnitsForEditor(const UnregisterTranslationUnitsForEditorMessage &message) = 0;
     virtual void registerProjectPartsForEditor(const RegisterProjectPartsForEditorMessage &message) = 0;
     virtual void unregisterProjectPartsForEditor(const UnregisterProjectPartsForEditorMessage &message) = 0;

src/libs/clangbackendipc/ipcserverproxy.cpp

@@ -41,6 +41,7 @@
 #include <registerunsavedfilesforeditormessage.h>
 #include <requestdiagnosticsmessage.h>
 #include <unregisterunsavedfilesforeditormessage.h>
+#include <updatetranslationunitsforeditormessage.h>
 
 #include <QLocalServer>
 #include <QLocalSocket>
@@ -78,6 +79,11 @@ void IpcServerProxy::registerTranslationUnitsForEditor(const RegisterTranslation
     writeMessageBlock.write(QVariant::fromValue(message));
 }
 
+void IpcServerProxy::updateTranslationUnitsForEditor(const ClangBackEnd::UpdateTranslationUnitsForEditorMessage &message)
+{
+    writeMessageBlock.write(QVariant::fromValue(message));
+}
+
 void IpcServerProxy::unregisterTranslationUnitsForEditor(const UnregisterTranslationUnitsForEditorMessage &message)
 {
     writeMessageBlock.write(QVariant::fromValue(message));

src/libs/clangbackendipc/ipcserverproxy.h

@@ -57,6 +57,7 @@ public:
 
     void end() override;
     void registerTranslationUnitsForEditor(const RegisterTranslationUnitForEditorMessage &message) override;
+    void updateTranslationUnitsForEditor(const UpdateTranslationUnitsForEditorMessage &message) override;
     void unregisterTranslationUnitsForEditor(const UnregisterTranslationUnitsForEditorMessage &message) override;
     void registerProjectPartsForEditor(const RegisterProjectPartsForEditorMessage &message) override;
     void unregisterProjectPartsForEditor(const UnregisterProjectPartsForEditorMessage &message) override;

src/libs/clangbackendipc/updatetranslationunitsforeditormessage.cpp

+/****************************************************************************
+**
+** Copyright (C) 2015 The Qt Company Ltd.
+** Contact: http://www.qt.io/licensing
+**
+** This file is part of Qt Creator.
+**
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia.  For licensing terms and
+** conditions see http://www.qt.io/licensing.  For further information
+** use the contact form at http://www.qt.io/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 or version 3 as published by the Free
+** Software Foundation and appearing in the file LICENSE.LGPLv21 and
+** LICENSE.LGPLv3 included in the packaging of this file.  Please review the
+** following information to ensure the GNU Lesser General Public License
+** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
+** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights.  These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+****************************************************************************/
+
+#include "updatetranslationunitsforeditormessage.h"
+
+#include "container_common.h"
+
+#include <QDataStream>
+#include <QDebug>
+
+#include <ostream>
+
+namespace ClangBackEnd {
+
+UpdateTranslationUnitsForEditorMessage::UpdateTranslationUnitsForEditorMessage(const QVector<FileContainer> &fileContainers)
+    : fileContainers_(fileContainers)
+{
+}
+
+const QVector<FileContainer> &UpdateTranslationUnitsForEditorMessage::fileContainers() const
+{
+    return fileContainers_;
+}
+
+QDataStream &operator<<(QDataStream &out, const UpdateTranslationUnitsForEditorMessage &message)
+{
+    out << message.fileContainers_;
+
+    return out;
+}
+
+QDataStream &operator>>(QDataStream &in, UpdateTranslationUnitsForEditorMessage &message)
+{
+    in >> message.fileContainers_;
+
+    return in;
+}
+
+bool operator==(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second)
+{
+    return first.fileContainers_ == second.fileContainers_;
+}
+
+bool operator<(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second)
+{
+    return compareContainer(first.fileContainers_, second.fileContainers_);
+}
+
+QDebug operator<<(QDebug debug, const UpdateTranslationUnitsForEditorMessage &message)
+{
+    debug.nospace() << "UpdateTranslationUnitsForEditorMessage(";
+
+    for (const FileContainer &fileContainer : message.fileContainers())
+        debug.nospace() << fileContainer<< ", ";
+
+    debug.nospace() << ")";
+
+    return debug;
+}
+
+void PrintTo(const UpdateTranslationUnitsForEditorMessage &message, ::std::ostream* os)
+{
+    *os << "UpdateTranslationUnitsForEditorMessage(";
+
+    for (const FileContainer &fileContainer : message.fileContainers())
+        PrintTo(fileContainer, os);
+
+    *os << ")";
+}
+
+} // namespace ClangBackEnd
+

src/libs/clangbackendipc/updatetranslationunitsforeditormessage.h

+/****************************************************************************
+**
+** Copyright (C) 2015 The Qt Company Ltd.
+** Contact: http://www.qt.io/licensing
+**
+** This file is part of Qt Creator.
+**
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia.  For licensing terms and
+** conditions see http://www.qt.io/licensing.  For further information
+** use the contact form at http://www.qt.io/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 or version 3 as published by the Free
+** Software Foundation and appearing in the file LICENSE.LGPLv21 and
+** LICENSE.LGPLv3 included in the packaging of this file.  Please review the
+** following information to ensure the GNU Lesser General Public License
+** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
+** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights.  These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+****************************************************************************/
+
+#ifndef CLANGBACKEND_UPDATEFILEFOREDITOR_H
+#define CLANGBACKEND_UPDATEFILEFOREDITOR_H
+
+#include "filecontainer.h"
+
+#include <QMetaType>
+#include <QVector>
+
+namespace ClangBackEnd {
+
+class CMBIPC_EXPORT UpdateTranslationUnitsForEditorMessage
+{
+    friend CMBIPC_EXPORT QDataStream &operator<<(QDataStream &out, const UpdateTranslationUnitsForEditorMessage &message);
+    friend CMBIPC_EXPORT QDataStream &operator>>(QDataStream &in, UpdateTranslationUnitsForEditorMessage &message);
+    friend CMBIPC_EXPORT bool operator==(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second);
+    friend CMBIPC_EXPORT bool operator<(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second);
+    friend void PrintTo(const UpdateTranslationUnitsForEditorMessage &message, ::std::ostream* os);
+public:
+    UpdateTranslationUnitsForEditorMessage() = default;
+    UpdateTranslationUnitsForEditorMessage(const QVector<FileContainer> &fileContainers);
+
+    const QVector<FileContainer> &fileContainers() const;
+
+private:
+    QVector<FileContainer> fileContainers_;
+};
+
+CMBIPC_EXPORT QDataStream &operator<<(QDataStream &out, const UpdateTranslationUnitsForEditorMessage &message);
+CMBIPC_EXPORT QDataStream &operator>>(QDataStream &in, UpdateTranslationUnitsForEditorMessage &message);
+CMBIPC_EXPORT bool operator==(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second);
+CMBIPC_EXPORT bool operator<(const UpdateTranslationUnitsForEditorMessage &first, const UpdateTranslationUnitsForEditorMessage &second);
+
+CMBIPC_EXPORT QDebug operator<<(QDebug debug, const UpdateTranslationUnitsForEditorMessage &message);
+void PrintTo(const UpdateTranslationUnitsForEditorMessage &message, ::std::ostream* os);
+} // namespace ClangBackEnd
+
+Q_DECLARE_METATYPE(ClangBackEnd::UpdateTranslationUnitsForEditorMessage)
+
+#endif // CLANGBACKEND_UPDATEFILEFOREDITOR_H

src/plugins/clangcodemodel/clangbackendipcintegration.cpp

@@ -66,6 +66,7 @@
 #include <clangbackendipc/projectpartsdonotexistmessage.h>
 #include <clangbackendipc/translationunitdoesnotexistmessage.h>
 #include <clangbackendipc/unregisterunsavedfilesforeditormessage.h>
+#include <clangbackendipc/updatetranslationunitsforeditormessage.h>
 
 #include <cplusplus/Icons.h>
 
@@ -194,6 +195,7 @@ public:
 
     void end() override;
     void registerTranslationUnitsForEditor(const ClangBackEnd::RegisterTranslationUnitForEditorMessage &message) override;
+    void updateTranslationUnitsForEditor(const ClangBackEnd::UpdateTranslationUnitsForEditorMessage &message) override;
     void unregisterTranslationUnitsForEditor(const ClangBackEnd::UnregisterTranslationUnitsForEditorMessage &message) override;
     void registerProjectPartsForEditor(const ClangBackEnd::RegisterProjectPartsForEditorMessage &message) override;
     void unregisterProjectPartsForEditor(const ClangBackEnd::UnregisterProjectPartsForEditorMessage &message) override;
@@ -218,6 +220,12 @@ void IpcSender::registerTranslationUnitsForEditor(const RegisterTranslationUnitF
      m_connection.serverProxy().registerTranslationUnitsForEditor(message);
 }
 
+void IpcSender::updateTranslationUnitsForEditor(const UpdateTranslationUnitsForEditorMessage &message)
+{
+    QTC_CHECK(m_connection.isConnected());
+    m_connection.serverProxy().updateTranslationUnitsForEditor(message);
+}
+
 void IpcSender::unregisterTranslationUnitsForEditor(const UnregisterTranslationUnitsForEditorMessage &message)
 {
      QTC_CHECK(m_connection.isConnected());
@@ -368,6 +376,16 @@ void IpcCommunicator::registerProjectsParts(const QList<CppTools::ProjectPart::P
     registerProjectPartsForEditor(projectPartContainers);
 }
 
+void IpcCommunicator::registerTranslationUnit(TextEditor::TextDocument *document)
+{
+    const QString filePath = document->filePath().toString();
+    const QString projectPartId = Utils::projectPartIdForFile(filePath);
+
+    registerTranslationUnitsForEditor({{Utf8String(filePath),
+                                        Utf8String(projectPartId),
+                                        uint(document->document()->revision())}});
+}
+
 void IpcCommunicator::updateTranslationUnitFromCppEditorDocument(const QString &filePath)
 {
     const auto document = CppTools::CppModelManager::instance()->cppEditorDocument(filePath);
@@ -388,34 +406,33 @@ CppTools::CppEditorDocumentHandle *cppDocument(const QString &filePath)
     return CppTools::CppModelManager::instance()->cppEditorDocument(filePath);
 }
 
-bool documentHasChanged(const QString &filePath, const QString &projectPartId)
+bool documentHasChanged(const QString &filePath)
 {
     auto *document = cppDocument(filePath);
 
     if (document)
-        return document->sendTracker(projectPartId).shouldSendRevision(document->revision());
+        return document->sendTracker().shouldSendRevision(document->revision());
 
     return true;
 }
 
 void setLastSentDocumentRevision(const QString &filePath,
-                                 const QString &projectPartId,
                                  uint revision)
 {
     auto *document = cppDocument(filePath);
 
     if (document)
-        document->sendTracker(projectPartId).setLastSentRevision(int(revision));
+        document->sendTracker().setLastSentRevision(int(revision));
 }
 }
 
-void IpcCommunicator::updateTranslationUnit(const QString &filePath,
-                                        const QByteArray &contents,
-                                        uint documentRevision)
+void IpcCommunicator::registerTranslationUnit(const QString &filePath,
+                                              const QByteArray &contents,
+                                              uint documentRevision)
 {
     const QString projectPartId = Utils::projectPartIdForFile(filePath);
 
-    if (documentHasChanged(filePath, projectPartId)) {
+    if (documentHasChanged(filePath)) {
         const bool hasUnsavedContent = true;
 
         registerTranslationUnitsForEditor({{filePath,
@@ -424,18 +441,30 @@ void IpcCommunicator::updateTranslationUnit(const QString &filePath,
                                             hasUnsavedContent,
                                             documentRevision}});
 
-        setLastSentDocumentRevision(filePath, projectPartId, documentRevision);
+        setLastSentDocumentRevision(filePath, documentRevision);
     }
 }
 
+void IpcCommunicator::updateTranslationUnit(const QString &filePath,
+                                            const QByteArray &contents,
+                                            uint documentRevision)
+{
+    const bool hasUnsavedContent = true;
+
+    updateTranslationUnitsForEditor({{filePath,
+                                      Utf8String(),
+                                      Utf8String::fromByteArray(contents),
+                                      hasUnsavedContent,
+                                      documentRevision}});
+}
+
 void IpcCommunicator::updateUnsavedFile(const QString &filePath, const QByteArray &contents, uint documentRevision)
 {
-    const QString projectPartId = Utils::projectPartIdForFile(filePath);
     const bool hasUnsavedContent = true;
 
     // TODO: Send new only if changed
     registerUnsavedFilesForEditor({{filePath,
-                                    projectPartId,
+                                    Utf8String(),
                                     Utf8String::fromByteArray(contents),
                                     hasUnsavedContent,
                                     documentRevision}});
@@ -446,15 +475,14 @@ void IpcCommunicator::requestDiagnostics(const FileContainer &fileContainer)
     if (m_sendMode == IgnoreSendRequests)
         return;
 
-    if (documentHasChanged(fileContainer.filePath(), fileContainer.projectPartId())) {
-        registerTranslationUnitsForEditor({fileContainer});
+    if (documentHasChanged(fileContainer.filePath())) {
+        updateTranslationUnitsForEditor({fileContainer});
 
         const RequestDiagnosticsMessage message(fileContainer);
         qCDebug(log) << ">>>" << message;
         m_ipcSender->requestDiagnostics(message);
 
         setLastSentDocumentRevision(fileContainer.filePath(),
-                                    fileContainer.projectPartId(),
                                     fileContainer.documentRevision());
     }
 }
@@ -474,10 +502,8 @@ void IpcCommunicator::updateChangeContentStartPosition(const QString &filePath,
 {
     auto *document = cppDocument(filePath);
 
-    if (document) {
-        const QString projectPartId = Utils::projectPartIdForFile(filePath);
-        document->sendTracker(projectPartId).applyContentChange(position);
-    }
+    if (document)
+        document->sendTracker().applyContentChange(position);
 }
 
 void IpcCommunicator::updateTranslationUnitIfNotCurrentDocument(Core::IDocument *document)
@@ -551,6 +577,16 @@ void IpcCommunicator::registerTranslationUnitsForEditor(const FileContainers &fi
     m_ipcSender->registerTranslationUnitsForEditor(message);
 }
 
+void IpcCommunicator::updateTranslationUnitsForEditor(const IpcCommunicator::FileContainers &fileContainers)
+{
+    if (m_sendMode == IgnoreSendRequests)
+        return;
+
+    const UpdateTranslationUnitsForEditorMessage message(fileContainers);
+    qCDebug(log) << ">>>" << message;
+    m_ipcSender->updateTranslationUnitsForEditor(message);
+}
+
 void IpcCommunicator::unregisterTranslationUnitsForEditor(const FileContainers &fileContainers)
 {
     if (m_sendMode == IgnoreSendRequests)

src/plugins/clangcodemodel/clangbackendipcintegration.h

@@ -53,6 +53,7 @@ class DiagnosticsChangedMessage;
 
 namespace TextEditor {
 class TextEditorWidget;
+class TextDocument;
 }
 
 namespace ClangCodeModel {
@@ -96,6 +97,7 @@ public:
 
     virtual void end() = 0;
     virtual void registerTranslationUnitsForEditor(const ClangBackEnd::RegisterTranslationUnitForEditorMessage &message) = 0;
+    virtual void updateTranslationUnitsForEditor(const ClangBackEnd::UpdateTranslationUnitsForEditorMessage &message) = 0;
     virtual void unregisterTranslationUnitsForEditor(const ClangBackEnd::UnregisterTranslationUnitsForEditorMessage &message) = 0;
     virtual void registerProjectPartsForEditor(const ClangBackEnd::RegisterProjectPartsForEditorMessage &message) = 0;
     virtual void unregisterProjectPartsForEditor(const ClangBackEnd::UnregisterProjectPartsForEditorMessage &message) = 0;
@@ -118,6 +120,7 @@ public:
     IpcCommunicator();
 
     void registerTranslationUnitsForEditor(const FileContainers &fileContainers);
+    void updateTranslationUnitsForEditor(const FileContainers &fileContainers);
     void unregisterTranslationUnitsForEditor(const FileContainers &fileContainers);
     void registerProjectPartsForEditor(const ProjectPartContainers &projectPartContainers);
     void unregisterProjectPartsForEditor(const QStringList &projectPartIds);
@@ -130,6 +133,8 @@ public:
 
     void registerProjectsParts(const QList<CppTools::ProjectPart::Ptr> projectParts);
 
+    void registerTranslationUnit(TextEditor::TextDocument *document);
+    void registerTranslationUnit(const QString &filePath, const QByteArray &contents, uint documentRevision);
     void updateTranslationUnitIfNotCurrentDocument(Core::IDocument *document);
     void updateTranslationUnit(Core::IDocument *document);
     void updateUnsavedFile(Core::IDocument *document);

src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp

@@ -670,18 +670,17 @@ ClangCompletionAssistProcessor::unsavedFileContent(const QByteArray &customFileC
     return info;
 }
 
-void ClangCompletionAssistProcessor::sendFileContent(const QString &projectPartId,
-                                                     const QByteArray &customFileContent)
+void ClangCompletionAssistProcessor::sendFileContent(const QByteArray &customFileContent)
 {
     // TODO: Revert custom modification after the completions
     const UnsavedFileContentInfo info = unsavedFileContent(customFileContent);
 
     IpcCommunicator &ipcCommunicator = m_interface->ipcCommunicator();
-    ipcCommunicator.registerTranslationUnitsForEditor({{m_interface->fileName(),
-                                                        projectPartId,
-                                                        Utf8String::fromByteArray(info.unsavedContent),
-                                                        info.isDocumentModified,
-                                                        uint(m_interface->textDocument()->revision())}});
+    ipcCommunicator.updateTranslationUnitsForEditor({{m_interface->fileName(),
+                                                      Utf8String(),
+                                                      Utf8String::fromByteArray(info.unsavedContent),
+                                                      info.isDocumentModified,
+                                                      uint(m_interface->textDocument()->revision())}});
 }
 namespace {
 CppTools::CppEditorDocumentHandle *cppDocument(const QString &filePath)
@@ -690,14 +689,13 @@ CppTools::CppEditorDocumentHandle *cppDocument(const QString &filePath)
 }
 
 bool shouldSendDocumentForCompletion(const QString &filePath,
-                                     const QString &projectPartId,
                                      int completionPosition)
 {
     auto *document = cppDocument(filePath);
 
     if (document) {
-        auto &sendTracker = document->sendTracker(projectPartId);
-        return sendTracker.shouldSendRevisionWithCompletionPosition(document->revision(),
+        auto &sendTracker = document->sendTracker();
+        return sendTracker.shouldSendRevisionWithCompletionPosition(int(document->revision()),
                                                                     completionPosition);
     }
 
@@ -705,14 +703,13 @@ bool shouldSendDocumentForCompletion(const QString &filePath,
 }
 
 void setLastCompletionPositionAndDocumentRevision(const QString &filePath,
-                                                  const QString &projectPartId,
                                                   int completionPosition)
 {
     auto *document = cppDocument(filePath);
 
     if (document) {
-        document->sendTracker(projectPartId).setLastCompletionPosition(completionPosition);
-        document->sendTracker(projectPartId).setLastSentRevision(document->revision());
+        document->sendTracker().setLastCompletionPosition(completionPosition);
+        document->sendTracker().setLastSentRevision(document->revision());
     }
 }
 
@@ -737,13 +734,13 @@ void ClangCompletionAssistProcessor::sendCompletionRequest(int position,
     ++column;
 
     const QString filePath = m_interface->fileName();
-    const QString projectPartId = projectPartIdForEditorDocument(filePath);
 
-    if (shouldSendDocumentForCompletion(filePath, projectPartId, position)) {
-        sendFileContent(projectPartId, customFileContent);
-        setLastCompletionPositionAndDocumentRevision(filePath, projectPartId, position);
+    if (shouldSendDocumentForCompletion(filePath, position)) {
+        sendFileContent(customFileContent);
+        setLastCompletionPositionAndDocumentRevision(filePath, position);
     }
 
+    const QString projectPartId = projectPartIdForEditorDocument(filePath);
     m_interface->ipcCommunicator().completeCode(this,
                                                 filePath,
                                                 uint(line),

src/plugins/clangcodemodel/clangcompletionassistprocessor.h

@@ -83,7 +83,7 @@ private:
     };
     UnsavedFileContentInfo unsavedFileContent(const QByteArray &customFileContent) const;
 
-    void sendFileContent(const QString &projectPartId, const QByteArray &customFileContent);
+    void sendFileContent(const QByteArray &customFileContent);
     void sendCompletionRequest(int position, const QByteArray &customFileContent);
 
     void handleAvailableCompletions(const CodeCompletions &completions);

src/plugins/clangcodemodel/clangcompletionassistprovider.cpp

@@ -31,6 +31,7 @@
 #include "clangcompletionassistprovider.h"
 
 #include "clangcompletionassistprocessor.h"
+#include "clangeditordocumentprocessor.h"