diff --git a/src/plugins/coreplugin/actionmanager/actioncontainer.cpp b/src/plugins/coreplugin/actionmanager/actioncontainer.cpp index bec545cc2627e71c9fa897b226aaaefbf50e4192..3e5ec9c4f7e9ff37ff4fcdb6e3142e66885c1013 100644 --- a/src/plugins/coreplugin/actionmanager/actioncontainer.cpp +++ b/src/plugins/coreplugin/actionmanager/actioncontainer.cpp @@ -32,6 +32,8 @@ ***************************************************************************/ #include "actioncontainer.h" +#include "actionmanager_p.h" + #include "command.h" #include "coreimpl.h" @@ -181,7 +183,7 @@ void ActionContainer::appendGroup(const QString &group, bool global) int gid = idmanager->uniqueIdentifier(group); m_groups << gid; if (global) - ActionManager::instance()->registerGlobalGroup(gid, m_id); + ActionManagerPrivate::instance()->registerGlobalGroup(gid, m_id); } /*! @@ -220,7 +222,7 @@ void ActionContainer::addAction(ICommand *action, const QString &group) if (!canAddAction(action)) return; - ActionManager *am = ActionManager::instance(); + ActionManagerPrivate *am = ActionManagerPrivate::instance(); Action *a = static_cast<Action *>(action); if (a->stateFlags() & Command::CS_PreLocation) { QList<CommandLocation> locs = a->locations(); @@ -251,7 +253,7 @@ void ActionContainer::addMenu(IActionContainer *menu, const QString &group) if (!canAddMenu(menu)) return; - ActionManager *am = ActionManager::instance(); + ActionManagerPrivate *am = ActionManagerPrivate::instance(); MenuActionContainer *mc = static_cast<MenuActionContainer *>(menu); if (mc->hasState(ActionContainer::CS_PreLocation)) { CommandLocation loc = mc->location(); @@ -396,7 +398,7 @@ void ActionContainer::addMenu(IActionContainer *menu, int pos, bool setpos) */ QAction *ActionContainer::beforeAction(int pos, int *prevKey) const { - ActionManager *am = ActionManager::instance(); + ActionManagerPrivate *am = ActionManagerPrivate::instance(); int baId = -1; diff --git a/src/plugins/coreplugin/actionmanager/actioncontainer.h b/src/plugins/coreplugin/actionmanager/actioncontainer.h index 6d116426f203930228d7d7bf3e521d221455d044..de9217834e5cee15d900dfe6a008911fb2398811 100644 --- a/src/plugins/coreplugin/actionmanager/actioncontainer.h +++ b/src/plugins/coreplugin/actionmanager/actioncontainer.h @@ -34,7 +34,7 @@ #ifndef ACTIONCONTAINER_H #define ACTIONCONTAINER_H -#include "actionmanager.h" +#include "actionmanager_p.h" #include <coreplugin/actionmanager/iactioncontainer.h> #include <coreplugin/actionmanager/icommand.h> diff --git a/src/plugins/coreplugin/actionmanager/actionmanager.cpp b/src/plugins/coreplugin/actionmanager/actionmanager.cpp index bc43374f0e463beee84403254c993e9368e9670f..f333152a6b71af33b7618c9d43cb857a05a62afd 100644 --- a/src/plugins/coreplugin/actionmanager/actionmanager.cpp +++ b/src/plugins/coreplugin/actionmanager/actionmanager.cpp @@ -31,7 +31,7 @@ ** ***************************************************************************/ -#include "actionmanager.h" +#include "actionmanager_p.h" #include "mainwindow.h" #include "actioncontainer.h" #include "command.h" @@ -146,7 +146,7 @@ namespace { using namespace Core; using namespace Core::Internal; -ActionManager* ActionManager::m_instance = 0; +ActionManagerPrivate* ActionManagerPrivate::m_instance = 0; /*! \class ActionManager @@ -159,7 +159,7 @@ ActionManager* ActionManager::m_instance = 0; /*! ... */ -ActionManager::ActionManager(MainWindow *mainWnd, UniqueIDManager *uidmgr) : +ActionManagerPrivate::ActionManagerPrivate(MainWindow *mainWnd, UniqueIDManager *uidmgr) : ActionManagerInterface(mainWnd), m_mainWnd(mainWnd) { @@ -173,7 +173,7 @@ ActionManager::ActionManager(MainWindow *mainWnd, UniqueIDManager *uidmgr) : /*! ... */ -ActionManager::~ActionManager() +ActionManagerPrivate::~ActionManagerPrivate() { qDeleteAll(m_idCmdMap.values()); qDeleteAll(m_idContainerMap.values()); @@ -182,7 +182,7 @@ ActionManager::~ActionManager() /*! ... */ -ActionManager* ActionManager::instance() +ActionManagerPrivate* ActionManagerPrivate::instance() { return m_instance; } @@ -190,7 +190,7 @@ ActionManager* ActionManager::instance() /*! ... */ -QList<int> ActionManager::defaultGroups() const +QList<int> ActionManagerPrivate::defaultGroups() const { return m_defaultGroups; } @@ -198,7 +198,7 @@ QList<int> ActionManager::defaultGroups() const /*! ... */ -QList<Command *> ActionManager::commands() const +QList<Command *> ActionManagerPrivate::commands() const { return m_idCmdMap.values(); } @@ -206,7 +206,7 @@ QList<Command *> ActionManager::commands() const /*! ... */ -QList<ActionContainer *> ActionManager::containers() const +QList<ActionContainer *> ActionManagerPrivate::containers() const { return m_idContainerMap.values(); } @@ -214,7 +214,7 @@ QList<ActionContainer *> ActionManager::containers() const /*! ... */ -void ActionManager::registerGlobalGroup(int groupId, int containerId) +void ActionManagerPrivate::registerGlobalGroup(int groupId, int containerId) { if (m_globalgroups.contains(groupId)) { qWarning() << "registerGlobalGroup: Global group " @@ -228,7 +228,7 @@ void ActionManager::registerGlobalGroup(int groupId, int containerId) /*! ... */ -bool ActionManager::hasContext(int context) const +bool ActionManagerPrivate::hasContext(int context) const { return m_context.contains(context); } @@ -236,7 +236,7 @@ bool ActionManager::hasContext(int context) const /*! ... */ -void ActionManager::setContext(const QList<int> &context) +void ActionManagerPrivate::setContext(const QList<int> &context) { // here are possibilities for speed optimization if necessary: // let commands (de-)register themselves for contexts @@ -254,7 +254,7 @@ void ActionManager::setContext(const QList<int> &context) /*! \internal */ -bool ActionManager::hasContext(QList<int> context) const +bool ActionManagerPrivate::hasContext(QList<int> context) const { for (int i=0; i<m_context.count(); ++i) { if (context.contains(m_context.at(i))) @@ -266,7 +266,7 @@ bool ActionManager::hasContext(QList<int> context) const /*! ... */ -IActionContainer *ActionManager::createMenu(const QString &id) +IActionContainer *ActionManagerPrivate::createMenu(const QString &id) { const int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); const IdContainerMap::const_iterator it = m_idContainerMap.constFind(uid); @@ -287,7 +287,7 @@ IActionContainer *ActionManager::createMenu(const QString &id) /*! ... */ -IActionContainer *ActionManager::createMenuBar(const QString &id) +IActionContainer *ActionManagerPrivate::createMenuBar(const QString &id) { const int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); const IdContainerMap::const_iterator it = m_idContainerMap.constFind(uid); @@ -308,7 +308,7 @@ IActionContainer *ActionManager::createMenuBar(const QString &id) /*! ... */ -ICommand *ActionManager::registerAction(QAction *action, const QString &id, const QList<int> &context) +ICommand *ActionManagerPrivate::registerAction(QAction *action, const QString &id, const QList<int> &context) { OverrideableAction *a = 0; ICommand *c = registerOverridableAction(action, id, false); @@ -321,7 +321,7 @@ ICommand *ActionManager::registerAction(QAction *action, const QString &id, cons /*! ... */ -ICommand *ActionManager::registerAction(QAction *action, const QString &id) +ICommand *ActionManagerPrivate::registerAction(QAction *action, const QString &id) { return registerOverridableAction(action, id, true); } @@ -329,7 +329,7 @@ ICommand *ActionManager::registerAction(QAction *action, const QString &id) /*! \internal */ -ICommand *ActionManager::registerOverridableAction(QAction *action, const QString &id, bool checkUnique) +ICommand *ActionManagerPrivate::registerOverridableAction(QAction *action, const QString &id, bool checkUnique) { OverrideableAction *a = 0; const int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); @@ -378,7 +378,7 @@ ICommand *ActionManager::registerOverridableAction(QAction *action, const QStrin /*! ... */ -ICommand *ActionManager::registerShortcut(QShortcut *shortcut, const QString &id, const QList<int> &context) +ICommand *ActionManagerPrivate::registerShortcut(QShortcut *shortcut, const QString &id, const QList<int> &context) { Shortcut *sc = 0; int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); @@ -416,9 +416,9 @@ ICommand *ActionManager::registerShortcut(QShortcut *shortcut, const QString &id } /*! - \fn void ActionManager::addAction(Core::ICommand *action, const QString &globalGroup) + \fn void ActionManagerPrivate::addAction(Core::ICommand *action, const QString &globalGroup) */ -void ActionManager::addAction(ICommand *action, const QString &globalGroup) +void ActionManagerPrivate::addAction(ICommand *action, const QString &globalGroup) { const int gid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(globalGroup); if (!m_globalgroups.contains(gid)) { @@ -435,10 +435,10 @@ void ActionManager::addAction(ICommand *action, const QString &globalGroup) } /*! - \fn void ActionManager::addMenu(Core::IActionContainer *menu, const QString &globalGroup) + \fn void ActionManagerPrivate::addMenu(Core::IActionContainer *menu, const QString &globalGroup) */ -void ActionManager::addMenu(IActionContainer *menu, const QString &globalGroup) +void ActionManagerPrivate::addMenu(IActionContainer *menu, const QString &globalGroup) { const int gid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(globalGroup); if (!m_globalgroups.contains(gid)) { @@ -457,13 +457,13 @@ void ActionManager::addMenu(IActionContainer *menu, const QString &globalGroup) /*! ... */ -ICommand *ActionManager::command(const QString &id) const +ICommand *ActionManagerPrivate::command(const QString &id) const { const int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); const IdCmdMap::const_iterator it = m_idCmdMap.constFind(uid); if (it == m_idCmdMap.constEnd()) { if (warnAboutFindFailures) - qWarning() << "ActionManager::command(): failed to find :" << id << '/' << uid; + qWarning() << "ActionManagerPrivate::command(): failed to find :" << id << '/' << uid; return 0; } return it.value(); @@ -472,13 +472,13 @@ ICommand *ActionManager::command(const QString &id) const /*! ... */ -IActionContainer *ActionManager::actionContainer(const QString &id) const +IActionContainer *ActionManagerPrivate::actionContainer(const QString &id) const { const int uid = m_mainWnd->uniqueIDManager()->uniqueIdentifier(id); const IdContainerMap::const_iterator it = m_idContainerMap.constFind(uid); if ( it == m_idContainerMap.constEnd()) { if (warnAboutFindFailures) - qWarning() << "ActionManager::actionContainer(): failed to find :" << id << '/' << uid; + qWarning() << "ActionManagerPrivate::actionContainer(): failed to find :" << id << '/' << uid; return 0; } return it.value(); @@ -487,12 +487,12 @@ IActionContainer *ActionManager::actionContainer(const QString &id) const /*! ... */ -ICommand *ActionManager::command(int uid) const +ICommand *ActionManagerPrivate::command(int uid) const { const IdCmdMap::const_iterator it = m_idCmdMap.constFind(uid); if (it == m_idCmdMap.constEnd()) { if (warnAboutFindFailures) - qWarning() << "ActionManager::command(): failed to find :" << m_mainWnd->uniqueIDManager()->stringForUniqueIdentifier(uid) << '/' << uid; + qWarning() << "ActionManagerPrivate::command(): failed to find :" << m_mainWnd->uniqueIDManager()->stringForUniqueIdentifier(uid) << '/' << uid; return 0; } return it.value(); @@ -501,12 +501,12 @@ ICommand *ActionManager::command(int uid) const /*! ... */ -IActionContainer *ActionManager::actionContainer(int uid) const +IActionContainer *ActionManagerPrivate::actionContainer(int uid) const { const IdContainerMap::const_iterator it = m_idContainerMap.constFind(uid); if (it == m_idContainerMap.constEnd()) { if (warnAboutFindFailures) - qWarning() << "ActionManager::actionContainer(): failed to find :" << m_mainWnd->uniqueIDManager()->stringForUniqueIdentifier(uid) << uid; + qWarning() << "ActionManagerPrivate::actionContainer(): failed to find :" << m_mainWnd->uniqueIDManager()->stringForUniqueIdentifier(uid) << uid; return 0; } return it.value(); @@ -519,7 +519,7 @@ static const char *sequenceKey = "Keysequence"; /*! \internal */ -void ActionManager::initialize() +void ActionManagerPrivate::initialize() { QSettings *settings = m_mainWnd->settings(); const int shortcuts = settings->beginReadArray(QLatin1String(settingsGroup)); @@ -539,7 +539,7 @@ void ActionManager::initialize() /*! ... */ -void ActionManager::saveSettings(QSettings *settings) +void ActionManagerPrivate::saveSettings(QSettings *settings) { settings->beginWriteArray(QLatin1String(settingsGroup)); int count = 0; diff --git a/src/plugins/coreplugin/actionmanager/actionmanager.h b/src/plugins/coreplugin/actionmanager/actionmanager_p.h similarity index 90% rename from src/plugins/coreplugin/actionmanager/actionmanager.h rename to src/plugins/coreplugin/actionmanager/actionmanager_p.h index dd5e2f61e92a61f3a6c4c91f5a614837da405934..9d3e49de097fac32f79dfcc328b03b9f457b5a5c 100644 --- a/src/plugins/coreplugin/actionmanager/actionmanager.h +++ b/src/plugins/coreplugin/actionmanager/actionmanager_p.h @@ -31,8 +31,8 @@ ** ***************************************************************************/ -#ifndef ACTIONMANAGER_H -#define ACTIONMANAGER_H +#ifndef ACTIONMANAGERPRIVATE_H +#define ACTIONMANAGERPRIVATE_H #include <coreplugin/actionmanager/actionmanagerinterface.h> @@ -60,16 +60,16 @@ class ActionContainer; class MainWindow; class Command; -class ActionManager : public Core::ActionManagerInterface +class ActionManagerPrivate : public Core::ActionManagerInterface { Q_OBJECT public: - ActionManager(MainWindow *mainWnd, UniqueIDManager *uidmgr); - ~ActionManager(); + ActionManagerPrivate(MainWindow *mainWnd, UniqueIDManager *uidmgr); + ~ActionManagerPrivate(); void setContext(const QList<int> &context); - static ActionManager* instance(); + static ActionManagerPrivate* instance(); void saveSettings(QSettings *settings); QList<int> defaultGroups() const; @@ -107,7 +107,7 @@ private: ICommand *registerOverridableAction(QAction *action, const QString &id, bool checkUnique); - static ActionManager* m_instance; + static ActionManagerPrivate* m_instance; QList<int> m_defaultGroups; typedef QHash<int, Command *> IdCmdMap; @@ -127,4 +127,4 @@ private: } // namespace Internal } // namespace Core -#endif // ACTIONMANAGER_H +#endif // ACTIONMANAGERPRIVATE_H diff --git a/src/plugins/coreplugin/actionmanager/command.h b/src/plugins/coreplugin/actionmanager/command.h index 848114c8b96475221b2c29997e3f11767f468d9a..1c854a94fa6c4705ff126197ea21ffe2863813e6 100644 --- a/src/plugins/coreplugin/actionmanager/command.h +++ b/src/plugins/coreplugin/actionmanager/command.h @@ -35,7 +35,7 @@ #define COMMAND_H #include "icommand.h" -#include "actionmanager.h" +#include "actionmanager_p.h" #include <QtCore/QList> #include <QtCore/QMultiMap> diff --git a/src/plugins/coreplugin/coreplugin.pro b/src/plugins/coreplugin/coreplugin.pro index 2dc558a542284910306a36453b7602119f609f75..e78e049d01bd02ec0a023fd6a1297cadd824caf2 100644 --- a/src/plugins/coreplugin/coreplugin.pro +++ b/src/plugins/coreplugin/coreplugin.pro @@ -101,7 +101,7 @@ HEADERS += mainwindow.h \ actionmanager/iactioncontainer.h \ actionmanager/actionmanagerinterface.h \ actionmanager/icommand.h \ - actionmanager/actionmanager.h \ + actionmanager/actionmanager_p.h \ actionmanager/command.h \ actionmanager/actioncontainer.h \ actionmanager/commandsfile.h \ diff --git a/src/plugins/coreplugin/dialogs/shortcutsettings.cpp b/src/plugins/coreplugin/dialogs/shortcutsettings.cpp index ec1c3975c4dd62ee8772c5852e3dbd76de8b4aa9..5d6ae28147f5635d236ba101f835fac80d33d893 100644 --- a/src/plugins/coreplugin/dialogs/shortcutsettings.cpp +++ b/src/plugins/coreplugin/dialogs/shortcutsettings.cpp @@ -33,7 +33,7 @@ #include "shortcutsettings.h" #include "ui_shortcutsettings.h" -#include "actionmanager.h" +#include "actionmanager_p.h" #include "command.h" #include "coreconstants.h" #include "coreimpl.h" @@ -281,7 +281,7 @@ void ShortcutSettings::initialize() { QMap<QString, QTreeWidgetItem *> categories; - m_am = ActionManager::instance(); + m_am = ActionManagerPrivate::instance(); UniqueIDManager *uidm = CoreImpl::instance()->uniqueIDManager(); diff --git a/src/plugins/coreplugin/dialogs/shortcutsettings.h b/src/plugins/coreplugin/dialogs/shortcutsettings.h index 99d4a8fbbc433880aaf9f439cf1c013213aae7c5..f79bf89386bda3854cfcf73d2acbdfe015724025 100644 --- a/src/plugins/coreplugin/dialogs/shortcutsettings.h +++ b/src/plugins/coreplugin/dialogs/shortcutsettings.h @@ -51,7 +51,7 @@ class ICommand; namespace Internal { -class ActionManager; +class ActionManagerPrivate; class Command; class MainWindow; @@ -101,7 +101,7 @@ private: int translateModifiers(Qt::KeyboardModifiers state, const QString &text); QList<ShortcutItem *> m_scitems; - ActionManager *m_am; + ActionManagerPrivate *m_am; int m_key[4], m_keyNum; Ui_ShortcutSettings *m_page; }; diff --git a/src/plugins/coreplugin/mainwindow.cpp b/src/plugins/coreplugin/mainwindow.cpp index b368ad8cf4dcce84e36d4461209f9fa5ef7f2435..f5d5a24c1c44c7919b59a9a222a9c1827ae26709 100644 --- a/src/plugins/coreplugin/mainwindow.cpp +++ b/src/plugins/coreplugin/mainwindow.cpp @@ -33,7 +33,7 @@ #include "mainwindow.h" #include "actioncontainer.h" -#include "actionmanager.h" +#include "actionmanager_p.h" #include "basemode.h" #include "coreimpl.h" #include "coreconstants.h" @@ -115,7 +115,7 @@ MainWindow::MainWindow() : m_additionalContexts(m_globalContext), m_settings(new QSettings(QSettings::IniFormat, QSettings::UserScope, QLatin1String("Nokia"), QLatin1String("QtCreator"), this)), m_printer(0), - m_actionManager(new ActionManager(this, m_uniqueIDManager)), + m_actionManager(new ActionManagerPrivate(this, m_uniqueIDManager)), m_editorManager(0), m_fileManager(new FileManager(m_coreImpl, this)), m_progressManager(new ProgressManager()), @@ -362,9 +362,9 @@ QStatusBar *MainWindow::statusBar() const void MainWindow::registerDefaultContainers() { - ActionManager *am = m_actionManager; + ActionManagerPrivate *am = m_actionManager; - IActionContainer *menubar = m_actionManager->createMenuBar(Constants::MENU_BAR); + IActionContainer *menubar = am->createMenuBar(Constants::MENU_BAR); #ifndef Q_WS_MAC // System menu bar on Mac setMenuBar(menubar->menuBar()); @@ -427,7 +427,7 @@ void MainWindow::registerDefaultContainers() ac->appendGroup(Constants::G_HELP_ABOUT, true); } -static ICommand *createSeparator(ActionManager *am, QObject *parent, +static ICommand *createSeparator(ActionManagerPrivate *am, QObject *parent, const QString &name, const QList<int> &context) { @@ -439,7 +439,7 @@ static ICommand *createSeparator(ActionManager *am, QObject *parent, void MainWindow::registerDefaultActions() { - ActionManager *am = m_actionManager; + ActionManagerPrivate *am = m_actionManager; IActionContainer *mfile = am->actionContainer(Constants::M_FILE); IActionContainer *medit = am->actionContainer(Constants::M_EDIT); IActionContainer *mtools = am->actionContainer(Constants::M_TOOLS); diff --git a/src/plugins/coreplugin/mainwindow.h b/src/plugins/coreplugin/mainwindow.h index 913e6728e71e7b8491d82de18a959f153b1150d0..c7462fd80949c0fee2ab63c7f096833919ad0617 100644 --- a/src/plugins/coreplugin/mainwindow.h +++ b/src/plugins/coreplugin/mainwindow.h @@ -74,7 +74,7 @@ class ViewManagerInterface; namespace Internal { -class ActionManager; +class ActionManagerPrivate; class CoreImpl; class FancyTabWidget; class GeneralSettings; @@ -176,7 +176,7 @@ private: QList<int> m_additionalContexts; QSettings *m_settings; mutable QPrinter *m_printer; - ActionManager *m_actionManager; + ActionManagerPrivate *m_actionManager; EditorManager *m_editorManager; FileManager *m_fileManager; MessageManager *m_messageManager; diff --git a/src/plugins/projectexplorer/taskwindow.cpp b/src/plugins/projectexplorer/taskwindow.cpp index b702bb98bd36da12bcf65830b232a24d07b8cff3..91fa1d31ba0914630ef19b536e1fd4da81dfe08b 100644 --- a/src/plugins/projectexplorer/taskwindow.cpp +++ b/src/plugins/projectexplorer/taskwindow.cpp @@ -34,7 +34,7 @@ #include "taskwindow.h" #include <coreplugin/editormanager/editormanager.h> -#include <coreplugin/actionmanager/actionmanager.h> +#include <coreplugin/actionmanager/actionmanagerinterface.h> #include <coreplugin/editormanager/editormanager.h> #include <coreplugin/coreconstants.h> #include <coreplugin/uniqueidmanager.h> diff --git a/src/plugins/quickopen/quickopenplugin.cpp b/src/plugins/quickopen/quickopenplugin.cpp index d38502815dee1a50cae6e678e32549e4ad97db62..734f1488fdbf96021262dceb9254685e8a0d66b9 100644 --- a/src/plugins/quickopen/quickopenplugin.cpp +++ b/src/plugins/quickopen/quickopenplugin.cpp @@ -49,7 +49,7 @@ #include <coreplugin/coreconstants.h> #include <coreplugin/uniqueidmanager.h> #include <coreplugin/progressmanager/progressmanagerinterface.h> -#include <coreplugin/actionmanager/actionmanager.h> +#include <coreplugin/actionmanager/actionmanagerinterface.h> #include <qtconcurrent/QtConcurrentTools> using namespace QuickOpen;