CodeAssist: Remove needless indirection in item access

Change-Id: Ibcb6c4898b34ecab52de28485befdf589bb880d7
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

src/plugins/qmljseditor/qmljscompletionassist.cpp

@@ -1033,7 +1033,7 @@ void QmlJSAssistProposalModel::filter(const QString &prefix)
 
 void QmlJSAssistProposalModel::sort(const QString &prefix)
 {
-    std::sort(currentItems().first, currentItems().second, QmlJSLessThan(prefix));
+    std::sort(m_currentItems.begin(), m_currentItems.end(), QmlJSLessThan(prefix));
 }
 
 bool QmlJSAssistProposalModel::keepPerfectMatch(AssistReason reason) const

src/plugins/texteditor/codeassist/genericproposalmodel.cpp

@@ -326,10 +326,3 @@ AssistProposalItem *GenericProposalModel::proposalItem(int index) const
 {
     return m_currentItems.at(index);
 }
-
-QPair<QList<AssistProposalItem *>::iterator,
-      QList<AssistProposalItem *>::iterator>
-GenericProposalModel::currentItems()
-{
-    return qMakePair(m_currentItems.begin(), m_currentItems.end());
-}

src/plugins/texteditor/codeassist/genericproposalmodel.h

@@ -74,8 +74,6 @@ public:
     bool isSortingAllowed() const;
 
 protected:
-    typedef QList<AssistProposalItem *>::iterator ItemIterator;
-    QPair<ItemIterator, ItemIterator> currentItems();
     QList<AssistProposalItem *> m_currentItems;
 
 private: