diff --git a/src/plugins/projectexplorer/buildparserfactory.cpp b/src/plugins/projectexplorer/buildparserfactory.cpp index cb9326d68ba10d9765949269b548a7dc7e3ce2cd..e4b8895eaee2f35c25b5e12a763d199e291a530e 100644 --- a/src/plugins/projectexplorer/buildparserfactory.cpp +++ b/src/plugins/projectexplorer/buildparserfactory.cpp @@ -32,7 +32,6 @@ #include "projectexplorerconstants.h" #include "gccparser.h" #include "msvcparser.h" -#include "qmakeparser.h" using namespace ProjectExplorer::Internal; @@ -65,18 +64,3 @@ ProjectExplorer::IBuildParser * MsvcParserFactory::create(const QString & name) Q_UNUSED(name) return new MsvcParser(); } - -QMakeParserFactory::~QMakeParserFactory() -{ -} - -bool QMakeParserFactory::canCreate(const QString & name) const -{ - return (name == Constants::BUILD_PARSER_QMAKE); -} - -ProjectExplorer::IBuildParser * QMakeParserFactory::create(const QString & name) const -{ - Q_UNUSED(name) - return new QMakeParser(); -} diff --git a/src/plugins/projectexplorer/buildparserfactory.h b/src/plugins/projectexplorer/buildparserfactory.h index f953d63ebf6a2006d82629f3f42645bcf4b4d24c..e29570f2baf2e3d0f0e8f2c964b8ec1bded97a17 100644 --- a/src/plugins/projectexplorer/buildparserfactory.h +++ b/src/plugins/projectexplorer/buildparserfactory.h @@ -55,16 +55,6 @@ public: virtual ProjectExplorer::IBuildParser * create(const QString & name) const; }; -class QMakeParserFactory : public ProjectExplorer::IBuildParserFactory -{ - Q_OBJECT -public: - QMakeParserFactory() {} - virtual ~QMakeParserFactory(); - virtual bool canCreate(const QString & name) const; - virtual ProjectExplorer::IBuildParser * create(const QString & name) const; -}; - } // namespace Internal } // namespace ProjectExplorer diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp index 2f2da8c6e0ad722dc988d4fee973f3a9814a532d..c15c303e3aea1fb6e7f621034ee95a4552cd31cd 100644 --- a/src/plugins/projectexplorer/projectexplorer.cpp +++ b/src/plugins/projectexplorer/projectexplorer.cpp @@ -307,7 +307,6 @@ bool ProjectExplorerPlugin::initialize(const QStringList &arguments, QString *er // Build parsers addAutoReleasedObject(new GccParserFactory); addAutoReleasedObject(new MsvcParserFactory); - addAutoReleasedObject(new QMakeParserFactory); // Settings page addAutoReleasedObject(new ProjectExplorerSettingsPage); diff --git a/src/plugins/projectexplorer/projectexplorer.pro b/src/plugins/projectexplorer/projectexplorer.pro index 8aaba10473a2d5b7b19963d514011543b22008a0..325f624a321b4a4a99e6388511b13fb5a04b7773 100644 --- a/src/plugins/projectexplorer/projectexplorer.pro +++ b/src/plugins/projectexplorer/projectexplorer.pro @@ -66,7 +66,6 @@ HEADERS += projectexplorer.h \ projectexplorersettingspage.h \ projectwelcomepage.h \ projectwelcomepagewidget.h \ - qmakeparser.h \ baseprojectwizarddialog.h SOURCES += projectexplorer.cpp \ projectwindow.cpp \ @@ -121,7 +120,6 @@ SOURCES += projectexplorer.cpp \ projectwelcomepage.cpp \ projectwelcomepagewidget.cpp \ corelistenercheckingforrunningbuild.cpp \ - qmakeparser.cpp \ baseprojectwizarddialog.cpp FORMS += processstep.ui \ editorsettingspropertiespage.ui \ diff --git a/src/plugins/projectexplorer/projectexplorerconstants.h b/src/plugins/projectexplorer/projectexplorerconstants.h index 262cc513675317fa404799437194688d36386136..958391e6371011e45f6075ef899d05084e701c53 100644 --- a/src/plugins/projectexplorer/projectexplorerconstants.h +++ b/src/plugins/projectexplorer/projectexplorerconstants.h @@ -179,7 +179,6 @@ const char * const FORM_MIMETYPE = "application/x-designer"; const char * const RESOURCE_MIMETYPE = "application/vnd.nokia.xml.qt.resource"; // build parsers -const char * const BUILD_PARSER_QMAKE = "BuildParser.QMake"; const char * const BUILD_PARSER_MSVC = "BuildParser.MSVC"; const char * const BUILD_PARSER_GCC = "BuildParser.Gcc"; const char * const BUILD_PARSER_RVCT = "BuildParser.Rvct"; diff --git a/src/plugins/projectexplorer/qmakeparser.cpp b/src/plugins/qt4projectmanager/qmakeparser.cpp similarity index 71% rename from src/plugins/projectexplorer/qmakeparser.cpp rename to src/plugins/qt4projectmanager/qmakeparser.cpp index 4425835f4e7c627a6cec0ccb5ff51b0902170159..767b86921af18888ca8112d25c909c07b917aa18 100644 --- a/src/plugins/projectexplorer/qmakeparser.cpp +++ b/src/plugins/qt4projectmanager/qmakeparser.cpp @@ -28,10 +28,28 @@ **************************************************************************/ #include "qmakeparser.h" -#include "projectexplorerconstants.h" -#include "taskwindow.h" +#include "qt4projectmanagerconstants.h" +#include <projectexplorer/taskwindow.h> +#include <projectexplorer/projectexplorerconstants.h> -using namespace ProjectExplorer; +using namespace Qt4ProjectManager; +using namespace Qt4ProjectManager::Internal; +using ProjectExplorer::TaskWindow; + +QMakeParserFactory::~QMakeParserFactory() +{ +} + +bool QMakeParserFactory::canCreate(const QString & name) const +{ + return (name == Constants::BUILD_PARSER_QMAKE); +} + +ProjectExplorer::IBuildParser * QMakeParserFactory::create(const QString & name) const +{ + Q_UNUSED(name) + return new QMakeParser(); +} QMakeParser::QMakeParser() { @@ -39,7 +57,7 @@ QMakeParser::QMakeParser() QString QMakeParser::name() const { - return QLatin1String(ProjectExplorer::Constants::BUILD_PARSER_QMAKE); + return QLatin1String(Qt4ProjectManager::Constants::BUILD_PARSER_QMAKE); } void QMakeParser::stdOutput(const QString & line) @@ -57,7 +75,7 @@ void QMakeParser::stdError(const QString & line) lne /* description */, QString() /* filename */, -1 /* linenumber */, - Constants::TASK_CATEGORY_BUILDSYSTEM)); + ProjectExplorer::Constants::TASK_CATEGORY_BUILDSYSTEM)); return; } } diff --git a/src/plugins/projectexplorer/qmakeparser.h b/src/plugins/qt4projectmanager/qmakeparser.h similarity index 79% rename from src/plugins/projectexplorer/qmakeparser.h rename to src/plugins/qt4projectmanager/qmakeparser.h index 5d5a1b02bb7a1b341dd18715f6c79396e22a9f63..e3bdf950a9d48ddc212b73adfe934747b0e7fe34 100644 --- a/src/plugins/projectexplorer/qmakeparser.h +++ b/src/plugins/qt4projectmanager/qmakeparser.h @@ -30,11 +30,23 @@ #ifndef QMAKEPARSER_H #define QMAKEPARSER_H -#include "ibuildparser.h" +#include <projectexplorer/ibuildparser.h> #include <QtCore/QRegExp> -namespace ProjectExplorer { +namespace Qt4ProjectManager { +namespace Internal { + +class QMakeParserFactory : public ProjectExplorer::IBuildParserFactory +{ + Q_OBJECT +public: + QMakeParserFactory() {} + virtual ~QMakeParserFactory(); + virtual bool canCreate(const QString & name) const; + virtual ProjectExplorer::IBuildParser * create(const QString & name) const; +}; + class QMakeParser : public ProjectExplorer::IBuildParser { @@ -48,6 +60,7 @@ public: private: }; +} // namesapce Interanal } // namespace ProjectExplorer #endif // QMAKEPARSER_H diff --git a/src/plugins/qt4projectmanager/qmakestep.cpp b/src/plugins/qt4projectmanager/qmakestep.cpp index c5447ce44a54cbd58d3e5603f5ded3858bcc6689..32325ec5666386d98bf1302e16cf340bf51d0550 100644 --- a/src/plugins/qt4projectmanager/qmakestep.cpp +++ b/src/plugins/qt4projectmanager/qmakestep.cpp @@ -39,8 +39,6 @@ #include <coreplugin/icore.h> #include <utils/qtcassert.h> -#include <projectexplorer/projectexplorerconstants.h> - #include <QFileDialog> #include <QDir> #include <QFile> @@ -152,7 +150,7 @@ bool QMakeStep::init() setArguments(args); setEnvironment(qt4bc->environment()); - setBuildParser(ProjectExplorer::Constants::BUILD_PARSER_QMAKE); + setBuildParser(Qt4ProjectManager::Constants::BUILD_PARSER_QMAKE); return AbstractMakeStep::init(); } diff --git a/src/plugins/qt4projectmanager/qt4projectmanager.pro b/src/plugins/qt4projectmanager/qt4projectmanager.pro index d3847c1202bc08b39bd1dc2c0209e2547f0a6e2c..aafdecbb6ae58d974cbec240f74b6ea0084cd0de 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanager.pro +++ b/src/plugins/qt4projectmanager/qt4projectmanager.pro @@ -39,7 +39,8 @@ HEADERS += qt4projectmanagerplugin.h \ externaleditors.h \ gettingstartedwelcomepagewidget.h \ gettingstartedwelcomepage.h \ - qt4buildconfiguration.h + qt4buildconfiguration.h \ + qmakeparser.h SOURCES += qt4projectmanagerplugin.cpp \ qt4projectmanager.cpp \ qt4project.cpp \ @@ -74,7 +75,8 @@ SOURCES += qt4projectmanagerplugin.cpp \ externaleditors.cpp \ gettingstartedwelcomepagewidget.cpp \ gettingstartedwelcomepage.cpp \ - qt4buildconfiguration.cpp + qt4buildconfiguration.cpp \ + qmakeparser.cpp FORMS += makestep.ui \ qmakestep.ui \ qt4projectconfigwidget.ui \ diff --git a/src/plugins/qt4projectmanager/qt4projectmanagerconstants.h b/src/plugins/qt4projectmanager/qt4projectmanagerconstants.h index 19c033a0eeecfd415adf1493bf86a2edda72d671..6af9bbb0f6ab2eb18a79c8368d9dc76607bc931b 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanagerconstants.h +++ b/src/plugins/qt4projectmanager/qt4projectmanagerconstants.h @@ -77,6 +77,9 @@ const char * const QT_SETTINGS_CATEGORY = "L.Qt4"; const char * const QT_SETTINGS_TR_CATEGORY = QT_TRANSLATE_NOOP("Qt4ProjectManager", "Qt4"); const char * const QTVERSION_SETTINGS_PAGE_ID = "Qt Versions"; const char * const QTVERSION_SETTINGS_PAGE_NAME = QT_TRANSLATE_NOOP("Qt4ProjectManager", "Qt Versions"); + +// BuildParser +const char * const BUILD_PARSER_QMAKE = "BuildParser.QMake"; } // namespace Constants } // namespace Qt4ProjectManager diff --git a/src/plugins/qt4projectmanager/qt4projectmanagerplugin.cpp b/src/plugins/qt4projectmanager/qt4projectmanagerplugin.cpp index a6fbe1c9806b0802f5d8dfdb860df0fdcda6ba9c..040691c56a0e3b23b95b99b3a3b251b1f4c1f75c 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanagerplugin.cpp +++ b/src/plugins/qt4projectmanager/qt4projectmanagerplugin.cpp @@ -45,6 +45,7 @@ #include "externaleditors.h" #include "gettingstartedwelcomepage.h" #include "gettingstartedwelcomepagewidget.h" +#include "qmakeparser.h" #ifdef QTCREATOR_WITH_S60 #include "qt-s60/s60manager.h" @@ -149,6 +150,7 @@ bool Qt4ProjectManagerPlugin::initialize(const QStringList &arguments, QString * addAutoReleasedObject(new QMakeStepFactory); addAutoReleasedObject(new MakeStepFactory); + addAutoReleasedObject(new QMakeParserFactory); addAutoReleasedObject(new Qt4RunConfigurationFactory);