From 38a5dedc4531aae3ca522328fbbaacec387ae9a3 Mon Sep 17 00:00:00 2001
From: Laurent Desmecht <laurent.desmecht@gmail.com>
Date: Thu, 25 Feb 2010 14:23:11 +0100
Subject: [PATCH] Make GenericMakeStep not immutable
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GenericMakeStep is currently immutable. This is quite annoying since
it's possible to create GenericMakeStep but it's not possible to remove
them.

Fix: make GenericMakeStep not immutable

Merge-request: 117
Reviewed-by: Thorbjørn Lindeijer <thorbjorn.lindeijer@nokia.com>
Reviewed-by: dt
Reviewed-by: Tobias Hunger
---
 src/plugins/genericprojectmanager/genericmakestep.cpp | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/plugins/genericprojectmanager/genericmakestep.cpp b/src/plugins/genericprojectmanager/genericmakestep.cpp
index 7889654de2c..1730a177594 100644
--- a/src/plugins/genericprojectmanager/genericmakestep.cpp
+++ b/src/plugins/genericprojectmanager/genericmakestep.cpp
@@ -177,14 +177,7 @@ ProjectExplorer::BuildStepConfigWidget *GenericMakeStep::createConfigWidget()
 
 bool GenericMakeStep::immutable() const
 {
-    // Only make one GenericMakeStep immutable:
-    QList<BuildStep *> steps = buildConfiguration()->buildSteps();
-    int makestepCount = 0;
-    foreach (const BuildStep *bs, steps) {
-        if (qobject_cast<const GenericMakeStep *>(bs))
-            ++makestepCount;
-    }
-    return makestepCount <= 1;
+    return false;
 }
 
 bool GenericMakeStep::buildsTarget(const QString &target) const
-- 
GitLab