From 3b46c09520056b1d08ef2f927b9ae1925ad50108 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Mon, 31 Jul 2017 17:24:47 +0200
Subject: [PATCH] Utils: Add isEmpty to string view
Change-Id: Ib7e77602dcdcdf481f6ab690bacef53c5dd92580
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
src/libs/utils/smallstringview.h | 6 ++++++
tests/unit/unittest/smallstring-test.cpp | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/src/libs/utils/smallstringview.h b/src/libs/utils/smallstringview.h
index 14be9bbb693..f7186f3db7b 100644
--- a/src/libs/utils/smallstringview.h
+++ b/src/libs/utils/smallstringview.h
@@ -85,6 +85,12 @@ public:
return m_size;
}
+ constexpr
+ size_type isEmpty() const
+ {
+ return m_size == 0;
+ }
+
const_iterator begin() const noexcept
{
return data();
diff --git a/tests/unit/unittest/smallstring-test.cpp b/tests/unit/unittest/smallstring-test.cpp
index 93367b9b507..09b21da85f5 100644
--- a/tests/unit/unittest/smallstring-test.cpp
+++ b/tests/unit/unittest/smallstring-test.cpp
@@ -731,6 +731,12 @@ TEST(SmallString, IsEmpty)
ASSERT_TRUE(SmallString().isEmpty());
}
+TEST(SmallString, StringViewIsEmpty)
+{
+ ASSERT_FALSE(SmallStringView("text").isEmpty());
+ ASSERT_TRUE(SmallStringView("").isEmpty());
+}
+
TEST(SmallString, HasContent)
{
ASSERT_TRUE(SmallString("text").hasContent());
--
GitLab