Fix break point warning dialog

QMessageBox apparently only saves the state in the actual
QMessageBox instance ... anyhow, it's the only place in
QtCreator where we use QMessageBox, which makes it look
somewhat alien. Instead, use CheckableMessageBox and
extend it for an information dialog.

Task-number: QTCREATORBUG-9876

Change-Id: I8014e972943dd4a336952325ebb9f6cbc5dd0902
Reviewed-by: hjk <hjk121@nokiamail.com>

src/libs/utils/checkablemessagebox.cpp

@@ -256,6 +256,28 @@ CheckableMessageBox::question(QWidget *parent,
     return mb.clickedStandardButton();
 }
 
+QDialogButtonBox::StandardButton
+CheckableMessageBox::information(QWidget *parent,
+                              const QString &title,
+                              const QString &text,
+                              const QString &checkBoxText,
+                              bool *checkBoxSetting,
+                              QDialogButtonBox::StandardButtons buttons,
+                              QDialogButtonBox::StandardButton defaultButton)
+{
+    CheckableMessageBox mb(parent);
+    mb.setWindowTitle(title);
+    mb.setIconPixmap(QMessageBox::standardIcon(QMessageBox::Information));
+    mb.setText(text);
+    mb.setCheckBoxText(checkBoxText);
+    mb.setChecked(*checkBoxSetting);
+    mb.setStandardButtons(buttons);
+    mb.setDefaultButton(defaultButton);
+    mb.exec();
+    *checkBoxSetting = mb.isChecked();
+    return mb.clickedStandardButton();
+}
+
 QMessageBox::StandardButton CheckableMessageBox::dialogButtonBoxToMessageBoxButton(QDialogButtonBox::StandardButton db)
 {
     return static_cast<QMessageBox::StandardButton>(int(db));

src/libs/utils/checkablemessagebox.h

@@ -62,6 +62,15 @@ public:
                  QDialogButtonBox::StandardButtons buttons = QDialogButtonBox::Yes|QDialogButtonBox::No,
                  QDialogButtonBox::StandardButton defaultButton = QDialogButtonBox::No);
 
+    static QDialogButtonBox::StandardButton
+        information(QWidget *parent,
+                 const QString &title,
+                 const QString &text,
+                 const QString &checkBoxText,
+                 bool *checkBoxSetting,
+                 QDialogButtonBox::StandardButtons buttons = QDialogButtonBox::Ok,
+                 QDialogButtonBox::StandardButton defaultButton = QDialogButtonBox::NoButton);
+
     QString text() const;
     void setText(const QString &);
 

src/plugins/debugger/debuggerrunner.cpp

@@ -54,11 +54,11 @@
 #include <projectexplorer/target.h>
 #include <projectexplorer/taskhub.h>
 
+#include <utils/checkablemessagebox.h>
 #include <utils/qtcassert.h>
 #include <utils/qtcprocess.h>
 #include <coreplugin/icore.h>
 
-#include <QErrorMessage>
 #include <QTcpServer>
 
 using namespace Debugger::Internal;
@@ -209,9 +209,14 @@ void DebuggerRunControl::start()
 
                 debuggerCore()->showMessage(warningMessage, LogWarning);
 
-                QErrorMessage *msgBox = new QErrorMessage(debuggerCore()->mainWindow());
-                msgBox->setAttribute(Qt::WA_DeleteOnClose);
-                msgBox->showMessage(warningMessage);
+                static bool checked = true;
+                if (!checked)
+                    break;
+                CheckableMessageBox::information(debuggerCore()->mainWindow(),
+                                                 tr("Debugger"),
+                                                 warningMessage,
+                                                 tr("&Show this message again."),
+                                                 &checked, QDialogButtonBox::Ok);
                 break;
             }
         }