From 40c07dbf9725af667484aa69dc4131902a6aa925 Mon Sep 17 00:00:00 2001
From: Olivier Goffart <olivier.goffart@nokia.com>
Date: Mon, 2 Aug 2010 14:46:38 +0200
Subject: [PATCH] Fix invalid read
One shall check the event is a QKeyEvent before static_cast
---
src/plugins/help/externalhelpwindow.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/plugins/help/externalhelpwindow.cpp b/src/plugins/help/externalhelpwindow.cpp
index 6ffd5b77169..36e0113d418 100644
--- a/src/plugins/help/externalhelpwindow.cpp
+++ b/src/plugins/help/externalhelpwindow.cpp
@@ -69,7 +69,8 @@ void ExternalHelpWindow::closeEvent(QCloseEvent *event)
bool ExternalHelpWindow::eventFilter(QObject *obj, QEvent *event)
{
if (obj == this) {
- if (QKeyEvent *keyEvent = static_cast<QKeyEvent*> (event)) {
+ if (event->type() == QEvent::KeyPress) {
+ QKeyEvent *keyEvent = static_cast<QKeyEvent*> (event);
switch (keyEvent->key()) {
case Qt::Key_Escape:
Core::ICore::instance()->mainWindow()->activateWindow();
--
GitLab