Commit 434e895b authored by hjk's avatar hjk

Debugger: Remove parts of the engine parameter fixup phase

The idea is that the fixup should not be needed at all anymore,
instead, static data coming e.g. from the RunConfiguration should
be setup in the constructor, and everything else should be ready
at entry into start().

This also proceeds on path to the planned-but-never-implemented
idea that the RunConfiguration should (at most) be accessed at
RunControl creation time, not later.

Change-Id: I04d622785f5de628a7bb479bc0c39aff7d6cce01
Reviewed-by: Christian Stenger's avatarChristian Stenger <christian.stenger@qt.io>
parent 899c518c
......@@ -88,7 +88,6 @@ public:
Utils::ProcessHandle attachPID;
QStringList solibSearchPath;
bool useTerminal = false;
bool needFixup = true; // FIXME: Make false the default...
// Used by Qml debugging.
QUrl qmlServer;
......@@ -160,6 +159,8 @@ public:
// For Debugger testing.
int testCase = 0;
QStringList validationErrors;
};
class UpdateParameters
......
This diff is collapsed.
......@@ -126,7 +126,7 @@ public:
void setIosPlatform(const QString &platform);
void setDeviceSymbolsRoot(const QString &deviceSymbolsRoot);
void setNeedFixup(bool on);
void setNeedFixup(bool) {} // FIXME: Remove after use in QtAppMan is gone.
void setTestCase(int testCase);
void setOverrideStartScript(const QString &script);
void setToolChainAbi(const ProjectExplorer::Abi &abi);
......@@ -135,9 +135,10 @@ signals:
void aboutToNotifyInferiorSetupOk();
private:
bool fixupParameters();
QPointer<Internal::DebuggerEngine> m_engine; // Master engine
Internal::DebuggerRunParameters m_runParameters;
QStringList m_errors;
bool m_isDying = false;
const bool m_isCppDebugging;
const bool m_isQmlDebugging;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment